From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17975C433EF for ; Mon, 15 Nov 2021 17:53:15 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id AC37463418 for ; Mon, 15 Nov 2021 17:53:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org AC37463418 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 28CC56B007B; Mon, 15 Nov 2021 12:53:14 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2161E6B007D; Mon, 15 Nov 2021 12:53:14 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 105D26B007E; Mon, 15 Nov 2021 12:53:14 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0060.hostedemail.com [216.40.44.60]) by kanga.kvack.org (Postfix) with ESMTP id F13DE6B007B for ; Mon, 15 Nov 2021 12:53:13 -0500 (EST) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id ACBF084CF9 for ; Mon, 15 Nov 2021 17:53:13 +0000 (UTC) X-FDA: 78811911066.18.D3AF4A8 Received: from mail-lj1-f172.google.com (mail-lj1-f172.google.com [209.85.208.172]) by imf19.hostedemail.com (Postfix) with ESMTP id 3A27DB0000BE for ; Mon, 15 Nov 2021 17:53:03 +0000 (UTC) Received: by mail-lj1-f172.google.com with SMTP id u22so30451123lju.7 for ; Mon, 15 Nov 2021 09:53:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=6NsJwQViYjBx6x1vnKWwbVuDzGBfSCVWT/rbaDdS07o=; b=KO3K519hv/U7eBTcKvTNDP2eKFUA2AUXYqJpuH3H7HpyMWbd/okypmhcyl68qsgEMB Tk6M3OgdZeFJesvlAB5Bhgl6XW/O9P8mk3dMd4fFh80iqqMofW9VhwiDp62KQ0N/YUUx kuKS6PM57Mxitv2Gso7uX6bsb3i2CsyEFARebzexwMlXFoA74eOMXb002OmB9tn9+Y85 wR9hyRPYMFGUdQX09cuC8rvxOvFIKVUi7nFklVRic3dV6iooqaWcyuL5oVncWpD+oPvG mL1mSaV4SWgyrxi/iuT2d03XoYCARQJVASW7AGQBqLHs2tgGfUQfKdhwJr20mXiPSoOr 4lYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6NsJwQViYjBx6x1vnKWwbVuDzGBfSCVWT/rbaDdS07o=; b=HVUUfX+3LY//mEwpgyCWCLGmNMeYfQoRdYXQo/tjqLZ8NaSvkZm5kiA6AhNYJbdj/W 36+gplHb1JKTCurStnvXAEEbGPSJBosqgWCx/lwYQtXtUY1kPzapbt16VIUaDq9RICrp NAkV7AALUYYtMPY17DW2FCMSENy5GYEKopoLJA0Vo73A4S26FhtwOfMwxQI0mryvN4AY Ql9YvaeydeeHD46OOWYEE5fi6iOWcwlkmHDjvItYzbDNwEfqy5E79kBXK3C4mPDK8wxy WqshVjzWlI5d9GAceRxnfvzCNQcGzh7ZMHSM8mrg0YWmTx/3K3WBot1bjz3PE1gynMif qBdw== X-Gm-Message-State: AOAM533MZAP3vOZeONyLofbzFLJHeilItCTKS0KGmYOYEJS1xldX0zXr SYMHRwlKGO/YS8h+0EIC0CvtUjf4zHJj8ZeuvVKyAA== X-Google-Smtp-Source: ABdhPJwhwO7vj3l7PglblWhEu/u5R0j6w6RyAXBfY3b1tMLAwK4ATaXsbDMVLHDtN2AxslDULON1DIcW72dsbChwW+w= X-Received: by 2002:a2e:9699:: with SMTP id q25mr448399lji.6.1636998791657; Mon, 15 Nov 2021 09:53:11 -0800 (PST) MIME-Version: 1.0 References: <20211108211959.1750915-1-almasrymina@google.com> <20211108211959.1750915-2-almasrymina@google.com> <20211108221047.GE418105@dread.disaster.area> <20211109011837.GF418105@dread.disaster.area> In-Reply-To: <20211109011837.GF418105@dread.disaster.area> From: Shakeel Butt Date: Mon, 15 Nov 2021 09:53:00 -0800 Message-ID: Subject: Re: [PATCH v1 1/5] mm/shmem: support deterministic charging of tmpfs To: Dave Chinner Cc: Matthew Wilcox , Mina Almasry , Michal Hocko , "Theodore Ts'o" , Greg Thelen , Andrew Morton , Hugh Dickins , Roman Gushchin , Johannes Weiner , Tejun Heo , Vladimir Davydov , riel@surriel.com, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, cgroups@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 3A27DB0000BE X-Stat-Signature: czk5agk9wxq1wg8s315kkxg4t1n35ry6 Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=KO3K519h; spf=pass (imf19.hostedemail.com: domain of shakeelb@google.com designates 209.85.208.172 as permitted sender) smtp.mailfrom=shakeelb@google.com; dmarc=pass (policy=reject) header.from=google.com X-HE-Tag: 1636998783-703353 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Nov 8, 2021 at 5:18 PM Dave Chinner wrote: > [...] > > > If we are to have this for all filesystems, then let's do that properly > > and make it generic functionality from its introduction. > > Fully agree. > Mina, I think supporting all filesystems might be a much cleaner solution than adding fs specific code. We need to: 1) Add memcg option handling in vfs_parse_fs_param() before fs specific param handling. 2) Add a new page cache memcg charging interface (similar to swap). With (1), no need to change any fs specific code. With (2), fs codepaths will be free of memcg specific handling. This new interface will be used in __filemap_add_folio(), shmem_add_to_page_cache() and collapse_file(). thanks, Shakeel