From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 122A9C38145 for ; Thu, 8 Sep 2022 02:35:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8C1926B0072; Wed, 7 Sep 2022 22:35:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8706F8D0003; Wed, 7 Sep 2022 22:35:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 737E28D0002; Wed, 7 Sep 2022 22:35:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 626B86B0072 for ; Wed, 7 Sep 2022 22:35:23 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 39C9FA0A18 for ; Thu, 8 Sep 2022 02:35:23 +0000 (UTC) X-FDA: 79887351726.05.A18DBE8 Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com [209.85.210.175]) by imf27.hostedemail.com (Postfix) with ESMTP id DD031400C3 for ; Thu, 8 Sep 2022 02:35:22 +0000 (UTC) Received: by mail-pf1-f175.google.com with SMTP id 145so16513810pfw.4 for ; Wed, 07 Sep 2022 19:35:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=Ky2nnvwk5aMRpug1OiXdRVfX6OZ/Blwf8y/RgQf3zCU=; b=IfqRKpQJZLtUUw3FK0nalBJ+FjJYspG6C1fY/6m//4cf4HJJhIsIsPGoRoTTNsCnQS 7nDJRuNF1imN5jNzf1YM9DNRaGaBVS8u6DC8VjpdD21adZbQ2kRVjn0a8VcZc1183KRg 2rXc26R4gdOX0PTflk+HqGryZp4BUoLR5cBn30bUaqne7zTicctxBSgJs9JtzcnYXyZL eRBGv7Lp6b5LRD1WAHxDRG+vdsi5AHQ5lB6HeYq6qn4StAAY1Di5cQn9AePJ9KKqSKPs z6NWDM0fVXaufe1qxDay/6XZqvQJgXE6wAeA8OLyScix0+vjawVxHPhgPncsveXFTinG czFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=Ky2nnvwk5aMRpug1OiXdRVfX6OZ/Blwf8y/RgQf3zCU=; b=0fmttUZvREbZZksmdxyUlEMCkyj/TRFJgMEoaeepysQ8D1oK6JI0R6/SPHCMbyDjdE 9dgxnNQuHSKWi6vFua5cUv3OsVccqxfxbY/gwIH5O7YPphX30I/wb3dbtAvF84958wI3 FM3G3yZUg0K7Jpln97OKxBrBDq2auugV7HFlk2HisLzagTKy96Ng7h+E5z0fIooceqKl K9hRovJcgQTYBz5aIhhjgqexLald7oec9Q8PtOmGDNdpn4wOgjkdZfnKULYIVNm4M/UE L+9goQ9od6lTD5nGzFp5zsAbTa9d/aXjfnZfSVXM3P9F5VlEyqWbBA7O+JGymAy0Cg7t HLTA== X-Gm-Message-State: ACgBeo1O71IuG1kYfMpNXYRVligvGRgY+n4guSsLPJeoJNIkALHy3aN4 euU5HugAvUvAUggmJ7prYjG8i7+agO35SQsQshcELQ== X-Google-Smtp-Source: AA6agR5EJ0ZEbrVZkpUuRie3AJaKAJdYbfgDtopgpj+sqF8J4AGNCc7ajxsAMVxIBf+qfSs0s80TkD+CAq7HDXDati8= X-Received: by 2002:a05:6a00:2385:b0:53a:cad4:79de with SMTP id f5-20020a056a00238500b0053acad479demr6913798pfc.8.1662604521620; Wed, 07 Sep 2022 19:35:21 -0700 (PDT) MIME-Version: 1.0 References: <20220907043537.3457014-1-shakeelb@google.com> <20220907043537.3457014-4-shakeelb@google.com> In-Reply-To: <20220907043537.3457014-4-shakeelb@google.com> From: Shakeel Butt Date: Wed, 7 Sep 2022 19:35:10 -0700 Message-ID: Subject: Re: [PATCH 3/3] memcg: reduce size of memcg vmstats structures To: Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song Cc: Andrew Morton , Cgroups , Linux MM , LKML Content-Type: text/plain; charset="UTF-8" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1662604522; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Ky2nnvwk5aMRpug1OiXdRVfX6OZ/Blwf8y/RgQf3zCU=; b=ZWR/voQjd26Izg3cMP6bU69kkbeTeeHRa1mLZ+Ve5lzdds/8cqAAoW0sEUUMDTXlVipMV3 0Ok8EgJDwjfuaiwZxf0M+o1avNurX/yZrP1/lT3L2+tqh2EKwg1B9Rq7c86JZrVjeej4N3 BLdEX7cg0aZEEuXaDGlJolWc9y0N+to= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=IfqRKpQJ; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf27.hostedemail.com: domain of shakeelb@google.com designates 209.85.210.175 as permitted sender) smtp.mailfrom=shakeelb@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1662604522; a=rsa-sha256; cv=none; b=OvWexY3VcncGIHm6c1tFXbAONDpaocuz7SwnViRR7yzzWF/3lu5BmTgy1muY86Wlz/v/BQ Ntxbh8pd5QUvmZ+vHmNx1qLN5SPC+OeHaK/qqi+J1iqoz5JYJgmqZkGIH1Eyq3sT8NLZSZ gTK3dB4kmwVBmbOHcf9nbliy0gcWr44= X-Stat-Signature: qknb8szny7twebefcqrgkbn8dtmag4xz X-Rspamd-Queue-Id: DD031400C3 Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=IfqRKpQJ; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf27.hostedemail.com: domain of shakeelb@google.com designates 209.85.210.175 as permitted sender) smtp.mailfrom=shakeelb@google.com X-Rspam-User: X-Rspamd-Server: rspam02 X-HE-Tag: 1662604522-405052 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Sep 6, 2022 at 9:36 PM Shakeel Butt wrote: > [...] > > static unsigned long memcg_events_local(struct mem_cgroup *memcg, int event) > { > long x = 0; > int cpu; > + int index = memcg_events_index(event); > + > + if (index < 0) > + return 0; > > for_each_possible_cpu(cpu) > x += per_cpu(memcg->vmstats_percpu->events[event], cpu); Andrew, can you please replace 'event' in the above line with 'index'? I had this correct in the original single patch but messed up while breaking up that patch into three patches for easier review.