From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F39BC2B9F4 for ; Tue, 22 Jun 2021 18:23:27 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B183561076 for ; Tue, 22 Jun 2021 18:23:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B183561076 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 9E15D6B005D; Tue, 22 Jun 2021 14:23:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 992AF6B006C; Tue, 22 Jun 2021 14:23:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7E5786B006E; Tue, 22 Jun 2021 14:23:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0117.hostedemail.com [216.40.44.117]) by kanga.kvack.org (Postfix) with ESMTP id 4B3B96B005D for ; Tue, 22 Jun 2021 14:23:25 -0400 (EDT) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 7F0ED180A6B4F for ; Tue, 22 Jun 2021 18:23:25 +0000 (UTC) X-FDA: 78282182370.22.67C660E Received: from mail-lf1-f50.google.com (mail-lf1-f50.google.com [209.85.167.50]) by imf05.hostedemail.com (Postfix) with ESMTP id 39BF9E0004F7 for ; Tue, 22 Jun 2021 18:23:25 +0000 (UTC) Received: by mail-lf1-f50.google.com with SMTP id r5so37533163lfr.5 for ; Tue, 22 Jun 2021 11:23:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=FV61UP5NcLLWWDvVqg5arfYv7gGM3LSFINIkuHzruNQ=; b=pONLFwGx3+EykTnB4ze62pOkv+Jpo7Ut9deKl05K8YRybGrbGTHE9TcZrjOqYHA28Y F7juG7LTnIcPuAGg8REQ+Iji7/5RqEAg7qrLnLuSBbfT2GkPwsfo//Ial3EVdkYFzmxk CKybBao4DyUQrD4zyl1LJix8iEHCiuTdudedyCJj8fJLBqDZlxJLQWMgOWG6HOoOvKL/ ghDU6yPvt3hY0VAenfRzHeMii2YCtRH9J7Q1REnR9dErOy4R3iGLRKF98tdiMwVov9Ox gMKEdHNZ/5q9PjN9ckMqJABLMlGWz/DY5Kz8rSmRZ/EUazFMXEsN2dlAUziGJewcQaWU dnJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=FV61UP5NcLLWWDvVqg5arfYv7gGM3LSFINIkuHzruNQ=; b=lN9ruHGoKlhbIyLK1CxO/Mh7Ivy8hQ7LEK7SHthS938YQGaXau21B1CGjgYmzLR8vk ffKvNcq9Dv1Y8Jl05Nwe84vYpXKIa17kjOebjqeeuz6wPi3m9J7f7g667Aivvs9gi9IM y/N3ysGSU9bzVUfn859PVXSqU4HEaLP81vR5K8yOqc0xVKvCO0Nzibmjj8/ESULMm6bs yRFwAToiXYld5vs3F/vmchOReyHfKufg9QNaJhqkFAqo+/mhgk/AVWOVquQcCm+Yb+l/ 9E9ZQxhM9HNkN8xkAqWmX8Ndj/umgt71nDLfWDv56/XjOZlx+Mr/yrpb5RIC3/O4bCI/ b8GQ== X-Gm-Message-State: AOAM532eDodgdlf6nF9F3ejSUgObsmjfQIwrS/AKiHIIDWrDRmcFHgPI tE+djCA507PVNnCJj06cN6OZI182wWugsEQmrgkVWw== X-Google-Smtp-Source: ABdhPJwnrjT3krbKSxFrRsFi3ZXwowgc1qJaQEQ1sCLbnNdI8yM24TC4myf8Qi5w66rYqP+zehgwQks6GADvBFg0XWA= X-Received: by 2002:a19:ac06:: with SMTP id g6mr3959111lfc.299.1624386203402; Tue, 22 Jun 2021 11:23:23 -0700 (PDT) MIME-Version: 1.0 References: <20210621083108.17589-1-sj38.park@gmail.com> <20210621083108.17589-9-sj38.park@gmail.com> In-Reply-To: <20210621083108.17589-9-sj38.park@gmail.com> From: Shakeel Butt Date: Tue, 22 Jun 2021 11:23:12 -0700 Message-ID: Subject: Re: [PATCH v31 08/13] mm/damon/dbgfs: Export kdamond pid to the user space To: SeongJae Park Cc: Andrew Morton , SeongJae Park , Jonathan.Cameron@huawei.com, acme@kernel.org, alexander.shishkin@linux.intel.com, amit@kernel.org, benh@kernel.crashing.org, Brendan Higgins , Jonathan Corbet , David Hildenbrand , dwmw@amazon.com, Marco Elver , "Du, Fan" , foersleo@amazon.de, greg@kroah.com, Greg Thelen , guoju.fgj@alibaba-inc.com, jgowans@amazon.com, Mel Gorman , mheyne@amazon.de, Minchan Kim , Ingo Molnar , namhyung@kernel.org, "Peter Zijlstra (Intel)" , Rik van Riel , David Rientjes , Steven Rostedt , Mike Rapoport , Shuah Khan , sieberf@amazon.com, snu@zelle79.org, Vlastimil Babka , Vladimir Davydov , zgf574564920@gmail.com, linux-damon@amazon.com, Linux MM , linux-doc@vger.kernel.org, LKML Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=google.com header.s=20161025 header.b=pONLFwGx; spf=pass (imf05.hostedemail.com: domain of shakeelb@google.com designates 209.85.167.50 as permitted sender) smtp.mailfrom=shakeelb@google.com; dmarc=pass (policy=reject) header.from=google.com X-Stat-Signature: gdtip88rmat1shjicbsba56rn845ydcd X-Rspamd-Queue-Id: 39BF9E0004F7 X-Rspamd-Server: rspam06 X-HE-Tag: 1624386205-856013 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jun 21, 2021 at 1:31 AM SeongJae Park wrote: > > From: SeongJae Park > > For CPU usage accounting, knowing pid of the monitoring thread could be > helpful. For example, users could use cpuaccount cgroups with the pid. > > This commit therefore exports the pid of currently running monitoring > thread to the user space via 'kdamond_pid' file in the debugfs > directory. > > Signed-off-by: SeongJae Park > Reviewed-by: Fernand Sieber > --- [...] > > +static const struct file_operations kdamond_pid_fops = { > + .owner = THIS_MODULE, I don't think you need to set the owner (and for other fops) as these files are built into modules. Otherwise it looks good.