From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7DACBC43334 for ; Tue, 7 Jun 2022 05:58:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 84B0F6B0073; Tue, 7 Jun 2022 01:58:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7F9B36B0078; Tue, 7 Jun 2022 01:58:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6E8DA6B007B; Tue, 7 Jun 2022 01:58:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 5FF176B0073 for ; Tue, 7 Jun 2022 01:58:58 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay13.hostedemail.com (Postfix) with ESMTP id 3C81E60A06 for ; Tue, 7 Jun 2022 05:58:58 +0000 (UTC) X-FDA: 79550386356.10.15FAD1B Received: from mail-pg1-f178.google.com (mail-pg1-f178.google.com [209.85.215.178]) by imf15.hostedemail.com (Postfix) with ESMTP id 780CEA0005 for ; Tue, 7 Jun 2022 05:58:31 +0000 (UTC) Received: by mail-pg1-f178.google.com with SMTP id d129so14864856pgc.9 for ; Mon, 06 Jun 2022 22:58:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=vhyeByqESMejGx5K1JZDwSGtodZB7YcNJdkA/XZ0nhs=; b=kJEPNwOx4uW/m0EmGEFbJCpF8utS8wjUtlPoQt/S+v3DQr6KNVz4SgD0N03AKsEJcX SO2IryPIeU/NYudxkDqQlve5MgWVNEd/UXTv4cQqyk1Xzg3ZqII+PMM+EuXOg1NIjJ4V jN7s5HxeykfvrWLOjcbQLVgsfbgmfTztwpMbAhaLNSeYFu4K1h3uX8J4o9hWA8ieYllK xdufyQ5KNBtOtIG80GB/m9OHwp8pxjZMmYG+HQsZiZNpZO5SvgjTSYceofuW/EpV1qLZ d8zB/sQ5OLtm52akYLt52jq1fouG4Dac89ykzUVvMKJVmu9w6rMtBvbq8X3+G+NZYOLg Jf+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=vhyeByqESMejGx5K1JZDwSGtodZB7YcNJdkA/XZ0nhs=; b=sBIqH6RxgB8y1pWU5zndCkGBubV8qh3wM25Bsr5HijSo7kPjAYCf6SLzGm8l9BirAI U51glalTruhNKqywoUsorStAsxfmftvXBhTW3aoAH+IXgM4EI+lvbNvohkIvwAR37TpZ czvNpgp2Zl5+3JdLrsWxXDZ7PxJm7pobb+Ciceul9McLqzxa/TgwwjZZYAKr1c+t8sh0 BQIz0R3oiYuWaKzBqP2QDhiz5g7FGa4nI8ubs96cIpnD2MBo4afbLxGfiuEAb9HJ45x3 R574Fhg+N6ti0efZSIGjuGpx/Shd1IRt2FoRkLsLI0KWzLq14SF0GFkxZVK/2I6K6Nuy ovDg== X-Gm-Message-State: AOAM532XH+oLPTvmjDnQJOdN094Q6ZV82yNGy7n6tNojK2ERpNMijmG8 bG2pgkUWh77ao+fWDCVdgckv1unLADVTL9aUXTZWLQ== X-Google-Smtp-Source: ABdhPJwXxF6peQ10a5eWuUpr6DpQPJGXHi4ZWloktkYqxy/TE7XHk0xrvMNVQW9Hi1HjZEWtcQAiGQ5Ygiw5VDdAR10= X-Received: by 2002:a63:4c09:0:b0:3fc:a85f:8c07 with SMTP id z9-20020a634c09000000b003fca85f8c07mr24071397pga.509.1654581536373; Mon, 06 Jun 2022 22:58:56 -0700 (PDT) MIME-Version: 1.0 References: <6b362c6e-9c80-4344-9430-b831f9871a3c@openvz.org> <360a2672-65a7-4ad4-c8b8-cc4c1f0c02cd@openvz.org> In-Reply-To: <360a2672-65a7-4ad4-c8b8-cc4c1f0c02cd@openvz.org> From: Shakeel Butt Date: Mon, 6 Jun 2022 22:58:45 -0700 Message-ID: Subject: Re: [PATCH memcg v6] net: set proper memcg for net_init hooks allocations To: Vasily Averin Cc: Qian Cai , Roman Gushchin , Andrew Morton , kernel@openvz.org, LKML , Linux MM , =?UTF-8?Q?Michal_Koutn=C3=BD?= , Vlastimil Babka , Michal Hocko , Florian Westphal , "David S. Miller" , Jakub Kicinski , Paolo Abeni , Eric Dumazet , Cgroups Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 780CEA0005 X-Stat-Signature: 5hmrk9fn3rou3t9w64ayfutu7arzxwr9 X-Rspam-User: Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=kJEPNwOx; spf=pass (imf15.hostedemail.com: domain of shakeelb@google.com designates 209.85.215.178 as permitted sender) smtp.mailfrom=shakeelb@google.com; dmarc=pass (policy=reject) header.from=google.com X-Rspamd-Server: rspam08 X-HE-Tag: 1654581511-322234 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jun 6, 2022 at 11:45 AM Vasily Averin wrote: > [...] > > As far as I understand this report means that 'init_net' have incorrect > virtual address on arm64. So, the two call stacks tell the addresses belong to the kernel modules (nfnetlink and nf_tables) whose underlying memory is allocated through vmalloc and virt_to_page() does not work on vmalloc() addresses. > > Roman, Shakeel, I need your help > > Should we perhaps verify kaddr via virt_addr_valid() before using virt_to_page() > If so, where it should be checked? I think virt_addr_valid() check in mem_cgroup_from_obj() should work but I think it is expensive on the arm64 platform. The cheaper and a bit hacky way to avoid such addresses is to directly use is_vmalloc_addr() directly.