From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.6 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33A1FC433E1 for ; Wed, 22 Jul 2020 16:28:26 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E58EE2065F for ; Wed, 22 Jul 2020 16:28:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="ra98AzIY" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E58EE2065F Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 84A796B0003; Wed, 22 Jul 2020 12:28:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7D47A6B0005; Wed, 22 Jul 2020 12:28:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 69D756B0006; Wed, 22 Jul 2020 12:28:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0209.hostedemail.com [216.40.44.209]) by kanga.kvack.org (Postfix) with ESMTP id 54C686B0003 for ; Wed, 22 Jul 2020 12:28:25 -0400 (EDT) Received: from smtpin05.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 038FC183CF884 for ; Wed, 22 Jul 2020 16:28:25 +0000 (UTC) X-FDA: 77066244570.05.judge04_59145c926f37 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin05.hostedemail.com (Postfix) with ESMTP id 1EC1A1853B97B for ; Wed, 22 Jul 2020 16:26:58 +0000 (UTC) X-HE-Tag: judge04_59145c926f37 X-Filterd-Recvd-Size: 4507 Received: from mail-il1-f194.google.com (mail-il1-f194.google.com [209.85.166.194]) by imf38.hostedemail.com (Postfix) with ESMTP for ; Wed, 22 Jul 2020 16:26:57 +0000 (UTC) Received: by mail-il1-f194.google.com with SMTP id t27so1804595ill.9 for ; Wed, 22 Jul 2020 09:26:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=2kHXQvVGBuGkaVHirVH2ldXpqiigd2kMJlKCki7PqMg=; b=ra98AzIYvVtLIKFmQ0582LpmVzZLDFtXPiDLxSIB7SoDAYKfzHUmecVZxZuP/M6Pvb fDufO1C+Q4FiAbYniw6ePsXq6IniiF94IvlcqmWtmSWtqcN5EqOCbg+nsxHw7v2/BzpD yqdQ4eKGDs88B1pTQ+/lVZ3atNYajhFCrKFlxc6iGCv2w9U5QibkcB5fjdiaYFspwg/7 DUAeDu27aJnyG2kaxKFRHFuV9pRJvCocGy9/pSs9I4O2w31H+artkiu+wABWqj20BtFU 4mfkDrAHear+tV6pm6mm5Q1TEtNXZAq/Blh918qa8SfTMXEI9nUlQIkjpdOHfrsto+Ju hfqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2kHXQvVGBuGkaVHirVH2ldXpqiigd2kMJlKCki7PqMg=; b=D9UQ//0bbITgQsKo2rdEL2B9qW0fsoZ4H5bA43ZT5OIuOuKNVFYRFkKW1BtQgTK1eI BRrd3VWrt4ndOg7yzrHKe58tO5V0ntxSweOIfEegDe1rcmHwvzGfNKujpSsy5aQX4t0g 6vM9WeDo6KemfPBgeYQAk4fSLC0Mo2/aFpfKp/rOJHDFx5DOgeGsuFOBYRpOWcovh86g 4EpB/nzmuD65xSbQ5qahqNz+fpN7lqzwIcGrZTnkSdgymT0u0qWDDDYdVW3iok8EMuI9 qP7t5ydza8hzhHu3eW8NSgdy/DzrZItGkXdYEq+MXu/VNuR6lizPLlUq5IUUWVdM0Gwf xjzg== X-Gm-Message-State: AOAM532lngnlDhOtYfOuzJEwdKcFYXl58eeK/FysNKQnMAoaoSGkfWi5 ZsYjKcYcMspmwQnMKUX5nwUwf0sF6Xt7ufbMOuLj5g== X-Google-Smtp-Source: ABdhPJzNeJo6F0VTZ0S6U9fuGWdBKZjH6dGksbNLyWqgmXOtrkpA/UinCG7oju3HCUHK5DY6DzL72Fr4547fWGtbqgk= X-Received: by 2002:a05:6e02:1253:: with SMTP id j19mr673988ilq.145.1595435216934; Wed, 22 Jul 2020 09:26:56 -0700 (PDT) MIME-Version: 1.0 References: <20200722062552.212200-1-hch@lst.de> <20200722062552.212200-12-hch@lst.de> In-Reply-To: <20200722062552.212200-12-hch@lst.de> From: Shakeel Butt Date: Wed, 22 Jul 2020 09:26:45 -0700 Message-ID: Subject: Re: [PATCH 11/14] mm: use SWP_SYNCHRONOUS_IO more intelligently To: Christoph Hellwig Cc: Jens Axboe , Song Liu , Hans de Goede , Richard Weinberger , Minchan Kim , linux-mtd@lists.infradead.org, dm-devel@redhat.com, "open list:BLOCK LAYER" , LKML , drbd-dev@lists.linbit.com, linux-raid@vger.kernel.org, linux-fsdevel , Linux MM , Cgroups Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 1EC1A1853B97B X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam02 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jul 21, 2020 at 11:27 PM Christoph Hellwig wrote: > > There is no point in trying to call bdev_read_page if SWP_SYNCHRONOUS_IO > is not set, as the device won't support it. > > Signed-off-by: Christoph Hellwig > --- > mm/page_io.c | 18 ++++++++++-------- > 1 file changed, 10 insertions(+), 8 deletions(-) > > diff --git a/mm/page_io.c b/mm/page_io.c > index ccda7679008851..442061348dfb26 100644 > --- a/mm/page_io.c > +++ b/mm/page_io.c > @@ -403,15 +403,17 @@ int swap_readpage(struct page *page, bool synchronous) > goto out; > } > > - ret = bdev_read_page(sis->bdev, swap_page_sector(page), page); > - if (!ret) { > - if (trylock_page(page)) { > - swap_slot_free_notify(page); > - unlock_page(page); > - } > + if (sis->flags & SWP_SYNCHRONOUS_IO) { > + ret = bdev_read_page(sis->bdev, swap_page_sector(page), page); > + if (ret) { !ret > + if (trylock_page(page)) { > + swap_slot_free_notify(page); > + unlock_page(page); > + } > > - count_vm_event(PSWPIN); > - goto out; > + count_vm_event(PSWPIN); > + goto out; > + } > } > > ret = 0; > -- > 2.27.0 >