From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B1CCC433DF for ; Thu, 27 Aug 2020 21:10:41 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id CFA2A20848 for ; Thu, 27 Aug 2020 21:10:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="KzpCwIOJ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CFA2A20848 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 799736B0003; Thu, 27 Aug 2020 17:10:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 748C66B0006; Thu, 27 Aug 2020 17:10:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 686F96B0007; Thu, 27 Aug 2020 17:10:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0122.hostedemail.com [216.40.44.122]) by kanga.kvack.org (Postfix) with ESMTP id 55A556B0003 for ; Thu, 27 Aug 2020 17:10:40 -0400 (EDT) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 1316B824556B for ; Thu, 27 Aug 2020 21:10:40 +0000 (UTC) X-FDA: 77197592640.24.crook80_460b14427070 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin24.hostedemail.com (Postfix) with ESMTP id D41891A4A0 for ; Thu, 27 Aug 2020 21:10:39 +0000 (UTC) X-HE-Tag: crook80_460b14427070 X-Filterd-Recvd-Size: 3133 Received: from mail-lj1-f196.google.com (mail-lj1-f196.google.com [209.85.208.196]) by imf28.hostedemail.com (Postfix) with ESMTP for ; Thu, 27 Aug 2020 21:10:39 +0000 (UTC) Received: by mail-lj1-f196.google.com with SMTP id t23so8045222ljc.3 for ; Thu, 27 Aug 2020 14:10:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=IOB+ukv6Oi1rVoS9Jtq8hZfPPBX7UWWuimpCi5zIu4o=; b=KzpCwIOJ6XKv5A25ZlO6WjaxJ/4Q9tXt6334e1pXNuFjWzSEWv3subAtw6xJVC06Dc q8Kri7wQmYszddw4J1hy+EdCfgMWyRnr4Xe6Fb5M0Zvo+XZFvlqeVlueWeDLog1PlmgO wpHFX8ZibP3flcnv6/kK+9bI70I4k7kmpWns/DxDmVFrbWzh2/Z6uoq1Yz1VBp3gOk0/ pjvzsebyGc5mrRU7wqZL11g+03X6cSIryrr6W7+5B92EhkT2TdYK6FF0v9EqyIvJKBjB 9ypjEpp6Zpit2H6Q2nrc72Rkc/cUi5LwfiEyfbk73A4Z4+yqNTty6kHAAjBGHHZSlfRm FHuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=IOB+ukv6Oi1rVoS9Jtq8hZfPPBX7UWWuimpCi5zIu4o=; b=YSKujb4ZxJGo3aX6VOMTyVhsAtDfj9TdpXZv/YMe+Y2kBD9wRjZ6+UWiRrHYcGwBCW gqnV3qsxdPAR/4ILnlpyrloKd8ULyq7A2p5vewVAOwjHBubvnPfskM0CBAmfqQzCbn3h Ph8OS8YGxFIsvBebaYW5Oa96OlrirmH2JNOACjaXzeyE3CTVazXk7mriNukx9gmfxxPg lqf70PzdasaRBdJP5Q2koBKgiRp70y2mZQD/sJOp/SeTKCnSXROHSUOLLGchX9dFlHz5 T7WgmuWQf5qmA1hR8BbSZ8tuwWFbkuHa/vFTGvUJ1zO+l607MgG4goYOizxSH46PIlqI qqyQ== X-Gm-Message-State: AOAM532X1WE5aivkygqf9LErAj7UMTOEkukA8rsdsijuJnLZIO2S1pmy EPW94mnhvtbtUZtk/18OkBIvNHmWotjDX59yFg5Fxg== X-Google-Smtp-Source: ABdhPJyYYRMOID6xGYuzKse/5r8uqHanIEVrURITjHf94MPFmVFZ2us1By7rqfQ+rRKCOi1Ikg1dO8/hQ5O/ytuVXm4= X-Received: by 2002:a2e:9396:: with SMTP id g22mr11519846ljh.446.1598562637711; Thu, 27 Aug 2020 14:10:37 -0700 (PDT) MIME-Version: 1.0 References: <20200827175215.319780-1-guro@fb.com> <20200827175215.319780-3-guro@fb.com> In-Reply-To: <20200827175215.319780-3-guro@fb.com> From: Shakeel Butt Date: Thu, 27 Aug 2020 14:10:26 -0700 Message-ID: Subject: Re: [PATCH RFC 2/4] mm: kmem: remove redundant checks from get_obj_cgroup_from_current() To: Roman Gushchin Cc: Linux MM , Andrew Morton , Johannes Weiner , Michal Hocko , Kernel Team , LKML Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: D41891A4A0 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam02 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000921, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Aug 27, 2020 at 10:52 AM Roman Gushchin wrote: > > There are checks for current->mm and current->active_memcg > in get_obj_cgroup_from_current(), but these checks are redundant: > memcg_kmem_bypass() called just above performs same checks. > > Signed-off-by: Roman Gushchin Reviewed-by: Shakeel Butt