From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3136C433F5 for ; Mon, 16 May 2022 19:10:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 67C9B6B0071; Mon, 16 May 2022 15:10:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 62BD16B0072; Mon, 16 May 2022 15:10:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4CC7A6B0074; Mon, 16 May 2022 15:10:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 3CBF16B0071 for ; Mon, 16 May 2022 15:10:32 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 098B3607F4 for ; Mon, 16 May 2022 19:10:32 +0000 (UTC) X-FDA: 79472547504.14.51B3716 Received: from mail-pg1-f174.google.com (mail-pg1-f174.google.com [209.85.215.174]) by imf07.hostedemail.com (Postfix) with ESMTP id C21004004A for ; Mon, 16 May 2022 19:10:23 +0000 (UTC) Received: by mail-pg1-f174.google.com with SMTP id v10so14932313pgl.11 for ; Mon, 16 May 2022 12:10:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=k7syZc7e4IW6qXe22/aRGymPtljsSZmZ6kuls0rngww=; b=pryikHjo//4oXh00NHAFRzEFc8xVE45r9L6sXoKJBVHQDNhL/LQklaC57uEu/17Q+b dRvVFL9MqpXJp4B/km6LzslI9DUvI/G5fKF9unFpjw6x7+zroRzCQDD7oArwEpyCvtwJ /M2XguzXXebiijMs7MLC1aRqG0m2tEguDg+/8rZZv+JY4A1mzaCokkL+pVa4DWGHQdI+ h5TyB39mAc5LVUYaKfPdMJnn1DBBlkJoTmK71AqBh94dysQqgUiiep3hy2A1jbJXDBAD tkPH4amzgGTO8xqy/15Z/MQDy1lrpMOLfkfel27CzGH4NRYdEqm/nyFeSNCDT79nmcvo Ispg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=k7syZc7e4IW6qXe22/aRGymPtljsSZmZ6kuls0rngww=; b=qzZ/11D1CFKVNwMTRgnbeYzG6mLahN/5SvT/iUp6jVxNcSL4/q0tHRVEHJy5qL/LxS eHzDdiDNVhRWpzUfydyvDbKlcMR90ATdzwEeWZ/1PybBd5AggDpHuSfdyYuGqoVeggdI hOCYYYeiDPFcVS6vPcpaIp372JddjlaU69XJPSjU2w/Kh5nvSuuUM215RGShoBa0Q6fE 7/zU+Uz7W76g7wItkzoUR7ruZtDS70XBU/S54Jp0SmiaMeQBA3MEc3qAntzmYFvKP8kd eqdOxMwR/tWmKPSX8JdGC+67KBtvVcN+a8ik/qfM6e/U3oBT7wSMQqA8Kr/KjSo/r6qp 4KcQ== X-Gm-Message-State: AOAM531Mt4HeaqaALEONZgJWaK5bp85g4pWamHCCjgCCWMjp1SclqcbR o+IwXmoPxgHBzkwyzIa/9cIkZmXfdZ5jwlL/kAt0UQ== X-Google-Smtp-Source: ABdhPJxv79JhgA/Y27cIO4j/iP8xxQw8o9x2TXc7qHLtuGufyQqRW1cosxYGmLpfaoOdPJF4hTxN64c6uaicn0cpU1I= X-Received: by 2002:a65:6d06:0:b0:3c6:890:5609 with SMTP id bf6-20020a656d06000000b003c608905609mr16140622pgb.357.1652728230125; Mon, 16 May 2022 12:10:30 -0700 (PDT) MIME-Version: 1.0 References: <1fd21e25-b095-e055-fc2e-abda640a0575@openvz.org> In-Reply-To: <1fd21e25-b095-e055-fc2e-abda640a0575@openvz.org> From: Shakeel Butt Date: Mon, 16 May 2022 12:10:19 -0700 Message-ID: Subject: Re: [PATCH] tracing: add ACCOUNT flag for allocations from marked slab caches To: Vasily Averin Cc: Roman Gushchin , Vlastimil Babka , Andrew Morton , Joonsoo Kim , David Rientjes , Pekka Enberg , Christoph Lameter , kernel@openvz.org, Linux MM , LKML , Michal Hocko Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: C21004004A X-Stat-Signature: mwukaeo9d9f5uo61hc3rtrsrikcy3a1k X-Rspam-User: Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=pryikHjo; spf=pass (imf07.hostedemail.com: domain of shakeelb@google.com designates 209.85.215.174 as permitted sender) smtp.mailfrom=shakeelb@google.com; dmarc=pass (policy=reject) header.from=google.com X-HE-Tag: 1652728223-393215 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, May 16, 2022 at 11:53 AM Vasily Averin wrote: > > Slab caches marked with SLAB_ACCOUNT force accounting for every > allocation from this cache even if __GFP_ACCOUNT flag is not passed. > Unfortunately, at the moment this flag is not visible in ftrace output, > and this makes it difficult to analyze the accounted allocations. > > This patch adds the __GFP_ACCOUNT flag for allocations from slab caches > marked with SLAB_ACCOUNT to the ftrace output. > > Signed-off-by: Vasily Averin > --- > mm/slab.c | 3 +++ > mm/slub.c | 3 +++ > 2 files changed, 6 insertions(+) > > diff --git a/mm/slab.c b/mm/slab.c > index 0edb474edef1..4c3da8dfcbdb 100644 > --- a/mm/slab.c > +++ b/mm/slab.c > @@ -3492,6 +3492,9 @@ void *__kmem_cache_alloc_lru(struct kmem_cache *cachep, struct list_lru *lru, What about kmem_cache_alloc_node()? > { > void *ret = slab_alloc(cachep, lru, flags, cachep->object_size, _RET_IP_); > > + if (cachep->flags & SLAB_ACCOUNT) Should this 'if' be unlikely() or should we trace cachep->flags explicitly to avoid this branch altogether? > + flags |= __GFP_ACCOUNT; > + > trace_kmem_cache_alloc(_RET_IP_, ret, > cachep->object_size, cachep->size, flags); > > diff --git a/mm/slub.c b/mm/slub.c > index ed5c2c03a47a..670bbfef9e49 100644 > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -3231,6 +3231,9 @@ void *__kmem_cache_alloc_lru(struct kmem_cache *s, struct list_lru *lru, > { > void *ret = slab_alloc(s, lru, gfpflags, _RET_IP_, s->object_size); > > + if (s->flags & SLAB_ACCOUNT) > + gfpflags |= __GFP_ACCOUNT; > + > trace_kmem_cache_alloc(_RET_IP_, ret, s->object_size, > s->size, gfpflags); > > -- > 2.25.1 >