From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3B71C433EF for ; Sat, 7 May 2022 15:34:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CFBAC6B0071; Sat, 7 May 2022 11:33:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CABBA6B0073; Sat, 7 May 2022 11:33:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B727B6B0074; Sat, 7 May 2022 11:33:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id A36D76B0071 for ; Sat, 7 May 2022 11:33:59 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 772102EF01 for ; Sat, 7 May 2022 15:33:59 +0000 (UTC) X-FDA: 79439342598.19.54A8C2F Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) by imf02.hostedemail.com (Postfix) with ESMTP id C92D98002B for ; Sat, 7 May 2022 15:33:52 +0000 (UTC) Received: by mail-pl1-f171.google.com with SMTP id d17so10118559plg.0 for ; Sat, 07 May 2022 08:33:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=RKIrTDgFPzQoY+nQlkFGe6GXuT/mXqMIOBgKZEviWa0=; b=mM/QEyG8NRrxogssx348Xw9iuXFePPCxz8tD/ChHoVABmGa9Gd4j9lTAsRGn3NNyDx lLE+53P1YvhbEKq8ks3ha7QiBoEPsulerpQIV3rs6YO1z3IU5EJy4WpgJ+OUlq8bApJl nq4qk70mU++hxHK+ppYFPS7ICMK32ngwAwwbAks2652HVZ5+YaeEJb+3VCHR9xheSxMo Jw0DPaLDO3mh0mYxsPZYnKKAJoYtaKKZDlWysgfuwZKr5ZNhUb5w21H6hwZI0gC5y4Yr C7UkSnjzkcDMxeGNk+Hw3/sIVo+WCABP0JJpxOWIkbwwQrQZlnjf8fOGHROhVY7vQcis W/Lw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=RKIrTDgFPzQoY+nQlkFGe6GXuT/mXqMIOBgKZEviWa0=; b=fs5hhfgUkTqYXV7YzuDqwCiSVjJPPw3xIXK0bmSuLmHaSpOrAF0Ahf0ySxeFdvErep CrBufpWlVsKnYImpI6WorAaVGdRdff/s9B378dvVs0ZJ8HK2eOe95h4PgfrKZh1DQfNA A8hOpxZaRzrC4Z5H/isEX5KvVYxJN0LhwF9UTgqKo6+aC36RV/Ple9jIT86NjpWg0qGH 9IWvPv5bD4TTC136q5D9c+n/jr4Vy0aivoYf2ew0/NJ6H9ZjydSlOi59dX423pY8tFTS 03+dLO/y545GodoEMASO56+DREqn63iwo9izfIQXr6rc333E/TV85Q00QxAJKOymrrXH 96Vw== X-Gm-Message-State: AOAM530YzuDNf3rw9dmVsyfpt5jYueOz9LYP8TQ2JUMJ99EIcxWg0PT4 u/o/aNJkKNfakutqSp8s8NqeVjJshiXo9Fs6Ea5PDA== X-Google-Smtp-Source: ABdhPJxxarzdy4Wel7BXTduqXnRisdrUKriSUkL4BzvSAdCRoZXiZpI+1xGZMcwAdXXQp2RJkh7R/QEf4nvYu99soaE= X-Received: by 2002:a17:902:f682:b0:15e:951b:8091 with SMTP id l2-20020a170902f68200b0015e951b8091mr8598773plg.106.1651937637817; Sat, 07 May 2022 08:33:57 -0700 (PDT) MIME-Version: 1.0 References: <20220507050916.GA13577@us192.sjc.aristanetworks.com> In-Reply-To: <20220507050916.GA13577@us192.sjc.aristanetworks.com> From: Shakeel Butt Date: Sat, 7 May 2022 08:33:46 -0700 Message-ID: Subject: Re: [PATCH v2] mm/memcontrol: Export memcg->watermark via sysfs for v2 memcg To: Ganesan Rajagopal Cc: Johannes Weiner , Michal Hocko , Roman Gushchin , Cgroups , Linux MM Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: C92D98002B Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b="mM/QEyG8"; spf=pass (imf02.hostedemail.com: domain of shakeelb@google.com designates 209.85.214.171 as permitted sender) smtp.mailfrom=shakeelb@google.com; dmarc=pass (policy=reject) header.from=google.com X-Rspam-User: X-Stat-Signature: 8s44tntnm8efhpua19y578aeosenmqpk X-HE-Tag: 1651937632-785274 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000831, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, May 6, 2022 at 10:09 PM Ganesan Rajagopal wrote: > > We run a lot of automated tests when building our software and run into > OOM scenarios when the tests run unbounded. v1 memcg exports > memcg->watermark as "memory.max_usage_in_bytes" in sysfs. We use this > metric to heuristically limit the number of tests that can run in > parallel based on per test historical data. > > This metric is currently not exported for v2 memcg and there is no > other easy way of getting this information. getrusage() syscall returns > "ru_maxrss" which can be used as an approximation but that's the max > RSS of a single child process across all children instead of the > aggregated max for all child processes. The only work around is to > periodically poll "memory.current" but that's not practical for > short-lived one-off cgroups. > > Hence, expose memcg->watermark as "memory.peak" for v2 memcg. > > Signed-off-by: Ganesan Rajagopal Acked-by: Shakeel Butt