From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C8A5C7EE24 for ; Mon, 15 May 2023 19:50:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A2E67900004; Mon, 15 May 2023 15:50:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9DE04900002; Mon, 15 May 2023 15:50:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8CD69900004; Mon, 15 May 2023 15:50:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 7EC85900002 for ; Mon, 15 May 2023 15:50:45 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 437481210C9 for ; Mon, 15 May 2023 19:50:45 +0000 (UTC) X-FDA: 80793532050.26.160E90F Received: from mail-qt1-f177.google.com (mail-qt1-f177.google.com [209.85.160.177]) by imf04.hostedemail.com (Postfix) with ESMTP id 5B9B140008 for ; Mon, 15 May 2023 19:50:43 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=zuGmhQqW; spf=pass (imf04.hostedemail.com: domain of shakeelb@google.com designates 209.85.160.177 as permitted sender) smtp.mailfrom=shakeelb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684180243; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=R9rBJ3Z6bMHq4Ea+F9E390Qio2yO4hD5BQLQUaMJTwA=; b=gsDfjuk04S8VbgqXR2ToUbhlEffdIMXFPsHj/MqeQQw3jtA7gL84H3HlWpO2jFLuN5N7kf talpdWWjTrvpUyUTVsCeKY45YJsyD9EKuC1G0mMajUH3MkzBzTcHta9luy82iVP/HGa7Jp aWzyHS3WNAxOXvVdj2X1dWVdb6L7eiQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684180243; a=rsa-sha256; cv=none; b=pnOEv3lYsYeOAVk9iFue4pRrrONCkOQ/7iEE2Lx4DBeTHEAoaxT7LkvEpV6cks/D9eCLl/ AH60iDjsWuDZaHn6f4OJtM2e/LSRazhFZ7+Ld8i+gH4RtNJX3PXe0olBOIugx9/yxNPzg5 f4tsQ4ZbbodxD9K6XuCXLDOyIf9WAbM= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=zuGmhQqW; spf=pass (imf04.hostedemail.com: domain of shakeelb@google.com designates 209.85.160.177 as permitted sender) smtp.mailfrom=shakeelb@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-qt1-f177.google.com with SMTP id d75a77b69052e-3f396606ab0so1583291cf.0 for ; Mon, 15 May 2023 12:50:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1684180242; x=1686772242; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=R9rBJ3Z6bMHq4Ea+F9E390Qio2yO4hD5BQLQUaMJTwA=; b=zuGmhQqWoc00Zv+gSniT0ih5yLMGbWSeEIuQWzHekcnhvcSP3KRGL9187CcmxOPax+ MtLWl4dMw6+fJkaOFeH/pb6g8aCL788Q5ZZGDWgqcMRScbxYfgV/MyGdvNzRfE8+31f1 nD2iSIsiwu4VYaNTTBv35fZqIEC2HvSxslyNnPR+trOvrP/gt6qnD8VQaqzf8VrVJmwg y0ds0jsLE2nvp5xBk9c9AGFPD1mhBoCLZEtzLWpFD8Q5hCJvGHjz1E9xXVphXw1eCiQQ rVpBywpzQX9RwqIMhWYO9rCR4/kJ///SolL7aMR4r8Xqev9LMV6pO/WIocrN3XFUtjjU aOWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684180242; x=1686772242; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=R9rBJ3Z6bMHq4Ea+F9E390Qio2yO4hD5BQLQUaMJTwA=; b=FTiwnRjAbDDkH16Fe0ys7L09bTfZ2Ypmp22w7kWsWLsQaSn9wV0psig1AC0XldMTha MdyjIGsXNArKOnNG0WSSbVqcNkczMcj8X6bWdufByVBMA5DYyRRzinr7gZnNh0OIxS/W Tjt0A4KcHKSpVBi7Dn2ZnBq+DnTDH78My9Zkn+7Oxc2P12RyqqFuy2OFrxwwcK4+Lltz JV1Egl6F3Pl0fPekOKgWh0acR/Qp4qQ/HNgLqH/jFIQVKbHwskd2WcPXQ32Ch7BNh6LW +AxPMDgpIdigLVRQL89mifhLF2cuTwQDMnCqWAwgbtXAwl1/4XwMG3HbSatnAbhgL5Ll wcdw== X-Gm-Message-State: AC+VfDxgINBwGeg8tNqKYlbxMQ+/BJFVAOZ1AbMLL3MbTJu32a0SU6FM xQ/u5pPMe+1hwbPyKaOJ+JlkbuvnyE0ntcfrzNAUjg== X-Google-Smtp-Source: ACHHUZ7XVTjje4a4teCP0LdhFit4xaugXUIJ68JcFbfxEOfJ5reZF2OVJCCDEM9N2UqtbUc4EJnvx4PSN18tj2biYFo= X-Received: by 2002:a05:622a:178a:b0:3ef:31a5:13c with SMTP id s10-20020a05622a178a00b003ef31a5013cmr29129qtk.3.1684180242180; Mon, 15 May 2023 12:50:42 -0700 (PDT) MIME-Version: 1.0 References: <20230512171702.923725-1-shakeelb@google.com> In-Reply-To: From: Shakeel Butt Date: Mon, 15 May 2023 12:50:31 -0700 Message-ID: Subject: Re: [PATCH net-next 1/2] net: Keep sk->sk_forward_alloc as a proper size To: "Zhang, Cathy" , Yin Fengwei , kernel test robot , Feng Tang Cc: Eric Dumazet , Linux MM , Cgroups , Paolo Abeni , "davem@davemloft.net" , "kuba@kernel.org" , "Brandeburg, Jesse" , "Srinivas, Suresh" , "Chen, Tim C" , "You, Lizhen" , "eric.dumazet@gmail.com" , "netdev@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 5B9B140008 X-Stat-Signature: jn9pfe81jziezeffpr9obe3epqyzsyyf X-Rspam-User: X-Rspamd-Server: rspam09 X-HE-Tag: 1684180243-154684 X-HE-Meta: U2FsdGVkX1+pmx7yFh7PA5BGMTwU8jtCIQ84Pb0YXG4lpTeuuOskP3J8dRRZIiX3rPQvQAAvPMSCwJ9SY6EYf7FlYPo3m8IKU0rx4BhpLlpZ3hVYRQ1kWQcyhuga0P4WfuPHDtasW39DqouOvi5zxzXY6k7X2KeriyiVJkytjhbh9KOyhnLFe3TrRj5yYAf0Fc+D7KpDBAPgmK0sZbqmPevBjTf3QithFG2xWSZ6uJbJ0B+WH2X2yR1on4jBgWkZatqwXyD6HjVQNV/dAtlrCNfAYrX3QHIGrQ/YOPLR5PuJig71rt3W8AMOq+pobpnUfCwJoYBaxQcQ+JMcNADN4+aV/M/lO3Pp8tFjtBtJSLeK108UmKrIgLzR6Pd/oedz8Pgg+Gos6z37n36hlhU4ZR8B+B9zuNjACsCo/Buuf/GryIzxS0CSD+QiqR0MtrRjIM9ZjC7uXyNUyN97pjQc4h1uQXfH3DVjeNv/ibK8FdQqpJbXF6Fg37XMleb8V2km4mi/+NP8MIEmfviffOUf4XMvA+qhyETfOmWBH/cSFXd+uLUGe4nlwK/oTs20D2OR5KM3r9hW5etIzWTI1jaonKSrFQvYk3HE6wiRm9cdU4rFD3s36BZ1GdYfMLBKS/+xxJI0g3jE6jZerA7LBft4NsueEn5AD7fnFknaO5FwSCW49eV94f5t9gON9qKOWCIOWj0kCY0micq30H2gi2GMEydYTmMcvcW75EQWCY8G+h/eqdm0LUjQHIEGxATOsNLXE5hNxfGLlslEhf9DZsyI0eg1/mS7AtiQHvOeSNgGJMjAi4knn2nM/zqq8VyvnwmLeKt+qZBZGVXutASGSrE6pKvqc0D6cVPV6749IdpamQRoeRCWnHp3mzAAKdUeNKyeWkEzl63FTjR/bnkCN89QrO5h31FV9YjjmYut7YKRsOjtof875sVnCkw2Rf74C3O6gaB61zYjqQ801a8jpID W50XXtS8 7zDBqRm8AsYymeOlf+d2HPGuCEIUGFQwmSnC7MjsRa4nnkxZSv8dvx3GQTkbYth2b6F00LthowyVS1rc1kbYYZpDHk4PyHW4l1aEVy3kKOjG3OaAgMsocm/l3SXZI0/AVHV7k0zcX/hVERfvrISuPF1p7Yx4/6d1OxEByn4ETO3RgelJuwGq0eHQUR2rcIw5kRsBVlpRA1VTYLT4abxEMNP3QEWA06I74qAKFrqKKGm+XwuzFbExY0DRZar8Og0KX2V0H2KHCaDvAqfOQqxvt6sbztupFvCrCEhX4UAeMFjAQ/wRyZrEps8vUREbZHTXwPx06l/OhZg8Z3AQElBE/LhENVFXV5pw5HaDEG1l5iuRCYafYI3qWyMOclAKVwHvFK+ba0mrOmF/7JSakm5eKT1cpQq3FjCX8t7kKDkGS+CLccOtHxLego13ME6bs0xNrFJxxQxHkp5AgfWEfGKtv4Jqw52qTtbX1i1bAtx14e7XkgoBkuvVNmn9k4W662AbEskxxRVnWWMuyBVhhjxDINE05m25jKSp0T6nTKmQmCrT4gOypbBvGSMPlpbY2/Q6o521H00zgsrzJq44RTMewi7UkqMQLb+p2XBvOd/d43gvM+d79Y8K1c2UF15pzVOfLf6gjaJtaKY5TuYF0iTyP77f+4A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: +Feng, Yin and Oliver On Sun, May 14, 2023 at 11:27=E2=80=AFPM Zhang, Cathy wrote: > > > > > -----Original Message----- > > From: Shakeel Butt > > Sent: Monday, May 15, 2023 12:13 PM > > To: Zhang, Cathy > > Cc: Eric Dumazet ; Linux MM > mm@kvack.org>; Cgroups ; Paolo Abeni > > ; davem@davemloft.net; kuba@kernel.org; > > Brandeburg, Jesse ; Srinivas, Suresh > > ; Chen, Tim C ; You, > > Lizhen ; eric.dumazet@gmail.com; > > netdev@vger.kernel.org > > Subject: Re: [PATCH net-next 1/2] net: Keep sk->sk_forward_alloc as a p= roper > > size > > > > On Sun, May 14, 2023 at 8:46=E2=80=AFPM Zhang, Cathy > > wrote: > > > > > > > > > > > > > -----Original Message----- > > > > From: Shakeel Butt > > > > Sent: Saturday, May 13, 2023 1:17 AM > > > > To: Zhang, Cathy > > > > Cc: Shakeel Butt ; Eric Dumazet > > > > ; Linux MM ; Cgroups > > > > ; Paolo Abeni ; > > > > davem@davemloft.net; kuba@kernel.org; Brandeburg@google.com; > > > > Brandeburg, Jesse ; Srinivas, Suresh > > > > ; Chen, Tim C ; > > > > You, Lizhen ; eric.dumazet@gmail.com; > > > > netdev@vger.kernel.org > > > > Subject: Re: [PATCH net-next 1/2] net: Keep sk->sk_forward_alloc as > > > > a proper size > > > > > > > > On Fri, May 12, 2023 at 05:51:40AM +0000, Zhang, Cathy wrote: > > > > > > > > > > > > > > [...] > > > > > > > > > > > > Thanks a lot. This tells us that one or both of following > > > > > > scenarios are > > > > > > happening: > > > > > > > > > > > > 1. In the softirq recv path, the kernel is processing packets > > > > > > from multiple memcgs. > > > > > > > > > > > > 2. The process running on the CPU belongs to memcg which is > > > > > > different from the memcgs whose packets are being received on t= hat > > CPU. > > > > > > > > > > Thanks for sharing the points, Shakeel! Is there any trace record= s > > > > > you want to collect? > > > > > > > > > > > > > Can you please try the following patch and see if there is any > > improvement? > > > > > > Hi Shakeel, > > > > > > Try the following patch, the data of 'perf top' from system wide > > > indicates that the overhead of page_counter_cancel is dropped from 15= .52% > > to 4.82%. > > > > > > Without patch: > > > 15.52% [kernel] [k] page_counter_cancel > > > 12.30% [kernel] [k] page_counter_try_charge > > > 11.97% [kernel] [k] try_charge_memcg > > > > > > With patch: > > > 10.63% [kernel] [k] page_counter_try_charge > > > 9.49% [kernel] [k] try_charge_memcg > > > 4.82% [kernel] [k] page_counter_cancel > > > > > > The patch is applied on the latest net-next/main: > > > befcc1fce564 ("sfc: fix use-after-free in > > > efx_tc_flower_record_encap_match()") > > > > > > > Thanks a lot Cathy for testing. Do you see any performance improvement = for > > the memcached benchmark with the patch? > > Yep, absolutely :- ) RPS (with/without patch) =3D +1.74 Thanks a lot Cathy. Feng/Yin/Oliver, can you please test the patch at [1] with other workloads used by the test robot? Basically I wanted to know if it has any positive or negative impact on other perf benchmarks. [1] https://lore.kernel.org/all/20230512171702.923725-1-shakeelb@google.com= / Thanks in advance.