From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C52FDC43334 for ; Sat, 4 Jun 2022 00:47:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3D89D8D0002; Fri, 3 Jun 2022 20:47:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 35F548D0001; Fri, 3 Jun 2022 20:47:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2255C8D0002; Fri, 3 Jun 2022 20:47:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 105358D0001 for ; Fri, 3 Jun 2022 20:47:27 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id D6E72212BF for ; Sat, 4 Jun 2022 00:47:26 +0000 (UTC) X-FDA: 79538714892.19.601CAE3 Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) by imf21.hostedemail.com (Postfix) with ESMTP id 593611C0011 for ; Sat, 4 Jun 2022 00:47:11 +0000 (UTC) Received: by mail-pf1-f180.google.com with SMTP id c196so8331826pfb.1 for ; Fri, 03 Jun 2022 17:47:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=jdDGlC0lns52Uw6ScJUD6BF1PLqziLviHb7d6w1wTpY=; b=a1Zr2vgNvc3YZOeZA/WXKlisS5gVf19VLX5J0A4ciKLN+8Pm1fQhX+nIecPcWwXdWp hAL9Odinf0A8wu0W9tTPISn9n0/y4NlhTgE1wKRLDFQSyxusv54Aq5Q8BB3vYydv4np6 fKbJgW9ijRf6W3+v2BDRE/KaP9xPKSNRb50bjwbLNUc1KmWevMv2H1orcSIGQ39I1mgc ntJK7CxT+W66XgRSN/HtGl5p+PaJrdL15mZJITgd5S2g6B4x3S315kxB6XzTV5cX+ozI LN2ZBtwrGzfwjvjk5l6d7jZawaIObnefzF147DnanowtkHUp3LkSWDM78JziRD0HvMKh yRRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=jdDGlC0lns52Uw6ScJUD6BF1PLqziLviHb7d6w1wTpY=; b=hkq4vqgqxTaHcZx8JrPKt7YI7WrUZcpjzcNv9nSOrLqMn/ufThoEAOagvVZZrRsJ11 CSIGfoPZf7bHRGt7AXS3z3mIUmeGZ5cpLp4hYQu8zrWGdwk/wsxMdRJ6QR5yAtLlskFM 3SDYevBGMa25XrkJ+aqGXn/bfgXj9YluuGCc2AAV2WpiRqqJgcbacqIKAENob4sxlvxy iPOHmvT+Za70EmEljkWj3c5aEm0lWY05TCR0rCsWbV2+j4IiesGAPOS/oVdCfH33Wg03 BBL+rH1EZYGfKNdQOPmkbw9kJXquUTgxN5SJKDUzbHy1JhSgNRiDTt1rKZrlFaxYvgY6 yArA== X-Gm-Message-State: AOAM5339qlzWNV00ocovXBHwmxJCTeXyHaRcZ2DPAy7l+EI52RkYoo+B AvU1JzLJaNIS/1N+YwBYEXN6X8/KBXwPe0vzl9CjfA== X-Google-Smtp-Source: ABdhPJxDRGhEU8WNQRV9k+Q2YB3N3a9jW6NdWqcj3PP7qytCALiKQ4FiP7Hhr752nEOx7LkZYmS7a6QJywBNM3tYDvo= X-Received: by 2002:a65:61a8:0:b0:3fa:95b8:66c4 with SMTP id i8-20020a6561a8000000b003fa95b866c4mr10961843pgv.166.1654303645308; Fri, 03 Jun 2022 17:47:25 -0700 (PDT) MIME-Version: 1.0 References: <20220603070423.10025-1-zhengqi.arch@bytedance.com> In-Reply-To: <20220603070423.10025-1-zhengqi.arch@bytedance.com> From: Shakeel Butt Date: Fri, 3 Jun 2022 17:47:14 -0700 Message-ID: Subject: Re: [PATCH] mm: memcontrol: separate {pgscan,pgsteal}_{kswapd,direct} items in memory.stat of cgroup v2 To: Qi Zheng Cc: Michal Hocko , Johannes Weiner , Roman Gushchin , Muchun Song , Andrew Morton , Jonathan Corbet , Linux MM , LKML , "open list:DOCUMENTATION" Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: 6gj4jucbndcrircxqsif814gh6am45eg X-Rspam-User: Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=a1Zr2vgN; spf=pass (imf21.hostedemail.com: domain of shakeelb@google.com designates 209.85.210.180 as permitted sender) smtp.mailfrom=shakeelb@google.com; dmarc=pass (policy=reject) header.from=google.com X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 593611C0011 X-HE-Tag: 1654303631-578068 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jun 3, 2022 at 12:06 AM Qi Zheng wrote: > [...] > > diff --git a/Documentation/admin-guide/cgroup-v2.rst b/Documentation/admin-guide/cgroup-v2.rst > index 176298f2f4de..0b9ca7e7df34 100644 > --- a/Documentation/admin-guide/cgroup-v2.rst > +++ b/Documentation/admin-guide/cgroup-v2.rst > @@ -1442,11 +1442,17 @@ PAGE_SIZE multiple when read back. > pgrefill (npn) > Amount of scanned pages (in an active LRU list) > > - pgscan (npn) > - Amount of scanned pages (in an inactive LRU list) > + pgscan_kswapd (npn) > + Amount of scanned pages by kswapd (in an inactive LRU list) > > - pgsteal (npn) > - Amount of reclaimed pages > + pgscan_direct (npn) > + Amount of scanned pages directly (in an inactive LRU list) > + > + pgsteal_kswapd (npn) > + Amount of reclaimed pages by kswapd > + > + pgsteal_direct (npn) > + Amount of reclaimed pages directly No objection to adding new fields but removing 'pgsteal' and 'pgscan' from the user visible API might break some applications.