From: Shakeel Butt <shakeelb@google.com>
To: Qi Zheng <zhengqi.arch@bytedance.com>
Cc: Michal Hocko <mhocko@kernel.org>,
Johannes Weiner <hannes@cmpxchg.org>,
Roman Gushchin <roman.gushchin@linux.dev>,
Muchun Song <songmuchun@bytedance.com>,
Andrew Morton <akpm@linux-foundation.org>,
Jonathan Corbet <corbet@lwn.net>, Linux MM <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
"open list:DOCUMENTATION" <linux-doc@vger.kernel.org>
Subject: Re: [PATCH] mm: memcontrol: separate {pgscan,pgsteal}_{kswapd,direct} items in memory.stat of cgroup v2
Date: Fri, 3 Jun 2022 17:47:14 -0700 [thread overview]
Message-ID: <CALvZod6s8ss0Doe9y+X=3ZHvw0Ove9Lw3MdfKekXr0gVnJwA4w@mail.gmail.com> (raw)
In-Reply-To: <20220603070423.10025-1-zhengqi.arch@bytedance.com>
On Fri, Jun 3, 2022 at 12:06 AM Qi Zheng <zhengqi.arch@bytedance.com> wrote:
>
[...]
>
> diff --git a/Documentation/admin-guide/cgroup-v2.rst b/Documentation/admin-guide/cgroup-v2.rst
> index 176298f2f4de..0b9ca7e7df34 100644
> --- a/Documentation/admin-guide/cgroup-v2.rst
> +++ b/Documentation/admin-guide/cgroup-v2.rst
> @@ -1442,11 +1442,17 @@ PAGE_SIZE multiple when read back.
> pgrefill (npn)
> Amount of scanned pages (in an active LRU list)
>
> - pgscan (npn)
> - Amount of scanned pages (in an inactive LRU list)
> + pgscan_kswapd (npn)
> + Amount of scanned pages by kswapd (in an inactive LRU list)
>
> - pgsteal (npn)
> - Amount of reclaimed pages
> + pgscan_direct (npn)
> + Amount of scanned pages directly (in an inactive LRU list)
> +
> + pgsteal_kswapd (npn)
> + Amount of reclaimed pages by kswapd
> +
> + pgsteal_direct (npn)
> + Amount of reclaimed pages directly
No objection to adding new fields but removing 'pgsteal' and 'pgscan'
from the user visible API might break some applications.
next prev parent reply other threads:[~2022-06-04 0:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-03 7:04 Qi Zheng
2022-06-03 15:38 ` Johannes Weiner
2022-06-03 18:26 ` Roman Gushchin
2022-06-04 0:47 ` Shakeel Butt [this message]
2022-06-04 1:24 ` Qi Zheng
2022-06-04 2:48 ` Muchun Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALvZod6s8ss0Doe9y+X=3ZHvw0Ove9Lw3MdfKekXr0gVnJwA4w@mail.gmail.com' \
--to=shakeelb@google.com \
--cc=akpm@linux-foundation.org \
--cc=corbet@lwn.net \
--cc=hannes@cmpxchg.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=roman.gushchin@linux.dev \
--cc=songmuchun@bytedance.com \
--cc=zhengqi.arch@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox