From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61594C6FD1C for ; Sat, 25 Mar 2023 04:31:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A8F896B0071; Sat, 25 Mar 2023 00:31:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A3E876B0074; Sat, 25 Mar 2023 00:31:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8DEE06B0075; Sat, 25 Mar 2023 00:31:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 7B27C6B0071 for ; Sat, 25 Mar 2023 00:31:04 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 3E085A0A4D for ; Sat, 25 Mar 2023 04:31:04 +0000 (UTC) X-FDA: 80606145648.11.CF1534C Received: from mail-yw1-f173.google.com (mail-yw1-f173.google.com [209.85.128.173]) by imf19.hostedemail.com (Postfix) with ESMTP id 818171A0014 for ; Sat, 25 Mar 2023 04:31:02 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=PHAZU2Rd; spf=pass (imf19.hostedemail.com: domain of shakeelb@google.com designates 209.85.128.173 as permitted sender) smtp.mailfrom=shakeelb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679718662; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hGXkNVqKc7W3NTjCcHQcK32QEBD4ibnmet17kfhhRaI=; b=UMMrDoKl/4BR1eBdtkBxhE3vF6vaTtXD7qT3eBfySDHLssN7DmOAfo9hvE74gSB6J4dQcf eojkIJFrhPyD2pgT2BDGPuOPqkjlxxRrWRYbMuafzlhBM3+z3eAcrUz32ehwjKaVYMKSnr OypaN1oTnF18AaGmWSPpTK9jR7CLE14= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=PHAZU2Rd; spf=pass (imf19.hostedemail.com: domain of shakeelb@google.com designates 209.85.128.173 as permitted sender) smtp.mailfrom=shakeelb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679718662; a=rsa-sha256; cv=none; b=eoQGMfmEcxqTPm9JTRYUhwMbXcHI5KrangSCMW8D3R+WKInasqISd1J1uuLiOTu7/TY6dx F4CMmPVx3p+/ZCtZ+mA+vUWUY3mZYyu8vDnJHcrdD8pbDbXdUNRZGahtf/4XSBMUkEdoyG RKDQH0gQMdCgTs01fs1XnET9cmsX8dQ= Received: by mail-yw1-f173.google.com with SMTP id 00721157ae682-53d277c1834so69734727b3.10 for ; Fri, 24 Mar 2023 21:31:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; t=1679718661; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=hGXkNVqKc7W3NTjCcHQcK32QEBD4ibnmet17kfhhRaI=; b=PHAZU2Rd9Fp65snbdneP5IXYTtAFunJK2mfV2/pfOyuB8dkyTMfzLLe7Dl3igKadFa 9se6SnVK1wDMGZrmKj4em9x05vBVwT9dWKvwg8pfB+2xddz8jQLLd8c3dXTvTi5HoOEM 2GmUtVmBPiPdjr12BNA1afc7hYkVEBk1ABclJR45XULgq8DAuovm6lEt8UxThY/ahIWw /3+c8DXYKZwbijUtJPP5HW0j6XNHzjMvdaTMuYjuMYSA5o4nA0vJqIFNgoPtwVjvftrU rmoy1A9rEEka+aR2qVX1FnFd+1ObOumqDzWfDhM4lQCmdSGzsAXwwcTSY0Qcql8kFfYk X7yQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679718661; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hGXkNVqKc7W3NTjCcHQcK32QEBD4ibnmet17kfhhRaI=; b=MypMx+5G+2F0nTV596RqeEVhTAk5DfhHhunuITtz3vsRuWjhYsRtZ5R80135S09pAm kj/44PWcH3+su4MnCpZlBYLZxWNEBriYOZuPFVyvEu82R/KPCC+RXoISQhInLoaT82jI LtGJiVM6B01nCQGxzFwwnBJvrro/yFymm1+RKoRpde9yAnVbas4CzRA5Ae+geoeGoJ4m eAvzEDYJwU/nboZTygcbC/xnOhQne9ZCdQBOCL8h/XwdCghsoVJO+X/iAv1AmgNQUeoO w0+G3ekUcphuIava5joOBz78aVAJTOBrgPsecs5vNOzNDnd5C5i3703YquXnMQjA3S7o 28hg== X-Gm-Message-State: AAQBX9cm+46gPq1HPBjsVmOwMUfZUCN9TRh+PQFOxshfCw9ZsHX5zzuL fL6SbwpxDPWHp6Hgigr1gkJk/JAEMAb0BawOoiohdQ== X-Google-Smtp-Source: AKy350ZELBPdnNH9RPXKXKnO784dLdfbc+FayCnRhRX2loqVW8hP2461hi+p6RkMJbrBPkX0+F1XATk0SQY/rmWNXHA= X-Received: by 2002:a81:4517:0:b0:545:343b:ecba with SMTP id s23-20020a814517000000b00545343becbamr1799325ywa.0.1679718661454; Fri, 24 Mar 2023 21:31:01 -0700 (PDT) MIME-Version: 1.0 References: <20230323040037.2389095-1-yosryahmed@google.com> <20230323040037.2389095-2-yosryahmed@google.com> In-Reply-To: From: Shakeel Butt Date: Fri, 24 Mar 2023 21:30:49 -0700 Message-ID: Subject: Re: [RFC PATCH 1/7] cgroup: rstat: only disable interrupts for the percpu lock To: Yosry Ahmed Cc: Tejun Heo , Josef Bacik , Jens Axboe , Zefan Li , Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , Andrew Morton , Vasily Averin , cgroups@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, bpf@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 818171A0014 X-Stat-Signature: ahua836bbj5d98zyzqjahobee76mf54b X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1679718662-347474 X-HE-Meta: U2FsdGVkX1+GKpvDrEiWRdcTazwUqIeVIO2R6T7/yAWaUfVaoeXvyWerq96Wh4Qj7wBG3w16ta3NzKZvlNJfqLzV9dtDULJmEUUUElrketGNnL3R1vuiYDbWv5Xf86S1gvzw+qcFpX2uM/eyNPs/trJGuBq0btqUA2CyQ0XKal9sBuRPra3ZWnOvRdKFg1XFC0SkxCeqdxOiilCQ6vx+LESdYjArhIxarEA+DIAxsJdhIQUZKOaODqUCn2IO2Jg/X9cP6rQfTrU62cMueHcFfMTMzGJ7rDdh6bb69c0WI06i2QJe8kS3gyQm7Bv2e33d8j6wb0jiL1L7+GMy7S7XJWuBuz/Zm8ayQaCMC+T+weaIEMNwfZ5w13ET79/vlq6aSikP89mgE0hMVnHlZa3BfhU9e4ooI6b6Ky4D+uoYt8O5izFykFTFoKziMTk9NcQtSKoPSl9JEAfFMx5MdQeZz7qbeqE1U69BLfL3VkKFl9RBdOHyKDsSwtJwwT9O9HTeRNHcThKbHRNiUTwhXGDbYmusdbD6PAL0tfC75KqPhsDp0DDiZdxtY+oXizdSJJnVobhik8fC70boLtI+MOUumpfmMtGcKTNDvNRMbnsRfoDG/0qC11a9xOnpaR45ozFDqg/utVc9thGni8yFoLCnDptUGMnywYzjBIZ3nf5zJdfR9PRq26WrtT5Tn2QyP/QYvz1A2aKuQEp7ukF8cr6HH8EDcgDegAsl9n4KHdXzHUUSerqi2pU7ShrAwwCUyw+9slkofTaUKIJVW2smmig751B6Mfbyk6Q/ZgeJXv8zsU71+bp7GqhGMNDCCilXZB9r+4BxmYHqtj2q8G7gf0e3IxmQF/sqjo91GpXFYEunpiJ2Gz9WTlADzZjKg7jM+t43n/TcXWSZhN2QocAesMBDppbo/PO6TIW3s3Ii3UEGZDyMAB7IvCsz7tQA6D++OyfKM837PTsb8vvyoAzqV4/ fiIUoatd MftB5B6KvPa3cL75MJlseLVP1P588cc9m23trsYrXjK/EGWc1hxi/Vb5T5b592Ow0yBOQ4Jr5y4KJBE+eXGhmZAmI3nSaHFCQWpJjP2HEykf88AKoD3nqx4QP7MSQE+ad06FXoHBAP+zQulqQbXdAFAc+/hoW76rhF5OBiEssVX17/a9tmX2gfaYHH4UYlw+PL2oYYK9WG2wcHRzHiFrztEsltzHhhUqV1/R3Rxmr2Jy6B+/RKwFs+FrjbpCTwC9CKrSKEdZmJEUPmvcQlM9rfXIOmMObHJlJhe2vRSzBP2mAu04= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000063, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Mar 24, 2023 at 7:18=E2=80=AFPM Yosry Ahmed = wrote: > [...] > Any ideas here are welcome! > Let's move forward. It seems like we are not going to reach an agreement on making cgroup_rstat_lock a non-irq lock. However there is agreement on the memcg code of not flushing in irq context and the cleanup Johannes has requested. Let's proceed with those for now. We can come back to cgroup_rstat_lock later if we still see issues in production. Tejun, do you have any concerns on adding WARN_ON_ONCE(!in_task()) in the rstat flushing code?