From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1588CC433EF for ; Sat, 21 May 2022 21:36:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 797DC8D0003; Sat, 21 May 2022 17:36:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 71FEF8D0001; Sat, 21 May 2022 17:36:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5C1D18D0003; Sat, 21 May 2022 17:36:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 4E4078D0001 for ; Sat, 21 May 2022 17:36:04 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay12.hostedemail.com (Postfix) with ESMTP id 16A9A1207CB for ; Sat, 21 May 2022 21:36:04 +0000 (UTC) X-FDA: 79491058248.06.C908D25 Received: from mail-pg1-f171.google.com (mail-pg1-f171.google.com [209.85.215.171]) by imf19.hostedemail.com (Postfix) with ESMTP id 11F131A0017 for ; Sat, 21 May 2022 21:35:51 +0000 (UTC) Received: by mail-pg1-f171.google.com with SMTP id j21so10331048pga.13 for ; Sat, 21 May 2022 14:36:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Ovbs7SznoJE1sVxkoT4HN7MF5cA4tFBx5ooIOKpQ5rI=; b=HtMT4pCc5uH63EO6XlkrHpLrHOUT2F/DcCheEuURYYK0r2GEGrJzb/3oD1DgUHGgbS DTZvc7agujFsGc8vMopNkC6FjfuUA9MJkZ1FHzoiTFJd0SVGVTNnT9W5ykihOzFgtLAr S0EWv4ixlw92AThV7s6hF6xrQQfmjkH1fSqJgR9tQztQtG03xBmGq0UWxi5Sdtkykpri hadLh08mZRRFMRw+n0UWus3QJC6eVtN5cCmJjI/1F727JI4G0yv5iVqGWpauiYPRlPlx kfbkguPiTMODEoDYwaJS3f5Na9KWMUkMa3aNy8bN+imxqdX4Zat5tfu6XlyOAvSHZtLF apBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Ovbs7SznoJE1sVxkoT4HN7MF5cA4tFBx5ooIOKpQ5rI=; b=CGrlRrZ1s4wQU5QgBTek7+ZwoDs3Gd7cn2rpbJIkbJOd6qtn4p+dY4/pO2dneP9SN+ fv2Q/AFMzZgdIkjYfajDOMrrbMQwCllh/891KbvNnSA4cmRMoRyai3HoP+QYdDaJQZDj 02b/nZhH4O6hUdnam77c8Iu/RzUNp5wk635Z89qHhqASBep45WD7ny2X7GqmZegEs5Fo RS6lUsH3a5b7wzASSL4JoUURaYWaOiUtjka+ViMLxIDC56evJPekRBCbvNJAgxa+6Sax 3wvx7fd9lJcKAG+81Jo2U1UqMTHfi0zcdIOuU46lgLAvUhdtTWETT7AgCEYKoqUfxnMF CUXA== X-Gm-Message-State: AOAM533TAIyeYeftLO44KXtpPdPAiZF221eXkbDzj7rW03ASzRzTqPm4 DFpB417QCwAaw1lBI4ZpniXTLU51aw/wjuYgr6puKA== X-Google-Smtp-Source: ABdhPJzCleNN7K0mPF5p8/6nUwtQrfjp2U5OUs4q6huEQPlWDTeftyFsrNyDhBBoOzO6JkJ+fig1rh0AruZPfG7iBVQ= X-Received: by 2002:a63:f0a:0:b0:3c6:e825:2431 with SMTP id e10-20020a630f0a000000b003c6e8252431mr13968312pgl.166.1653168962273; Sat, 21 May 2022 14:36:02 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Shakeel Butt Date: Sat, 21 May 2022 14:35:51 -0700 Message-ID: Subject: Re: [PATCH mm v2 6/9] memcg: enable accounting for percpu allocation of struct cgroup_rstat_cpu To: Vasily Averin Cc: Andrew Morton , kernel@openvz.org, LKML , Linux MM , Roman Gushchin , =?UTF-8?Q?Michal_Koutn=C3=BD?= , Vlastimil Babka , Michal Hocko , Cgroups Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Queue-Id: 11F131A0017 X-Stat-Signature: ef163q7w9qthxtbocfmy1bwds3bap6an Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=HtMT4pCc; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf19.hostedemail.com: domain of shakeelb@google.com designates 209.85.215.171 as permitted sender) smtp.mailfrom=shakeelb@google.com X-Rspamd-Server: rspam04 X-HE-Tag: 1653168951-763330 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, May 21, 2022 at 9:38 AM Vasily Averin wrote: > > struct cgroup_rstat_cpu is percpu allocated for each new cgroup and > can consume a significant portion of all allocated memory on nodes > with a large number of CPUs. > > Common part of the cgroup creation: > Allocs Alloc $1*$2 Sum Allocation > number size > -------------------------------------------- > 16 ~ 352 5632 5632 KERNFS > 1 + 4096 4096 9728 (cgroup_mkdir+0xe4) > 1 584 584 10312 (radix_tree_node_alloc.constprop.0+0x89) > 1 192 192 10504 (__d_alloc+0x29) > 2 72 144 10648 (avc_alloc_node+0x27) > 2 64 128 10776 (percpu_ref_init+0x6a) > 1 64 64 10840 (memcg_list_lru_alloc+0x21a) > percpu: > 1 + 192 192 192 call_site=psi_cgroup_alloc+0x1e > 1 + 96 96 288 call_site=cgroup_rstat_init+0x5f > 2 12 24 312 call_site=percpu_ref_init+0x23 > 1 6 6 318 call_site=__percpu_counter_init+0x22 > > '+' -- to be accounted, > '~' -- partially accounted > > Signed-off-by: Vasily Averin Acked-by: Shakeel Butt