From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E426EC433EF for ; Sun, 16 Jan 2022 19:23:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 098C46B0072; Sun, 16 Jan 2022 14:23:50 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 049346B0074; Sun, 16 Jan 2022 14:23:50 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EAB236B0072; Sun, 16 Jan 2022 14:23:49 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0142.hostedemail.com [216.40.44.142]) by kanga.kvack.org (Postfix) with ESMTP id DBE976B0072 for ; Sun, 16 Jan 2022 14:23:49 -0500 (EST) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 95EAD95B13 for ; Sun, 16 Jan 2022 19:23:49 +0000 (UTC) X-FDA: 79037124978.18.7C597B2 Received: from mail-lf1-f52.google.com (mail-lf1-f52.google.com [209.85.167.52]) by imf20.hostedemail.com (Postfix) with ESMTP id 497951C0007 for ; Sun, 16 Jan 2022 19:23:49 +0000 (UTC) Received: by mail-lf1-f52.google.com with SMTP id d3so49520387lfv.13 for ; Sun, 16 Jan 2022 11:23:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=hU+OS4Mtwv3I0vy+iNW/4UuAtkSDs3qfMaH9agtczxw=; b=IXBWqMIvZmgkCjiwt9Q3j+mjCGE+6J+S4UDiBSUUpGUCfcno5XNU/zEfNYKufj9pbo mN46XqggL2AKWpLF0dagxWhuVQJhVngCZkW9t7ZU/R9pPe5cSQNatJ6t6mewMX7oANMP o5i4BneUdKCm/W9x7ztGVl2/TpDJFubZ62AkNI2JLiQKEwH0S0m+W99r1bilWzu101ML bqPIDTz+r6IkzCdhBBmz7iKT71B32Z+USN41d9Bb/QkL4dHC6bALBYyopRq3S85iZJ+w w3njQ/ET4IoYJunHTC9QAZ6JfphnkZkpJgO/tY4Gn3+B+1gN3CczulAwseNhpKLxexfF R3bw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hU+OS4Mtwv3I0vy+iNW/4UuAtkSDs3qfMaH9agtczxw=; b=s5u/8KTkYr2QvtzlURqu8SILYrrWlqNm3K1feVTu3Bi3bSB1Xpa7OHSlASQIsSAY5d xVM2ldUX0IJuphpPJqd2z7ITZZdM8QWB4OPxHjFhoVStxJfkNKDjl28rkNdXSECKR1bS 6W1Q74Tv0DU7ly+daEWmkKyzXJVxaR4jYa/tbdQwRymz7BaXIUFYpJjDhKwITndN7r64 /CzCHPsD9sCDeeBnrq3IhAjSYbmgzzLNKjQu8397KUD0DCJAprChJYHP+fLALdPtIct8 0+MaYaO9Hq4OURhQh7JqAk22oxPfNvsDiWaGSgyIwy+t0Gca194MfMzfUFbXvC5wCWkw tKMw== X-Gm-Message-State: AOAM530LYEL4KFuJX7v9ziabLiZw6xQdbUZKJHQCKKcB5DEHxYegoz1/ DPxnTV27RvWQYO3xDRIWVL/TfKm6BwU8ZBJZDkdkog== X-Google-Smtp-Source: ABdhPJzGmmRPBzFq6kEJt5LpR69nvflMg1bsSG4dtuip0qaqVYBqdvK9cnATbBijztPoDBr9dI8dXCYnY6ktmayGy+c= X-Received: by 2002:a2e:3804:: with SMTP id f4mr12569369lja.35.1642361027245; Sun, 16 Jan 2022 11:23:47 -0800 (PST) MIME-Version: 1.0 References: <20220111010302.8864-1-richard.weiyang@gmail.com> <20220112004634.dc5suwei4ymyxaxg@master> In-Reply-To: From: Shakeel Butt Date: Sun, 16 Jan 2022 11:23:36 -0800 Message-ID: Subject: Re: [PATCH 1/4] mm/memcg: use NUMA_NO_NODE to indicate allocation from unspecified node To: Michal Hocko Cc: Wei Yang , Johannes Weiner , Vladimir Davydov , Andrew Morton , Roman Gushchin , Vlastimil Babka , Matthew Wilcox , Muchun Song , Yang Shi , Suren Baghdasaryan , LKML , Cgroups , Linux MM Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 497951C0007 X-Stat-Signature: 9fzrbhqipw8m41b3y1de4k77mri9prf7 Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=IXBWqMIv; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf20.hostedemail.com: domain of shakeelb@google.com designates 209.85.167.52 as permitted sender) smtp.mailfrom=shakeelb@google.com X-Rspamd-Server: rspam06 X-HE-Tag: 1642361029-275513 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jan 12, 2022 at 12:56 AM Michal Hocko wrote: > > On Wed 12-01-22 00:46:34, Wei Yang wrote: > > On Tue, Jan 11, 2022 at 09:40:20AM +0100, Michal Hocko wrote: > > >On Tue 11-01-22 01:02:59, Wei Yang wrote: > > >> Instead of use "-1", let's use NUMA_NO_NODE for consistency. > > >> > > >> Signed-off-by: Wei Yang > > > > > >I am not really sure this is worth it. After the merge window I plan to > > >post http://lkml.kernel.org/r/20211214100732.26335-1-mhocko@kernel.org. > > > > Give me some time to understand it :-) > > Just for the record, here is what I have put on top of that series: > --- > From b7195eba02fe6308a6927450f4630057c05e808e Mon Sep 17 00:00:00 2001 > From: Wei Yang > Date: Tue, 11 Jan 2022 09:45:25 +0100 > Subject: [PATCH] memcg: do not tweak node in alloc_mem_cgroup_per_node_info > > alloc_mem_cgroup_per_node_info is allocated for each possible node and > this used to be a problem because not !node_online nodes didn't have > appropriate data structure allocated. This has changed by "mm: handle > uninitialized numa nodes gracefully" so we can drop the special casing > here. > > Signed-off-by: Wei Yang > Signed-off-by: Michal Hocko Reviewed-by: Shakeel Butt