From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE46EC433F5 for ; Fri, 13 May 2022 17:23:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 646336B0073; Fri, 13 May 2022 13:23:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5F5F36B0075; Fri, 13 May 2022 13:23:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4E3C86B0078; Fri, 13 May 2022 13:23:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 401D16B0073 for ; Fri, 13 May 2022 13:23:49 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 0409B20B41 for ; Fri, 13 May 2022 17:23:48 +0000 (UTC) X-FDA: 79461392178.02.0A246BA Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) by imf09.hostedemail.com (Postfix) with ESMTP id D003C1400A5 for ; Fri, 13 May 2022 17:23:39 +0000 (UTC) Received: by mail-pl1-f175.google.com with SMTP id d17so8615220plg.0 for ; Fri, 13 May 2022 10:23:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=pUiCnPMeV2tewEXDSR1Opfl8CW/W1nTXt/fBcyuE7po=; b=hcbrT8LB9KtUyOFhJcjNGDoACadQCvR45e8T6zhTyidWst7gm9QCPlPUMus2qyKZO5 F5DqklOOcurOuJJoDyNyaahuz9kll92/JgnSl7AlqgPH+K3Sn2fBXIsuvf7m/+R6yAVS fsGK3TwUuxHbSqM+peiMHJozwxnh0TRDv3ZGQTeyAIlOMdMVBvwteTZ4PytPmR9t47Gg pqGrxwTsmpv7IbPbGbuf/rmrhjr8qRe8wpa4F75swNWUD2SfEYFj+qQV2DV/gexKRIvo 8snEpImCqQT57ffaUneyHTR7IkLcLcdzbaRzu3MoseaxEL7zq3AKDZum93Mv0C+hXL9+ x1Jw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=pUiCnPMeV2tewEXDSR1Opfl8CW/W1nTXt/fBcyuE7po=; b=rCNrpWmc8UTpLST6ldVtRMFXKM1CNjlKwRv7IKxTkxoHLuf5hE/MGYyUxdL4CKaLcn TFb4MpTCCs8iTTFe22HwIPAU0z/dr6gOhlLoAVHhMO02wJa50SGLoRnrxBMBmG/SuaTG uJx1AF8gP+CCs5/9Ezx10JDqmB/1bcKxwG9JOM1fVVBt2cFfN1J45YymDquJs2sNYl8e 5RZJoJ9sl8SHL/MaIbutS7dbavhcLUJ4Wsu3Kvn5C/fuQW+ta+fpCfipb6txst06hNXF RDWYhR7NUW3sVEW12Iq29fBraWlNe1tyTyGgeozmcmC5Z7HrNziN93zjiGHFd4h33n6e 9TlQ== X-Gm-Message-State: AOAM533ozsBD+PE5Aa6siigWaGtnsEnorCyoskqClxBfzKCFF0ggv7cM pPzaxhaomMnF//+1Q03pYJfPqEYCc4sI9e2xoiH1Vw== X-Google-Smtp-Source: ABdhPJz4VHbNlIGbH/16c9aEUEopLMQoK6LkB7d36n7lf29oYijqqNLTzk2YOn+i0DI+nxCAjpyhWmReuAOUVN9lSMM= X-Received: by 2002:a17:902:b094:b0:15c:dee8:74c8 with SMTP id p20-20020a170902b09400b0015cdee874c8mr5479352plr.6.1652462627392; Fri, 13 May 2022 10:23:47 -0700 (PDT) MIME-Version: 1.0 References: <20220510152847.230957-1-hannes@cmpxchg.org> <20220510152847.230957-7-hannes@cmpxchg.org> In-Reply-To: <20220510152847.230957-7-hannes@cmpxchg.org> From: Shakeel Butt Date: Fri, 13 May 2022 10:23:36 -0700 Message-ID: Subject: Re: [PATCH v2 6/6] zswap: memcg accounting To: Johannes Weiner Cc: Andrew Morton , Michal Hocko , Roman Gushchin , Seth Jennings , Dan Streetman , Minchan Kim , Linux MM , Cgroups , LKML , Kernel Team Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: D003C1400A5 X-Stat-Signature: 9h5q1pismtjjuw4pu6twur7zz41ym8rc Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=hcbrT8LB; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf09.hostedemail.com: domain of shakeelb@google.com designates 209.85.214.175 as permitted sender) smtp.mailfrom=shakeelb@google.com X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1652462619-787701 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, May 10, 2022 at 8:29 AM Johannes Weiner wrote: > [...] > +void obj_cgroup_charge_zswap(struct obj_cgroup *objcg, size_t size) > +{ > + struct mem_cgroup *memcg; > + > + VM_WARN_ON_ONCE(!(current->flags & PF_MEMALLOC)); > + > + /* PF_MEMALLOC context, charging must succeed */ ) Instead of these warnings and comment why not just explicitly use memalloc_noreclaim_[save|restore]() ? > + if (obj_cgroup_charge(objcg, GFP_KERNEL, size)) Can we please make this specific charging an opt-in feature or at least provide a way to opt-out? This will impact users/providers where swap is used transparently (in terms of memory usage). Also do you want this change for v1 users as well? > + VM_WARN_ON_ONCE(1); > + > + rcu_read_lock(); > + memcg = obj_cgroup_memcg(objcg); > + mod_memcg_state(memcg, MEMCG_ZSWAP_B, size); > + mod_memcg_state(memcg, MEMCG_ZSWAPPED, 1); > + rcu_read_unlock(); > +} > +