From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yw0-f197.google.com (mail-yw0-f197.google.com [209.85.161.197]) by kanga.kvack.org (Postfix) with ESMTP id 859E96B031D for ; Thu, 7 Sep 2017 15:43:37 -0400 (EDT) Received: by mail-yw0-f197.google.com with SMTP id i196so1253690ywg.5 for ; Thu, 07 Sep 2017 12:43:37 -0700 (PDT) Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id o188sor64245ywe.157.2017.09.07.12.43.36 for (Google Transport Security); Thu, 07 Sep 2017 12:43:36 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <20170907184745.GA20598@castle.DHCP.thefacebook.com> References: <20170829100150.4580-1-guro@fb.com> <20170829192621.GA5447@cmpxchg.org> <20170830105524.GA2852@castle.dhcp.TheFacebook.com> <20170907184745.GA20598@castle.DHCP.thefacebook.com> From: Shakeel Butt Date: Thu, 7 Sep 2017 12:43:35 -0700 Message-ID: Subject: Re: [PATCH] mm: memcontrol: use per-cpu stocks for socket memory uncharging Content-Type: text/plain; charset="UTF-8" Sender: owner-linux-mm@kvack.org List-ID: To: Roman Gushchin Cc: Johannes Weiner , Linux MM , Michal Hocko , Vladimir Davydov , cgroups@vger.kernel.org, kernel-team@fb.com, LKML On Thu, Sep 7, 2017 at 11:47 AM, Roman Gushchin wrote: > On Thu, Sep 07, 2017 at 11:44:12AM -0700, Shakeel Butt wrote: >> >> As far as other types of pages go: page cache and anon are already >> >> batched pretty well, but I think kmem might benefit from this >> >> too. Have you considered using the stock in memcg_kmem_uncharge()? >> > >> > Good idea! >> > I'll try to find an appropriate testcase and check if it really >> > brings any benefits. If so, I'll master a patch. >> > >> >> Hi Roman, did you get the chance to try this on memcg_kmem_uncharge()? > > Hi Shakeel! > > Not yet, I'll try to it asap. > Do you have an example when it's costly? > Nah, I was also curious of such examples. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org