From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A8A5C433E0 for ; Fri, 22 May 2020 14:08:11 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id DF8B221897 for ; Fri, 22 May 2020 14:08:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="Q98veh9b" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DF8B221897 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 46D9480008; Fri, 22 May 2020 10:08:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 42C9D80007; Fri, 22 May 2020 10:08:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 30A3E80008; Fri, 22 May 2020 10:08:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0090.hostedemail.com [216.40.44.90]) by kanga.kvack.org (Postfix) with ESMTP id 156B680007 for ; Fri, 22 May 2020 10:08:10 -0400 (EDT) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id CD470585B for ; Fri, 22 May 2020 14:08:09 +0000 (UTC) X-FDA: 76844534298.15.rifle36_473d512a53421 X-HE-Tag: rifle36_473d512a53421 X-Filterd-Recvd-Size: 3629 Received: from mail-lf1-f65.google.com (mail-lf1-f65.google.com [209.85.167.65]) by imf15.hostedemail.com (Postfix) with ESMTP for ; Fri, 22 May 2020 14:08:09 +0000 (UTC) Received: by mail-lf1-f65.google.com with SMTP id z206so2944729lfc.6 for ; Fri, 22 May 2020 07:08:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ASpIJRV1LgbYaIn/8sihf9PSqZ7K//HA8oIfV5Jji1U=; b=Q98veh9b1zBp4PWhmCf74WRK0Byrzkwey2rtOIQaXyx1kyEDcG3M6jXlCJOhaNxM5/ 9sj2TOOYHXEwh0fYzQ9FWMZfc0E8eE1/WZ2qrZajc+2KYj6iyYljfm/4TvkU3jkfOFI3 YYUty1xtwI/bERs9jSMcLkRivOd74V0q8VEyy+weMSJJux6/WgAlmVEJMy5S77lYpI6X C4RRVTYaZZ3O6DoGtybBgW13esxeDx7YL6yHgkoJ4xGvMUndKjLCAM0tNGLW0pfCIKJU 1RIk/vV7uokJ+qdYAfnkLwrgbKEC2CRiXSL18tpjvsHmOZiGRKjVtgqW4lxZcNme/MRF 2niQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ASpIJRV1LgbYaIn/8sihf9PSqZ7K//HA8oIfV5Jji1U=; b=KQoVGpXAOic+Ykv4CpZTd5GzaFCLL+5RWw/1HKMzugP8szY5QrQe9pzHYtlEdyk6XB CGTTG4W5Jhj8QHsBLXlmMvPmAqjhsZxl1sSJ0a2NsS0G8c9HH+ewTNSmwSjmhjftr2UM GJe23gzqHZbmwkPIMnfUsboSXsXxUnqawG8CXIySWOcVs/yWIH60YvhPkUrauQy9C6gl X15Lk0ti33Rsv1t4AgDIOKmyz9F2g5a5woRwwXNujNItYtGyz8vK7cnhgpd56nfp6+tA eBo/YDXVnr27WGqwLy0g508EZHQ4XKO3Na+n+BhKrLixaO8DtWxYiBiCy9xLYIWLoqLx 0axg== X-Gm-Message-State: AOAM533nQCn1ujOSwfohtY+7rlAxJj3tCexpvoLkinJVJ0zdYAIWoIBQ KzP6xuoc5eaGVaMonOVmBrYJT4X89Pnnxby5wjKnBQ== X-Google-Smtp-Source: ABdhPJx2ifzFEDI+8FVLUA5dMaNvcKyEcuulaqadgxsGJ+06MBXDJr9QzwzWTQLe7Y3YlQblnOnWWMOrrm/JyeFd854= X-Received: by 2002:a19:490d:: with SMTP id w13mr7491640lfa.96.1590156487605; Fri, 22 May 2020 07:08:07 -0700 (PDT) MIME-Version: 1.0 References: <20200520163142.GA808793@chrisdown.name> In-Reply-To: <20200520163142.GA808793@chrisdown.name> From: Shakeel Butt Date: Fri, 22 May 2020 07:07:56 -0700 Message-ID: Subject: Re: [PATCH] mm, memcg: unify reclaim retry limits with page allocator To: Chris Down Cc: Andrew Morton , Johannes Weiner , Michal Hocko , Linux MM , Cgroups , LKML , Kernel Team Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, May 20, 2020 at 9:32 AM Chris Down wrote: > > Reclaim retries have been set to 5 since the beginning of time in > 66e1707bc346 ("Memory controller: add per cgroup LRU and reclaim"). > However, we now have a generally agreed-upon standard for page reclaim: > MAX_RECLAIM_RETRIES (currently 16), added many years later in > 0a0337e0d1d1 ("mm, oom: rework oom detection"). > > In the absence of a compelling reason to declare an OOM earlier in memcg > context than page allocator context, it seems reasonable to supplant > MEM_CGROUP_RECLAIM_RETRIES with MAX_RECLAIM_RETRIES, making the page > allocator and memcg internals more similar in semantics when reclaim > fails to produce results, avoiding premature OOMs or throttling. > > Signed-off-by: Chris Down Reviewed-by: Shakeel Butt