From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5ECEAC433F5 for ; Tue, 23 Nov 2021 01:21:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DF6AB6B0072; Mon, 22 Nov 2021 20:21:22 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DA6036B0073; Mon, 22 Nov 2021 20:21:22 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C94C26B0074; Mon, 22 Nov 2021 20:21:22 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0179.hostedemail.com [216.40.44.179]) by kanga.kvack.org (Postfix) with ESMTP id BAD596B0072 for ; Mon, 22 Nov 2021 20:21:22 -0500 (EST) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 894F584CE9 for ; Tue, 23 Nov 2021 01:21:12 +0000 (UTC) X-FDA: 78838441542.11.7FED6B8 Received: from mail-lj1-f174.google.com (mail-lj1-f174.google.com [209.85.208.174]) by imf18.hostedemail.com (Postfix) with ESMTP id 29F7A400209B for ; Tue, 23 Nov 2021 01:21:10 +0000 (UTC) Received: by mail-lj1-f174.google.com with SMTP id k2so7676782lji.4 for ; Mon, 22 Nov 2021 17:21:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=PZNVY9+03dEFejIwzLUj2PbaiVC1vy5FYIvkJizW4dQ=; b=CUvfp14TbL49LRiKzGVqTH2EYU63uY6IsAJcq5kvTwhdkLT5s1JIargoRqeM6fpkEm LFMO5UIM+oAVs07AlSdrpr5zZIJmQHqSz8d0xEHXO/6QkDzo2z7WN70mjVjOSjDPrQzj v3HALSn4twgfz2FdbNk6l4GBYfoaMWqi/YiSJ/Fu6tYQbVh5242dK3h+mJBxSnXlALUV uJO/eIlyVe5K1AjcEK8oqYVhOKsxWw0R5zowd15VsE7pqg/H2BnP7l9Twy/g6NY9H9HM TVNK7fFUbOP58/IGQeb+O9qHIHzn6fBXcmTk/GnDSf2zcFbrx8fsb+UEJrCrSF06DywY hIOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=PZNVY9+03dEFejIwzLUj2PbaiVC1vy5FYIvkJizW4dQ=; b=UzY7SFDU9ejt1azl9syIA2IWgV6vsooGbtN8t6DowvhW0BZbsKhUnemfeRtuxIq+gf vkhlmg/rywRP3ke0jLM/k70cAHJRjIc+4LyKgFDfKSUOUuetp8oxEx3oVyQFi82t4x+R 6h/Hwtzu5REoRVayWWfrCk/6nV4azEMwdoTrQiIOfgNKpYwQiHBnrIRrrgRmkdlx8MZK r00iEbGxqZ/sEa/apV6Gnm+9m2JQ1WqLEHGFH4yIMr3tPj+zD0eV71Zj2/vWp0tydejy 7UGo8O0VGRfHVBr9cgfjeldfoBOZ1a9QIVxziqh814EqliQrKt4XqYpCCFiVHVhIoVHj Rwxw== X-Gm-Message-State: AOAM531rA2BJKzLxQbK3KTryuiS53DXSgffXkvoUXFJPrHzgURB5g/UC frTRfc6hK2ZMg+TlKS0f33B0DpOH1pR47SF9iLuN3A== X-Google-Smtp-Source: ABdhPJzdBbddli4+dHgpML9E8V8zH8wRcIUvFDly89JkVjxpJyrwxoG82YtIxjNz4+uZvgEakw7l+ou6zPMFsmdliKM= X-Received: by 2002:a05:651c:545:: with SMTP id q5mr833343ljp.202.1637630470541; Mon, 22 Nov 2021 17:21:10 -0800 (PST) MIME-Version: 1.0 References: <20211123001020.4083653-1-almasrymina@google.com> In-Reply-To: <20211123001020.4083653-1-almasrymina@google.com> From: Shakeel Butt Date: Mon, 22 Nov 2021 17:20:59 -0800 Message-ID: Subject: Re: [PATCH v8] hugetlb: Add hugetlb.*.numa_stat file To: Mina Almasry Cc: Tejun Heo , Zefan Li , Johannes Weiner , Jonathan Corbet , Mike Kravetz , Andrew Morton , Shuah Khan , Miaohe Lin , Oscar Salvador , Michal Hocko , Muchun Song , David Rientjes , Jue Wang , Yang Yao , Joanna Li , Cannon Matthews , linux-mm@kvack.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-doc@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 29F7A400209B X-Stat-Signature: o53pxaetfpfq3bjhbjqfneexaehrci14 Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=CUvfp14T; spf=pass (imf18.hostedemail.com: domain of shakeelb@google.com designates 209.85.208.174 as permitted sender) smtp.mailfrom=shakeelb@google.com; dmarc=pass (policy=reject) header.from=google.com X-HE-Tag: 1637630470-964108 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Nov 22, 2021 at 4:10 PM Mina Almasry wrote= : > > For hugetlb backed jobs/VMs it's critical to understand the numa > information for the memory backing these jobs to deliver optimal > performance. > > Currently this technically can be queried from /proc/self/numa_maps, but > there are significant issues with that. Namely: > 1. Memory can be mapped or unmapped. > 2. numa_maps are per process and need to be aggregated across all > processes in the cgroup. For shared memory this is more involved as > the userspace needs to make sure it doesn't double count shared > mappings. > 3. I believe querying numa_maps needs to hold the mmap_lock which adds > to the contention on this lock. > > For these reasons I propose simply adding hugetlb.*.numa_stat file, > which shows the numa information of the cgroup similarly to > memory.numa_stat. > > On cgroup-v2: > cat /sys/fs/cgroup/unified/test/hugetlb.2MB.numa_stat > total=3D2097152 N0=3D2097152 N1=3D0 > > On cgroup-v1: > cat /sys/fs/cgroup/hugetlb/test/hugetlb.2MB.numa_stat > total=3D2097152 N0=3D2097152 N1=3D0 > hierarichal_total=3D2097152 N0=3D2097152 N1=3D0 > > This patch was tested manually by allocating hugetlb memory and querying > the hugetlb.*.numa_stat file of the cgroup and its parents. > =EF=BF=BC > Cc: Mike Kravetz > Cc: Andrew Morton > Cc: Shuah Khan > Cc: Miaohe Lin > Cc: Oscar Salvador > Cc: Michal Hocko > Cc: Muchun Song > Cc: David Rientjes > Cc: Shakeel Butt > Cc: Jue Wang > Cc: Yang Yao > Cc: Joanna Li > Cc: Cannon Matthews > Cc: linux-mm@kvack.org > Cc: linux-kernel@vger.kernel.org > > Signed-off-by: Mina Almasry > Reviewed-by: Shakeel Butt