From: Shakeel Butt <shakeelb@google.com>
To: Waiman Long <longman@redhat.com>
Cc: Johannes Weiner <hannes@cmpxchg.org>,
Michal Hocko <mhocko@kernel.org>,
Vladimir Davydov <vdavydov.dev@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Tejun Heo <tj@kernel.org>, LKML <linux-kernel@vger.kernel.org>,
Cgroups <cgroups@vger.kernel.org>, Linux MM <linux-mm@kvack.org>,
Chris Down <chris@chrisdown.name>, Roman Gushchin <guro@fb.com>,
Yafang Shao <laoar.shao@gmail.com>
Subject: Re: [PATCH v2 3/3] mm/memcg: Unify swap and memsw page counters
Date: Mon, 14 Sep 2020 08:37:21 -0700 [thread overview]
Message-ID: <CALvZod6e3+F_YfEvTSJv015Z=BgHOMQPiYs0Kg9SMRPMHjJsFw@mail.gmail.com> (raw)
In-Reply-To: <20200914024452.19167-4-longman@redhat.com>
On Sun, Sep 13, 2020 at 7:45 PM Waiman Long <longman@redhat.com> wrote:
>
> The swap page counter is v2 only while memsw is v1 only. As v1 and v2
> controllers cannot be active at the same time, there is no point to keep
> both swap and memsw page counters in mem_cgroup. The previous patch has
> made sure that memsw page counter is updated and accessed only when in
> v1 code paths. So it is now safe to alias the v1 memsw page counter to v2
> swap page counter. This saves 14 long's in the size of mem_cgroup. This
> is a saving of 112 bytes for 64-bit archs.
>
> While at it, also document which page counters are used in v1 and/or v2.
>
> Signed-off-by: Waiman Long <longman@redhat.com>
Reviewed-by: Shakeel Butt <shakeelb@google.com>
next prev parent reply other threads:[~2020-09-14 15:37 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-14 2:44 [PATCH v2 0/3] mm/memcg: Miscellaneous cleanups and streamlining Waiman Long
2020-09-14 2:44 ` [PATCH v2 1/3] mm/memcg: Clean up obsolete enum charge_type Waiman Long
2020-09-14 11:37 ` Michal Hocko
2020-09-14 2:44 ` [PATCH v2 2/3] mm/memcg: Simplify mem_cgroup_get_max() Waiman Long
2020-09-14 11:48 ` Michal Hocko
2020-09-14 13:51 ` Waiman Long
2020-09-14 21:29 ` Johannes Weiner
2020-09-14 21:32 ` Johannes Weiner
2020-09-14 2:44 ` [PATCH v2 3/3] mm/memcg: Unify swap and memsw page counters Waiman Long
2020-09-14 11:54 ` Michal Hocko
2020-09-14 15:37 ` Shakeel Butt [this message]
2020-09-14 14:19 ` [PATCH v3 2/3] mm/memcg: Simplify mem_cgroup_get_max() Waiman Long
2020-09-14 14:47 ` Michal Hocko
2020-09-14 14:58 ` Waiman Long
2020-09-14 15:09 ` [PATCH v4 " Waiman Long
2020-09-14 15:18 ` Michal Hocko
2020-09-14 15:36 ` Shakeel Butt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALvZod6e3+F_YfEvTSJv015Z=BgHOMQPiYs0Kg9SMRPMHjJsFw@mail.gmail.com' \
--to=shakeelb@google.com \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=chris@chrisdown.name \
--cc=guro@fb.com \
--cc=hannes@cmpxchg.org \
--cc=laoar.shao@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=longman@redhat.com \
--cc=mhocko@kernel.org \
--cc=tj@kernel.org \
--cc=vdavydov.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox