From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C561DC28D13 for ; Mon, 22 Aug 2022 04:59:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 526B1940008; Mon, 22 Aug 2022 00:59:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4D5EE940007; Mon, 22 Aug 2022 00:59:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 39E4A940008; Mon, 22 Aug 2022 00:59:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 2BD2B940007 for ; Mon, 22 Aug 2022 00:59:33 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 06778AB3C2 for ; Mon, 22 Aug 2022 04:59:33 +0000 (UTC) X-FDA: 79826025426.12.2CDB3FA Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) by imf29.hostedemail.com (Postfix) with ESMTP id 85D69120049 for ; Mon, 22 Aug 2022 04:59:32 +0000 (UTC) Received: by mail-pf1-f171.google.com with SMTP id y141so9250396pfb.7 for ; Sun, 21 Aug 2022 21:59:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=9XhZmihVWYtN8pqGhGwupTf+AWRqtf1YyaQ/pGiog9k=; b=e4g+T2mMYZZcLZKVuyYTBE7KioYD6BNBNG1cLqDFZ5B9t0E6FIRD5EvbyAzLTCr3kJ rA6ZK7oCz9GEATt82qpw+2JFjAHNx6MWzrOEJkCcglpPUJI6hS1usRrjSP0PtvLaklzt 2SWFQW3etXo3F8BRQXjkvsEAD1xWTy3389fS+y8cwwh/ZpGZYzfVQV4mAVDrVneI1RKY LqoHhaNoGRAKG4D6abLWZ4z6qaxhraGCM7tcAmHqKNXwMFf8R6WZS65/KM+mSpunicvW NoZagRqgMyd0mx1A/gtNa8G0tjAlwmRM7GukYQSHxRJh5NrCaUN7Ht0Ligb/wX1I4ajV MSHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=9XhZmihVWYtN8pqGhGwupTf+AWRqtf1YyaQ/pGiog9k=; b=dV2YSXxidszoMC090aR7MR6xhyJivkjSIy6JYL4iufFSwpPcZrTbFJf3CvnssDvA5e 1KeWs/O0ieHFJbYikZGa/Bpwj6UsO0eZzZyFzJbdZlpmHjAvfnbnBZSnzf0pExic9GVj b18etpQFq3yEUuUO/0ajAhWUAet42Qs1y/7RvOV6z2EjRBP7fg3sGShSHTIXukguRsr/ yvQ2mIOasN/7L5qEr/rhTvF+jNccjNGb+9LYKUAc5E9bgBupdK0zWk3on0a0jDWppM4U f0siSLaddpakdFcgzhjEgbDazzxzIXYMiiIbjGXmTDxPGaWd4ezy7xHaq+gvb3eP+762 Xbww== X-Gm-Message-State: ACgBeo386pQQVmMoMFf4MB30tMcbZsL2xRH17T7A8OaPnCMVTXyp35F1 Tz46ckoPZgl+Do0EC/UlD0OLAPWloqQdIjvhs09tvA== X-Google-Smtp-Source: AA6agR4/1s7y++qNsA2/cfFgEIhAK4Q20RaQ1xUDhpnZDmYg93tgbnj5pntFlvFsEA9PvT9gkP9gZgjLoqCg32dK4EA= X-Received: by 2002:a62:6497:0:b0:52e:e0cd:1963 with SMTP id y145-20020a626497000000b0052ee0cd1963mr19195169pfb.58.1661144371422; Sun, 21 Aug 2022 21:59:31 -0700 (PDT) MIME-Version: 1.0 References: <20220822001737.4120417-1-shakeelb@google.com> <20220822001737.4120417-3-shakeelb@google.com> In-Reply-To: From: Shakeel Butt Date: Sun, 21 Aug 2022 21:59:20 -0700 Message-ID: Subject: Re: [PATCH 2/3] mm: page_counter: rearrange struct page_counter fields To: Feng Tang Cc: Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , "Michal Koutn??" , Eric Dumazet , Soheil Hassas Yeganeh , "Sang, Oliver" , Andrew Morton , "lkp@lists.01.org" , "cgroups@vger.kernel.org" , "linux-mm@kvack.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=e4g+T2mM; spf=pass (imf29.hostedemail.com: domain of shakeelb@google.com designates 209.85.210.171 as permitted sender) smtp.mailfrom=shakeelb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1661144372; a=rsa-sha256; cv=none; b=RN0IV/3o3vEBAPl14bcrOaEH5SToxdzxlccU60XQa60qmFT0rtUjyU5hmEa3lTljJvjDNt 1FIKmrk4uBnSbRSNL0NWnjYQXvHhGynsZUQsHhSC5DU6XG14cAOvnqU9S5Hcy5mUehHI3E T2pvcMCRer1ZY7B+AX+CctZAuhJTgoo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661144372; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9XhZmihVWYtN8pqGhGwupTf+AWRqtf1YyaQ/pGiog9k=; b=C11JMDPo+4np3o0ffKdhaA6Bua+xPo1CKsNSweVSAvsUw9EyB2NQBrzpF0o06B0ORDHlQM +gbGFV5ITVxVC4TL1aHiA38StwKnCTng0S78gva/mUbgNlMSSnetbISG7j34KJ5zOUyl1F BT/GckFFMQ/gFSw3dlONl9pi/qfUXWo= Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=e4g+T2mM; spf=pass (imf29.hostedemail.com: domain of shakeelb@google.com designates 209.85.210.171 as permitted sender) smtp.mailfrom=shakeelb@google.com; dmarc=pass (policy=reject) header.from=google.com X-Rspam-User: X-Rspamd-Server: rspam07 X-Stat-Signature: cc9pgmxowdhy84qwsmscp4jy8pzm1knw X-Rspamd-Queue-Id: 85D69120049 X-HE-Tag: 1661144372-80918 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Aug 21, 2022 at 7:12 PM Feng Tang wrote: > > On Mon, Aug 22, 2022 at 08:17:36AM +0800, Shakeel Butt wrote: > > With memcg v2 enabled, memcg->memory.usage is a very hot member for > > the workloads doing memcg charging on multiple CPUs concurrently. > > Particularly the network intensive workloads. In addition, there is a > > false cache sharing between memory.usage and memory.high on the charge > > path. This patch moves the usage into a separate cacheline and move all > > the read most fields into separate cacheline. > > > > To evaluate the impact of this optimization, on a 72 CPUs machine, we > > ran the following workload in a three level of cgroup hierarchy with top > > level having min and low setup appropriately. More specifically > > memory.min equal to size of netperf binary and memory.low double of > > that. > > > > $ netserver -6 > > # 36 instances of netperf with following params > > $ netperf -6 -H ::1 -l 60 -t TCP_SENDFILE -- -m 10K > > > > Results (average throughput of netperf): > > Without (6.0-rc1) 10482.7 Mbps > > With patch 12413.7 Mbps (18.4% improvement) > > > > With the patch, the throughput improved by 18.4%. > > > > One side-effect of this patch is the increase in the size of struct > > mem_cgroup. However for the performance improvement, this additional > > size is worth it. In addition there are opportunities to reduce the size > > of struct mem_cgroup like deprecation of kmem and tcpmem page counters > > and better packing. > > > > Signed-off-by: Shakeel Butt > > Reported-by: kernel test robot > > Looks good to me, with one nit below. > > Reviewed-by: Feng Tang Thanks. > > > --- > > include/linux/page_counter.h | 34 +++++++++++++++++++++++----------- > > 1 file changed, 23 insertions(+), 11 deletions(-) > > > > diff --git a/include/linux/page_counter.h b/include/linux/page_counter.h > > index 679591301994..8ce99bde645f 100644 > > --- a/include/linux/page_counter.h > > +++ b/include/linux/page_counter.h > > @@ -3,15 +3,27 @@ > > #define _LINUX_PAGE_COUNTER_H > > > > #include > > +#include > > #include > > #include > > > > +#if defined(CONFIG_SMP) > > +struct pc_padding { > > + char x[0]; > > +} ____cacheline_internodealigned_in_smp; > > +#define PC_PADDING(name) struct pc_padding name > > +#else > > +#define PC_PADDING(name) > > +#endif > > There are 2 similar padding definitions in mmzone.h and memcontrol.h: > > struct memcg_padding { > char x[0]; > } ____cacheline_internodealigned_in_smp; > #define MEMCG_PADDING(name) struct memcg_padding name > > struct zone_padding { > char x[0]; > } ____cacheline_internodealigned_in_smp; > #define ZONE_PADDING(name) struct zone_padding name; > > Maybe we can generalize them, and lift it into include/cache.h? so > that more places can reuse it in future. > This makes sense but let me do that in a separate patch.