From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12EE5CDB47E for ; Thu, 12 Oct 2023 21:39:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5FDB78D0012; Thu, 12 Oct 2023 17:39:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5AE3C8D0002; Thu, 12 Oct 2023 17:39:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 44E578D0012; Thu, 12 Oct 2023 17:39:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 32F588D0002 for ; Thu, 12 Oct 2023 17:39:13 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id E99EB120945 for ; Thu, 12 Oct 2023 21:39:12 +0000 (UTC) X-FDA: 81338125344.24.FF1501E Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) by imf04.hostedemail.com (Postfix) with ESMTP id 305E34001A for ; Thu, 12 Oct 2023 21:39:10 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=Nvn6pB7M; spf=pass (imf04.hostedemail.com: domain of shakeelb@google.com designates 209.85.214.181 as permitted sender) smtp.mailfrom=shakeelb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1697146751; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=yZaBwnc9uNu74MX7ZLYzqaku34OafJp0HOL1x0Q9+w4=; b=xVtSfd/xxCpbMRmm9nYDkEHInWI3+ChPQN8Aw4+l53y9HAQIMaHhnIr0hmLMkpBzeOLJ93 bExUvOXn0HCQJie4ux0vxQu3GiLB4iONxN0DUBO2w2y94+hkhLGZqxLwqI3UDeCGLB2fIp s45JgbRaw0mmz1Y7R/2gftfsu0uoiug= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1697146751; a=rsa-sha256; cv=none; b=6z4XdfiNBDkWxxR8VWyk+NFQg43Hnj8lZZop1w0/wsiv8WGsTFKP4IRDYiCDDDJ0DqhH5X jPKDPrFBUuvcUJP/xKMRgjPN+q+1zhYpANk92XU+QXvAm2FjX6rTwtuxxafJYamZWcp/sH U8UYp/aEEDq+8e1Qvrm6NmzcFy8xiTo= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=Nvn6pB7M; spf=pass (imf04.hostedemail.com: domain of shakeelb@google.com designates 209.85.214.181 as permitted sender) smtp.mailfrom=shakeelb@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-1c9b70b9671so28065ad.1 for ; Thu, 12 Oct 2023 14:39:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1697146750; x=1697751550; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=yZaBwnc9uNu74MX7ZLYzqaku34OafJp0HOL1x0Q9+w4=; b=Nvn6pB7Ms7te4wt+ijqaJ4n6x3ivooup7mUznCiTeIfVALSWLEo1JqAiWK9YmwO6k9 fCGQQMxxCIVJz4c7MjLcHEo3jvpXOIpRcrwkBoXEXIvpu4qzpGTR7hQcTnGzUvublQeP NObu1lrN68byJhnA9R6XZdW1+2wP+otq5wLpwQCxTRq1K5rTiHAb93pdw9/x3wKqSyz2 3IB5TLMLXwodtYV5C8r8cYWCvAYNo07VktBoN6VQJoi80m0FEvFa2BncsBnz9GC5MnWp 1vX0uJNpPsBmyiEOWje0v6CFdI4ysoVzqPdjuuRZgLf7FHsrwraHUiPExXJnRUc2fzz0 SG1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697146750; x=1697751550; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yZaBwnc9uNu74MX7ZLYzqaku34OafJp0HOL1x0Q9+w4=; b=gQgGXyr14USi46ahiiWINFweqoKKS5wdY6HfH7L/YqQG2tuCBsXm42hMCw4tVrEt0i soQsnDcDq/zMrYCtF1jYTl42D7Aa67qwOpMhaFJR6L8krWERnpYRUyMIneS7ezsMzx0Y 2L7l6B2KaWICL2sNUBOFDxUNYOM/9ls95q66jDoSOuI+4ytA+Pm1YqJpnIIigY0tmmwU q4Ork1hjkbgarlT86MPDKTvRQn0aNqD5rdzxjKbn2l/0zmTvwahOyp6w/7NHlpADpeqS lvnvV/h17oFyaAiVti+cbNbo8o9J47fH0tszHVVnh+UtWlExYUQd4lpRwGO9PYwYLyJT nbCQ== X-Gm-Message-State: AOJu0Ywrt6RDE/TsEEfpJ2IVF7I/TybyDg0IgchZlYEGvX08QbR9i9nw rjsSMpAb2LcPBZo8fNKYZoglUWuwk+R9TNZXf72/ww== X-Google-Smtp-Source: AGHT+IHYfc8IcgbTLPAkxELNwiOXnqgBWr+m3vbfGn3tda4JkEDig7mFMjwz2dSvHJZSuXgEFJjYQPqFixYh0QCwwag= X-Received: by 2002:a17:903:40c1:b0:1b8:9551:de55 with SMTP id t1-20020a17090340c100b001b89551de55mr70184pld.26.1697146749794; Thu, 12 Oct 2023 14:39:09 -0700 (PDT) MIME-Version: 1.0 References: <20231010032117.1577496-1-yosryahmed@google.com> <20231010032117.1577496-4-yosryahmed@google.com> <20231011003646.dt5rlqmnq6ybrlnd@google.com> In-Reply-To: From: Shakeel Butt Date: Thu, 12 Oct 2023 14:38:58 -0700 Message-ID: Subject: Re: [PATCH v2 3/5] mm: memcg: make stats flushing threshold per-memcg To: Yosry Ahmed , michael@phoronix.com, Feng Tang , kernel test robot Cc: Andrew Morton , Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , Ivan Babrou , Tejun Heo , =?UTF-8?Q?Michal_Koutn=C3=BD?= , Waiman Long , kernel-team@cloudflare.com, Wei Xu , Greg Thelen , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 305E34001A X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: eb76yreeornzw3nnzyrggws8zoz1rgzg X-HE-Tag: 1697146750-451104 X-HE-Meta: U2FsdGVkX1+1avY5efLv6s78m4W/Lxa4zXLzlSo2uuyULnN9KcXGUDUGSNW+oTihciVXWqUrbq1zx/Lc8mmGQ4kL0BHC042mR4jjE4EDbmBuTXVIc7eXrtgg7dQEsT5wAvu0jy7IgkM9aBzYFKZb9R4Q+FAHxeXuLKqSdK9bcH/lF+CoaD5vbACWCqGyCSNpe4VcPgvIcpO3RI/dps4+vXEgj52RfItZ5KfRGD4IqW/4vQT7eOS3YYviaU7KccVOZ96g9qQs5uOUGnXo7WlXMr6+taaIce/za+zCZNJsEd9UvSABQTNlcdOzMzTWO+sQZm7ghr+rx3yeDa+db8ihtsUjr0yLMao9FCxKGYKWjZzDPc4Ht013Q4DkI3zwNviIk8nBFYdZrIN0PQ6ydOmJ/jOrHxETecPpt4j5xDl147BhsMzxvEdhH1lR49Wvs1KZRcJD4xt6mOSWhFNivkA9YMgNv/xtGyiOYft+Y1Ua1dt5mkrCATkvtDYqSSqcg8ekuuuY8N0e4t9q0gf6MYVK+ZnuybVlzzkoCBqwqlREIUy6LQ9Bcjqd/G5v/u/t6rBMd1ZzE68anisGxGQDl2d0bWVfEXTtnzpzFO6MxvkT85funFBdNXhHutnBzv113KWaD1Y0yzCuUizc+nkFWvSlzevlgUeO7fmo0aAOuLfk9RKmVzwu0HKguTuUodu0UDa3PQRj/TwjylvJowALuIKX8LIrXU500DDkTB9GI9/53yM9pzFxnqQM/yag7Vn9XVBXQjluKIFoOWvM0s4pE0tyXzxhyj5qdJCC02wMwFpPiGe/FuYHl1w9zMwP3vQtuqxMPO7pBZ4+zEjglGO39GHAiS1E82hLSkO0lYoS38ci7xpRph6thzRtFm69UH0J7AtLMbP7d/iR7/XW8WzkTXJBxKdNR4Mt9xcUJjk+FNE/r4oj/hJfh6QzlkFe6Tgz2y9AA/EUUXNqmFGjxfc7jNR zp/l9+7X Bj9XO4+kM3cZD1BJ5T0aNPgk0tlug6EjfEilnO2gxJNHz3yC9rzgwurTkEwRAVxnliNS0xf4HPqgZQ9sgy7pbGZsQRSfEw42penoszaBIPdaoIZ+IQnyvHMiPSUMBUmlKoHrNlsbPKXrtFSETejsnrD2oazUI8C1pjMnh7MdWLJioLdC6LpdIZ742W4bC+jOYslrpCTdIEPpI7f6pckbo4i75yo9HIJRu17z/dyiz33INtoTzSrv+oTpDEUtmT2YV9MdY3GMz1lyVyOS8BZpbW0Vxt+oiLpik/IX36LtYQ1HLx1Owjl7xQRkf8w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.008270, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Oct 12, 2023 at 2:20=E2=80=AFPM Yosry Ahmed = wrote: > [...] > > > > Yes this looks better. I think we should also ask intel perf and > > phoronix folks to run their benchmarks as well (but no need to block > > on them). > > Anything I need to do for this to happen? (I thought such testing is > already done on linux-next) Just Cced the relevant folks. Michael, Oliver & Feng, if you have some time/resource available, please do trigger your performance benchmarks on the following series (but nothing urgent): https://lore.kernel.org/all/20231010032117.1577496-1-yosryahmed@google.com/ > > Also, any further comments on the patch (or the series in general)? If > not, I can send a new commit message for this patch in-place. Sorry, I haven't taken a look yet but will try in a week or so.