From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B142AC433EF for ; Wed, 13 Oct 2021 22:26:25 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5176061130 for ; Wed, 13 Oct 2021 22:26:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 5176061130 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id B82CA6B0071; Wed, 13 Oct 2021 18:26:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B3217940007; Wed, 13 Oct 2021 18:26:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A21796B0073; Wed, 13 Oct 2021 18:26:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0057.hostedemail.com [216.40.44.57]) by kanga.kvack.org (Postfix) with ESMTP id 8EA3D6B0071 for ; Wed, 13 Oct 2021 18:26:24 -0400 (EDT) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 51C4D2D389 for ; Wed, 13 Oct 2021 22:26:24 +0000 (UTC) X-FDA: 78692849088.24.C2C8418 Received: from mail-yb1-f169.google.com (mail-yb1-f169.google.com [209.85.219.169]) by imf29.hostedemail.com (Postfix) with ESMTP id 225DA900024B for ; Wed, 13 Oct 2021 22:26:23 +0000 (UTC) Received: by mail-yb1-f169.google.com with SMTP id r1so9996384ybo.10 for ; Wed, 13 Oct 2021 15:26:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=I9ddwzDwjBRvjNSeQZZTZvJ2NfxDHWqyayJGGbMH5Mc=; b=g+egBO0u1JLmFD3nechTRv3dWXbR4MmZz3U4Tu2XhQNHpDt5Cp/41Rr8/9empDSbjJ LwTyaSGs2kCyIlQ5cWGxt4GwyEtijW3UuCi8ykujsxgRizKFdNnZkilB7Ux19W3z4gXk yoW9Gn8FJ9q4h59ecIWXUCmwt2E6skuJhARdodYpzxetPL8QM0/A9+30BzxUhSx2SImy /QlM39coka72/w8/hbx03q7tBa6oCSLHFOgWh/TgBgG+jiYkM9kqRQIq0NGkPEmH0gS+ fEs7UZWcNO+b4yX+wQcCTrC24kNsN3iEVgn44C5l5Pdsw/0kIgw1/4OBAs7tuax/gFPm tt3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=I9ddwzDwjBRvjNSeQZZTZvJ2NfxDHWqyayJGGbMH5Mc=; b=Q3qmrsRNrPOZIT6m1uBGjM4h69wkfkHyJmf0Q9LO50UmSeHd1CZ4UW8sJvvWDrvUVP 1359rk7ozlT/MOdNhLhHuQ/30ulmRjlZjlYROoEsCOMOXfcV9ZA+eqehe+7imlYgdQgS mdRTQOxja2o1F8nbMdPQHZcfnSRHwrZkaB71kk6+MZR75X9aJR0yu2kmnmzk8uhz7+ap xPHFUG5KTmLZbf0v2piG0AfhggyPf+d0Xsp/e2wRUsk2VF3lY6IkBqq6CyTGQVTZiW7+ aLj/2T7z6xirQN+vFYsqCXolfOYSV9ulZtpvHM7SsakpbaDvx5XYbIcxwXbomgcUbcDl DqYQ== X-Gm-Message-State: AOAM532/MKj/J29VL7PnuGkLHoLYYAuAGuJqyV+rr/csyPUxeb0Cx4qk R4QTSfXaasfmQZvUAcs/gEik4NsO3IQYcgnZ9Lptuw== X-Google-Smtp-Source: ABdhPJyfto3QlbGgFWppfUHSUw8DtFI2urBmgJXpBxQvxuI0GnqeXTrAMQMhYA4YvMxA1Mt8j8zni80xu6X3kvlKnyk= X-Received: by 2002:a25:1c08:: with SMTP id c8mr2421015ybc.316.1634163983003; Wed, 13 Oct 2021 15:26:23 -0700 (PDT) MIME-Version: 1.0 References: <20211013194338.1804247-1-shakeelb@google.com> In-Reply-To: From: Shakeel Butt Date: Wed, 13 Oct 2021 15:26:11 -0700 Message-ID: Subject: Re: [PATCH] memcg: page_alloc: skip bulk allocator for __GFP_ACCOUNT To: Roman Gushchin Cc: Johannes Weiner , Michal Hocko , Mel Gorman , Uladzislau Rezki , Vasily Averin , Andrew Morton , Cgroups , Linux MM , LKML Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 225DA900024B X-Stat-Signature: jmf4d1bjkm95zeybrq7o6m9wznah7k9q Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=g+egBO0u; spf=pass (imf29.hostedemail.com: domain of shakeelb@google.com designates 209.85.219.169 as permitted sender) smtp.mailfrom=shakeelb@google.com; dmarc=pass (policy=reject) header.from=google.com X-HE-Tag: 1634163983-111262 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Oct 13, 2021 at 3:03 PM Roman Gushchin wrote: > > On Wed, Oct 13, 2021 at 12:43:38PM -0700, Shakeel Butt wrote: > > The commit 5c1f4e690eec ("mm/vmalloc: switch to bulk allocator in > > __vmalloc_area_node()") switched to bulk page allocator for order 0 > > allocation backing vmalloc. However bulk page allocator does not support > > __GFP_ACCOUNT allocations and there are several users of > > kvmalloc(__GFP_ACCOUNT). > > > > For now make __GFP_ACCOUNT allocations bypass bulk page allocator. In > > future if there is workload that can be significantly improved with the > > bulk page allocator with __GFP_ACCCOUNT support, we can revisit the > > decision. > > > > Fixes: 5c1f4e690eec ("mm/vmalloc: switch to bulk allocator in __vmalloc_area_node()") > > Signed-off-by: Shakeel Butt > > --- > > mm/page_alloc.c | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > > index 668edb16446a..b3acad4615d3 100644 > > --- a/mm/page_alloc.c > > +++ b/mm/page_alloc.c > > @@ -5215,6 +5215,10 @@ unsigned long __alloc_pages_bulk(gfp_t gfp, int preferred_nid, > > unsigned int alloc_flags = ALLOC_WMARK_LOW; > > int nr_populated = 0, nr_account = 0; > > > > + /* Bulk allocator does not support memcg accounting. */ > > + if (unlikely(gfp & __GFP_ACCOUNT)) > > + goto out; > > + > > Isn't it a bit too aggressive? > > How about > if (WARN_ON_ONCE(gfp & __GFP_ACCOUNT)) We actually know that kvmalloc(__GFP_ACCOUNT) users exist and can trigger bulk page allocator through vmalloc, so I don't think the warning would be any helpful. > gfp &= ~__GFP_ACCOUNT; Bulk allocator is best effort, so callers have adequate fallbacks. Transparently disabling accounting would be unexpected.