From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 608C5C433E6 for ; Mon, 31 Aug 2020 14:45:59 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1F3CF20719 for ; Mon, 31 Aug 2020 14:45:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="M1a3QzyL" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1F3CF20719 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B2C8B6B005C; Mon, 31 Aug 2020 10:45:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AB41C6B0062; Mon, 31 Aug 2020 10:45:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9A28E6B0068; Mon, 31 Aug 2020 10:45:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0044.hostedemail.com [216.40.44.44]) by kanga.kvack.org (Postfix) with ESMTP id 7D38B6B005C for ; Mon, 31 Aug 2020 10:45:58 -0400 (EDT) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 33CCE362D for ; Mon, 31 Aug 2020 14:45:58 +0000 (UTC) X-FDA: 77211138396.07.bone72_340965627090 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin07.hostedemail.com (Postfix) with ESMTP id 0493E1803F9A7 for ; Mon, 31 Aug 2020 14:45:57 +0000 (UTC) X-HE-Tag: bone72_340965627090 X-Filterd-Recvd-Size: 3619 Received: from mail-lj1-f193.google.com (mail-lj1-f193.google.com [209.85.208.193]) by imf12.hostedemail.com (Postfix) with ESMTP for ; Mon, 31 Aug 2020 14:45:57 +0000 (UTC) Received: by mail-lj1-f193.google.com with SMTP id r13so7052128ljm.0 for ; Mon, 31 Aug 2020 07:45:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=oiXcm4u36vD6BWyxr4Psu6FC09upa/dV/NKGEiJVOTg=; b=M1a3QzyLYSn+zE0HTt5zRzioXgASrO4Sf7UZjrgCUjtgHLL60fZixK7uxwhWImpBNP YIxSDm9DBW1tjLB4iNyGRYx6VSi7qetHjnf0n+oiwZbKn0WTA6Xhth9svZQO/Dihd4ih YojnXuoph1S2i+GG4M1m1uRnyF5RMDV6ZbFjPaaOi5jC2iC3NbFbhKrLXSEvM/WoizmE pj/rA8c6owsHeCgyFKZUrVDtkUzqZ3lqW+LpdGrkCAsSVxN2Pm4+NE8qx/pDAgaS3pZm PVxVxTbZSVqqK7ys1LmKh7nLTao8pfGFc8Mu+c1d99MMl1ey3q8UnN9GY8tpm6Py7Xix 2pVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=oiXcm4u36vD6BWyxr4Psu6FC09upa/dV/NKGEiJVOTg=; b=X0qSKqspKgOTG7IFewQVs94y5LmBcxgPEMCF+YJnJsDLWtZGw1Na/9iReEWsubBweR xgd9rzFPWwhWeFJxq4UWSZEg7a7iruEXLxP4aYc5O7JCxyzF2vw/kqoeA3tYRC3DKH22 b+zxVKj3ikrbYp42X/FL9TPvIWxDFCFCQr190iMQyQW7pEM/gR2WHe8EpOb0ED99ifc9 1Ri+REB4xx7xOM726qnOiLWwEsGvDv0relP/vXXEy6py4mhcHfOLmBoKXUeLegoCgX/w MoKt+wy+FtBVqSyRDc/xALUZac97X2S9H5OeMltZY5VbLKFqxZaBLonOOayNzKcVi4wA /jRg== X-Gm-Message-State: AOAM532fZHerLCwOITUpRRIx1SZHSTya1NY8vnYeKoeGlF+SJ/DxCYSE xEx36S6Jh1hDU0Y33bM1B1JEwlMHK2ufdIv+mIVxXA== X-Google-Smtp-Source: ABdhPJxP8gyhsjqUA4CRMZqi/U2msM03KKKj3jptfQij8wgITLblI2ohbPI3RD9nsxY5gUoMWJ0MFH2ltHt/S4kWxBg= X-Received: by 2002:a2e:9d8e:: with SMTP id c14mr873904ljj.332.1598885155998; Mon, 31 Aug 2020 07:45:55 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Shakeel Butt Date: Mon, 31 Aug 2020 07:45:44 -0700 Message-ID: Subject: Re: [PATCH 5/5] mlock: fix unevictable_pgs event counts on THP To: Hugh Dickins Cc: Andrew Morton , Alex Shi , Johannes Weiner , Michal Hocko , Mike Kravetz , Matthew Wilcox , Qian Cai , LKML , Linux MM Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 0493E1803F9A7 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam04 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000005, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Aug 30, 2020 at 2:09 PM Hugh Dickins wrote: > > 5.8 commit 5d91f31faf8e ("mm: swap: fix vmstats for huge page") has > established that vm_events should count every subpage of a THP, > including unevictable_pgs_culled and unevictable_pgs_rescued; but > lru_cache_add_inactive_or_unevictable() was not doing so for > unevictable_pgs_mlocked, and mm/mlock.c was not doing so for > unevictable_pgs mlocked, munlocked, cleared and stranded. > > Fix them; but THPs don't go the pagevec way in mlock.c, > so no fixes needed on that path. > > Fixes: 5d91f31faf8e ("mm: swap: fix vmstats for huge page") > Signed-off-by: Hugh Dickins Reviewed-by: Shakeel Butt