From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66034C433E0 for ; Sat, 6 Feb 2021 01:00:23 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D2FE764E2A for ; Sat, 6 Feb 2021 01:00:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D2FE764E2A Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 1A5976B0006; Fri, 5 Feb 2021 20:00:22 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 12DB16B006C; Fri, 5 Feb 2021 20:00:22 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F37D96B006E; Fri, 5 Feb 2021 20:00:21 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0143.hostedemail.com [216.40.44.143]) by kanga.kvack.org (Postfix) with ESMTP id DB0F66B0006 for ; Fri, 5 Feb 2021 20:00:21 -0500 (EST) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 9EFAC181AEF1A for ; Sat, 6 Feb 2021 01:00:21 +0000 (UTC) X-FDA: 77786037042.10.team85_30152bd275e9 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin10.hostedemail.com (Postfix) with ESMTP id 6F42616A4A4 for ; Sat, 6 Feb 2021 01:00:21 +0000 (UTC) X-HE-Tag: team85_30152bd275e9 X-Filterd-Recvd-Size: 3331 Received: from mail-lf1-f51.google.com (mail-lf1-f51.google.com [209.85.167.51]) by imf30.hostedemail.com (Postfix) with ESMTP for ; Sat, 6 Feb 2021 01:00:20 +0000 (UTC) Received: by mail-lf1-f51.google.com with SMTP id v5so10525764lft.13 for ; Fri, 05 Feb 2021 17:00:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Fb95oN2pGx3nj+Eb9wyweMoS+j1I5Uh71GzG+Sz5oEM=; b=rmxoZUiSYkE8WfcgoGpH7IesJ19msP/HBOrSblBil1jDywKKNf0JAOM/ZXWZUbHylE ZC3ZwMo8GNEAQB5DwMZpU2qre6bGCokTjqEtWwoGcnoQbvNYKFvMNBxN7n5bth2tqddl jmseJ5ITj1AUUqey4rvVJJY1pFpw/ZMB+uIMqEwX1S0n2zl3xv9Z4/ve3yPhU7VwNabe 6zD1LGmW7sV8jwByfF3vS8tVg14Cx2jqVW9wQCcQWsHcvraZsvbtriBpxYOr89geqVgw S5rAqh/fXXn7MLD7GG1OqbukEsSXVqs+Y9uQyfp2tZiDJ0cl9RhZ5jngWRQErTthIzRj q/UA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Fb95oN2pGx3nj+Eb9wyweMoS+j1I5Uh71GzG+Sz5oEM=; b=bfsreiQlGcwJpTrsHmuWfeBRyJtMsCe0H0OFKghs8dusW5jC1z/y3pvlaKwjYApc7H VX6XKxgVi3Q3EZFaKaFE3Kl2dq3KSKxH/fL2i22NPZpxqKHa033X6NXQ9/8SWrcEuuTr tzE1wrQggD+oqEuDGzIDmw8S3J4oIpXpoETE7vELFm86QdOaHUGiP1qme7V7u/vNB5qD hdF2DfOdklpUx+I1r50tJz66Fc1yqE24O7wMVgMf0MEne137sHbpdopA/sc/LtF65fZx 64xS6AnED9XWo9ijpymubZE8Ly4o3Bo2bduumqlYSz09Y32+NK1ArUXq36pKyUzpILbV HuEg== X-Gm-Message-State: AOAM532JhuogxtIiotASy5qdZdyEFPHVSIhALGchNQ368zpgL6mWp1GI gq8ygLAu95myw3iyiVD+3ke/iMxsiBDhd5QeTBV4Dw== X-Google-Smtp-Source: ABdhPJxO5T6L8jGlLaSb3hN78KcIBodI1XXIxksiCZSZKhqYtKXh+IajAf/ZWDzbObIORdgIN5KK24RJzV+6a6SkJlI= X-Received: by 2002:a2e:8541:: with SMTP id u1mr4306946ljj.0.1612573219209; Fri, 05 Feb 2021 17:00:19 -0800 (PST) MIME-Version: 1.0 References: <20210204163055.56080-1-songmuchun@bytedance.com> In-Reply-To: <20210204163055.56080-1-songmuchun@bytedance.com> From: Shakeel Butt Date: Fri, 5 Feb 2021 17:00:07 -0800 Message-ID: Subject: Re: [PATCH v2] mm: memcontrol: replace the loop with a list_for_each_entry() To: Muchun Song Cc: Johannes Weiner , Michal Hocko , Vladimir Davydov , Andrew Morton , Cgroups , Linux MM , LKML Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Feb 4, 2021 at 8:39 AM Muchun Song wrote: > > The rule of list walk has gone since: > > commit a9d5adeeb4b2 ("mm/memcontrol: allow to uncharge page without using page->lru field") > > So remove the strange comment and replace the loop with a > list_for_each_entry(). > > There is only one caller of the uncharge_list(). So just fold it into > mem_cgroup_uncharge_list() and remove it. > > Signed-off-by: Muchun Song Reviewed-by: Shakeel Butt