From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4478C433DB for ; Mon, 8 Mar 2021 06:49:23 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 605B6651EF for ; Mon, 8 Mar 2021 06:49:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 605B6651EF Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D55D98D0009; Mon, 8 Mar 2021 01:49:22 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D058B6B0096; Mon, 8 Mar 2021 01:49:22 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BA5068D0009; Mon, 8 Mar 2021 01:49:22 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0095.hostedemail.com [216.40.44.95]) by kanga.kvack.org (Postfix) with ESMTP id 9CF7B6B0095 for ; Mon, 8 Mar 2021 01:49:22 -0500 (EST) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 54F6612F4 for ; Mon, 8 Mar 2021 06:49:22 +0000 (UTC) X-FDA: 77895780564.24.A084786 Received: from mail-lf1-f49.google.com (mail-lf1-f49.google.com [209.85.167.49]) by imf06.hostedemail.com (Postfix) with ESMTP id CA479C0001FA for ; Mon, 8 Mar 2021 06:49:21 +0000 (UTC) Received: by mail-lf1-f49.google.com with SMTP id x4so12592213lfu.7 for ; Sun, 07 Mar 2021 22:49:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=uoC8QNlvTR8++BIKTNy/5o3MzhxCe5WO+3UpJfEpK6c=; b=LGL8vyV10hWlr4AyKOFUhQb+foDReKdTXstB87PngQ/jmO1URKyMs5x5mPH6Glxxwi OhtezJgG5daQPD776QholBRx01BRhXwkd45SpxvtQP2Je+aquHxwr0rF1Euk8JnaT6oD lk8Jr/hTZQXXS3VAUsPy1Q+3oTbjSaSfG7rHWXgYob5wGa2e4seMDNlApIUHDbrq7OGh lkYFxTxe6QFp4WlRiOkkOV1Xbi0N4ZsGTfPu7Vie0rJ7JJ3jVibkF0H81k1CewVGhIRz cLKR8xFauyk+yQwHcRx5HcLegtdH+fVviAATzWl9fEqcMOAh1OLcc00BDy2QNjb2prd7 4mgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=uoC8QNlvTR8++BIKTNy/5o3MzhxCe5WO+3UpJfEpK6c=; b=aUfI0RqKAdZCNmlw7xUwF+1Rn/It/4d5iee6drpiTNEzgWs1iiuTCYXPZzCAJL+alI 66fjRQTLNQmZN858hIZknHmIWjzQlqHfYL8NS8oyf43R0sKl2mlldxyUiN5yuu2Ax0Ha zhaor2XE92EctOit0YSxaG205UQihqVkTY46C9l8mA9RB11zBZaeokkaT/H4rGc9Op3k P81P7BxGMl+Rr4Pkx+5qe2/D0njzYN+ZXyogw0I3ngBVphTvyTBtDIY07IP8OfULqmCq dtu88TJsMH4ZYkDOUR2y9UDuVFEyOINn7BY/Izv2fMsOKQtpndCf+YE0tXWrN4m18xJv 8MbQ== X-Gm-Message-State: AOAM530/n0MDfKlWCovg5iD8CfUM2YrTH+qv4aTQDShojxoy+A0yy2bM 7dAqFl4vzYv3NB4gGQfQH0ZRkgph6VxUIMvnLCbT1A== X-Google-Smtp-Source: ABdhPJwrFCP3Kf8tAv8sF2qsw0T7P32CghJc78SV62DPfTmDQGwTdXaQMAJEUDcQ0xLaRxGCHZPg76M8GxxY1dYAQwo= X-Received: by 2002:a19:c14a:: with SMTP id r71mr13425508lff.358.1615186160205; Sun, 07 Mar 2021 22:49:20 -0800 (PST) MIME-Version: 1.0 References: <20210217001322.2226796-1-shy828301@gmail.com> <20210217001322.2226796-5-shy828301@gmail.com> In-Reply-To: <20210217001322.2226796-5-shy828301@gmail.com> From: Shakeel Butt Date: Sun, 7 Mar 2021 22:49:06 -0800 Message-ID: Subject: Re: [v8 PATCH 04/13] mm: vmscan: remove memcg_shrinker_map_size To: Yang Shi Cc: Roman Gushchin , Kirill Tkhai , Vlastimil Babka , Dave Chinner , Johannes Weiner , Michal Hocko , Andrew Morton , Linux MM , linux-fsdevel , LKML Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: CA479C0001FA X-Stat-Signature: 5zcnocbo3dijywdec1boyuybah8kbsy6 Received-SPF: none (google.com>: No applicable sender policy available) receiver=imf06; identity=mailfrom; envelope-from=""; helo=mail-lf1-f49.google.com; client-ip=209.85.167.49 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1615186161-837496 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Feb 16, 2021 at 4:13 PM Yang Shi wrote: > > Both memcg_shrinker_map_size and shrinker_nr_max is maintained, but actually the > map size can be calculated via shrinker_nr_max, so it seems unnecessary to keep both. > Remove memcg_shrinker_map_size since shrinker_nr_max is also used by iterating the > bit map. > > Acked-by: Kirill Tkhai > Acked-by: Roman Gushchin > Acked-by: Vlastimil Babka > Signed-off-by: Yang Shi Reviewed-by: Shakeel Butt