From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65AB2C4167B for ; Tue, 12 Dec 2023 19:11:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B648D6B0080; Tue, 12 Dec 2023 14:11:51 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B14326B031B; Tue, 12 Dec 2023 14:11:51 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9DB786B031E; Tue, 12 Dec 2023 14:11:51 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 8AA1A6B0080 for ; Tue, 12 Dec 2023 14:11:51 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 42702160A28 for ; Tue, 12 Dec 2023 19:11:51 +0000 (UTC) X-FDA: 81559110822.14.F33CFA8 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) by imf02.hostedemail.com (Postfix) with ESMTP id 7CADE80024 for ; Tue, 12 Dec 2023 19:11:48 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=Boh4umJx; spf=pass (imf02.hostedemail.com: domain of shakeelb@google.com designates 209.85.214.174 as permitted sender) smtp.mailfrom=shakeelb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702408308; a=rsa-sha256; cv=none; b=Mecz5/xxgkGaQ9I2E6yuMla0YBvSy0AnxkuhigclCpROuiy7uwiyBcAl5G45fXTSrGc9GT crWafpRqTAM80/0pLXgKZhgiFgsk6y87vcrV8MnbueMmCFj2tXuytB7Xf2ba8a3VrV4/9j 9BzX22CPDpgc/rgcXAxS59dI70sv4x0= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=Boh4umJx; spf=pass (imf02.hostedemail.com: domain of shakeelb@google.com designates 209.85.214.174 as permitted sender) smtp.mailfrom=shakeelb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702408308; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LIguWzkvYltOpnG/cXi7wP26kF3E2cDcptp5e/K12Jo=; b=5YcwI/NiOVMHLowwo9RgzT5isrbfqOgpTSS4K85HFbZoqZB8K/GFh0dos/oBrRjPiNdwsF uzNBOzcndBAN0uV4naOXNXy821ZNitNdhGdgBlHPKrr0okPdppSWleIi+oboxe0KmA3zRU uEo93RM0MxQK5nBCGDjKNUISdwFV9Ag= Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-1d08fba6a49so20395ad.1 for ; Tue, 12 Dec 2023 11:11:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1702408307; x=1703013107; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=LIguWzkvYltOpnG/cXi7wP26kF3E2cDcptp5e/K12Jo=; b=Boh4umJx4tfIIOrFWwb3aoQ66uPnKCwdyNx9C5vvvRbfWTyEbyqE+ynqWqY4ige0QS 59vtZRrgatK5tH9M6FRDtLtfasBi4HUmtiJuVO+pVattbhcAlUBbp1DiW3Yd67Nm54u/ 5CPZ0/rW9BPHuejSx+pEec7EpypzryfIopzLfoQCG9OeRKcu4gl4XblUNsA4P0TeIOog F6ExLIftX3455kB3nUlKzqC9mqgZG+xB8uDkWgiw8QN4e9b1ce2RjoB44lj5HZjLA+BY Nbmq0zFdneGZePLOQ2YFnFgh/dE1vuBhTm5lyzpPAWWSvo4FeMCYAicBFQNlFri37IQC byGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702408307; x=1703013107; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LIguWzkvYltOpnG/cXi7wP26kF3E2cDcptp5e/K12Jo=; b=iX+xA0r/cEi/bbxmtI30Swm6cvY4D8a9RogWpKP0jpSkuTJz9asmxcU+VJjMd/7FZ5 MMHJ+2oaI/oSPMwOtvirXhNtscMxPDCw6z802Wgt1KemjBADWpOKdysebZ+3NDBsyRNl LJwhatwkmsTtlc9TX2h1RVicy6N461LtvdEWvS6E5ZNsbKOdIANB2oh/CmlOoCn/lyHz Cd66SrF+pAPmZQ8wrSLj0P3zP2n4cwLojA2B4rlHlHEbbZSHXhZvtcDyD1WvkNnbDtyt rnjRaSCcVJJ60nUhUE2dd03eHrAQkloXR1A69Ske5H4rnsjdYuhyxsOyfXLrGuc6ool6 A7WQ== X-Gm-Message-State: AOJu0Yy+JD11U/qmHowTf536U+bZanFOEiZF875BNK4duxWaUQ6hjCTA HUP3RvO3UDZi6xe3JkzK3HGdkjM31MFuqkUfUOejYQ== X-Google-Smtp-Source: AGHT+IHt0Qmog3mUK5T+kUE0Q2Kof6YqrUXeTpM7Ux6Zk+sJp0dumG1J+s5VjauZ8OeIU0gS8MCxg1ZOOAnY4ZGrZCw= X-Received: by 2002:a17:902:dacb:b0:1cf:aa8f:56b3 with SMTP id q11-20020a170902dacb00b001cfaa8f56b3mr896582plx.24.1702408307029; Tue, 12 Dec 2023 11:11:47 -0800 (PST) MIME-Version: 1.0 References: <20231129032154.3710765-1-yosryahmed@google.com> <20231129032154.3710765-6-yosryahmed@google.com> <20231202083129.3pmds2cddy765szr@google.com> <20231204235856.k4izppfsrpg2rng7@google.com> <20231212104355.ba052748471e1e0ce5cc35a0@linux-foundation.org> In-Reply-To: <20231212104355.ba052748471e1e0ce5cc35a0@linux-foundation.org> From: Shakeel Butt Date: Tue, 12 Dec 2023 11:11:35 -0800 Message-ID: Subject: Re: [mm-unstable v4 5/5] mm: memcg: restore subtree stats flushing To: Andrew Morton Cc: Yosry Ahmed , Wei Xu , Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , Ivan Babrou , Tejun Heo , =?UTF-8?Q?Michal_Koutn=C3=BD?= , Waiman Long , kernel-team@cloudflare.com, Greg Thelen , Domenico Cerasuolo , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, Bagas Sanjaya Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 7CADE80024 X-Stat-Signature: 4hxnxr15ste3pugpadhh8u4n8k7ag1te X-Rspam-User: X-HE-Tag: 1702408308-333258 X-HE-Meta: U2FsdGVkX183k9NSlZl9RjzQo42wTsV7CyRybex0Yel+Ix7qq3fiFCbZwF6yl0kbuPxOkSDq9Y5x40BGOubD6N0RdVZinIznH+Gr2c613rS1pS/6h31OAN5N1JcK48+A6pA0rE65wET72XIJGdphMeZ4cwZyTtaZw+Rg/w/XFHMZb2j5NjVHUW6pmgr2B15zneNM3Yq/0AOZLYEkjejAbx8HFd9R6GV0bU+uXhaZDA7kMXnV9sZAZm78S2daT8g5x+TtBXSGfYxR6MydfU2t28lON1on1Q1YNWNjr/rE72xxUR5F4FUwiLDlXUEkgpmYjwmR+6oH1iWjOBWVSychb3k8KO04gGb8oTfoUOUXjW7PL0hFb9AoIy4XR4L797O2lJGyrZV9Tf6uJd7lEZPOkiv3sDLtYHOYGwqLP/zFmdxGqlRgyZzWoXtJbNCRfZ5Rvwd9AQrq9Ftcyv4AXb+zYTcUv+a9ybn2Xo+M1VzCQRkbqDrJx2YyWrH0U1B/6gGWO1YzaTXxrfMKDK3tNVwc33fqSSpwCR2V0HLGi3lh00amNFu44yMlQvphaKGKcpihhQnhufMKyLEib1JqNEucLXnGJkw8gopgrmQsQz9t9AxfFS81Vs7pxy8DqrF0FPJ38AWxv+4E4Q9DgTH1bIgDLTCrU2CwkR4YPlrz8Vu4RaYBQ5A8fiTaNnMsiENqBIg46oTzmHs5PIIKlJ+B/hHffBKIrmQ3r0cT7xTrqlcxUUoW3LwaUInrY3Bhd2EoNGRVt4VsmPoXtNTLpOYEgWO8Fp9NqJ/lTNykit0r/94BpzSesKpfsA+pUj8i83blR/3dxG0l41gfmme9pk5PJ/1O81QOqiEp2bVLrOGaoY4sLe/QotDCg7QSo/wSzEQx0hE21fDyExGtRK8lQWNmONiXh0WpugUbKV8VZ8iOenP8CmfX9kCIJpALYRrXF246/J6Ei5Gl4FQ1qJRrcXdo9Tx 2JXRzUN0 LnKmG7nObqDi7CMqFQAFHiMR5qOBpscCeU7GgGv8YSqWxE5g+2u1bJMU4AVL8nG0/vIBXIaQP060PP8pokiqSmCtOupvE3REsxNzbGgGDKQtG2ieLKyOGg9neS7KHPt+TZhExoWmQHODRQAzrH61KI/lA9zhvwQsDPvNEtKuRFueERokBNFFg2GOh+LIWm5DP8jJA6KGB5to0vO99qgKlJGQkKUFZ1urMDmSL1FupALTJdZiNXLtiXCb+tZCQyZzKL8Wtt3od8X781KG/a9nnVqbakWyw13X2F1Zz/cxlmBE2K5e3n/L1vNDfZw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000066, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Dec 12, 2023 at 10:43=E2=80=AFAM Andrew Morton wrote: > > On Mon, 4 Dec 2023 23:58:56 +0000 Shakeel Butt wrot= e: > > > On Mon, Dec 04, 2023 at 03:49:01PM -0800, Yosry Ahmed wrote: > > [...] > > > > > > From 19af26e01f93cbf0806d75a234b78e48c1ce9d80 Mon Sep 17 00:00:00 200= 1 > > > From: Yosry Ahmed > > > Date: Mon, 4 Dec 2023 23:43:29 +0000 > > > Subject: [PATCH] mm: memcg: remove stats flushing mutex > > > > > > The mutex was intended to make the waiters sleep instead of spin, and > > > such that we can check the update thresholds again after acquiring th= e > > > mutex. However, the mutex has a risk of priority inversion, especiall= y > > > since the underlying rstat lock can de dropped while the mutex is hel= d. > > > > > > Synthetic testing with high concurrency of flushers shows no > > > regressions without the mutex, so remove it. > > > > > > Suggested-by: Shakeel Butt > > > Signed-off-by: Yosry Ahmed > > > > Acked-by: Shakeel Butt > > > > I'd like to move this series into mm-stable soon. Are we all OK with tha= t? OK from me.