From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0BE56C77B75 for ; Tue, 9 May 2023 17:58:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5253C6B0071; Tue, 9 May 2023 13:58:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4D5206B0072; Tue, 9 May 2023 13:58:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3C4016B0074; Tue, 9 May 2023 13:58:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 3184E6B0071 for ; Tue, 9 May 2023 13:58:16 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id F22F6A02C8 for ; Tue, 9 May 2023 17:58:15 +0000 (UTC) X-FDA: 80771475750.17.A6C1168 Received: from mail-qt1-f173.google.com (mail-qt1-f173.google.com [209.85.160.173]) by imf08.hostedemail.com (Postfix) with ESMTP id 37BF6160015 for ; Tue, 9 May 2023 17:58:13 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=KgfWhPK3; spf=pass (imf08.hostedemail.com: domain of shakeelb@google.com designates 209.85.160.173 as permitted sender) smtp.mailfrom=shakeelb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1683655094; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vhZkJ8mwG4mA4GCg1/8ebcBN7nEL6s99qLu8EGL+6aM=; b=tNFKkTVW5Dst2zZ63GipAjUYBL+nkiKy22terxJJRNiQbZGGHJQu6dAmOhpOsf/7p36xqJ 3hpqDf3KlqYgsMTsL3CBnhLoK64O+wtzC2UffhcGkf3Ng8z2q4PU0WS/ExJITQFTHR3ZpP rQLZR+3FUgYzfLIwAQsbgwDvsF22Cq0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1683655094; a=rsa-sha256; cv=none; b=spK0q9NteysUl3NLExO/ydDOn4wHCKWa9pYfd1sXC6ngEk5UJxlHNKfB0uE7ofVzdrv07D VQR1z2u3v1aypUflfA+HJdvgU2cQnuCyJA9fiKSNiODcdWGenS98cDNdGTHYcxRKCD9dQq 94ABXeGIbzvpnTPy276OYuaIwOHVMqY= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=KgfWhPK3; spf=pass (imf08.hostedemail.com: domain of shakeelb@google.com designates 209.85.160.173 as permitted sender) smtp.mailfrom=shakeelb@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-qt1-f173.google.com with SMTP id d75a77b69052e-3f38a9918d1so220691cf.1 for ; Tue, 09 May 2023 10:58:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1683655093; x=1686247093; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=vhZkJ8mwG4mA4GCg1/8ebcBN7nEL6s99qLu8EGL+6aM=; b=KgfWhPK3zHiclIOgn2Kt/8GHAUxSexMKKgnsWOlc7aVOEV4EKytoa+H0EqUWWLumnT 1dRSubDaBeFdDFq5mk6LysSPbERN+lyQPD6IuvnSJnePeVD1mQLJ88Za+dm8IVENdkjb WQRDUXrSe8O8ohUX6luTRGj+g5E9a9OHHVag8TjgszPmoF94rDtT+dNxqBrAns28z89w V5qmy+0WHT/mBZruiHDgKsBO1vYTxuKtWFMvj3ulbgcdd/+mfQsRI7sweMdZHiLG7Cab FDLGqCHgc/hpMLWaXSeZ00gzyUNtkn9ZNZnNo5zXiUsxk7Epss7emB+77WZKRnXVFIUf UZ8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683655093; x=1686247093; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vhZkJ8mwG4mA4GCg1/8ebcBN7nEL6s99qLu8EGL+6aM=; b=KAdb3g3DIbQRggKVo6x0ojzVeEponn5/o8wvWjkDjEKG7l249WW+GPTaRasx+3r2yb bXBc93+E+u8G/CSBEq+f1bgag9O6T2bELdyJq5ZjBX4s5WAzjPEcAHOyjQWILxFvZ3/A 75M0D3Kdg4eKzYV4u/gngC5ypngi6Bi36V7AXo0q+hO4vOr0ZSGPd3swz5R40AjFjn8d lSNbzeeJ7XeCR/qa6YX/N4mPkidHymoWC5pxqv38ZhCuVyvM3ase6hYC2fKjoaabDAGu 7t8c/BS3Lp2+Cdfp0cvh72itsT59tIpU72JFXqWEgU2rDOrJ3+p5DjfHe/XduGq+A4TR VUfw== X-Gm-Message-State: AC+VfDw6GiBoTe5fdBd5ty2VV5ohT1UjELx//OlXK0XLp+eFYGKgkzUh RVEZ4aB4+33s+Bdx4KV6l6eSaHDafOKpEWqgoZ+ncg== X-Google-Smtp-Source: ACHHUZ49rJPjHxjqOEHg2XTDvvYXxlAomMZ/J8dwcm1ggGpbs6cJE4E4fgmh/Nng3T5GtklLnTYVfidXTQDFZNjsIF8= X-Received: by 2002:a05:622a:1a0a:b0:3ef:302c:319e with SMTP id f10-20020a05622a1a0a00b003ef302c319emr15535qtb.8.1683655093002; Tue, 09 May 2023 10:58:13 -0700 (PDT) MIME-Version: 1.0 References: <20230508020801.10702-1-cathy.zhang@intel.com> <20230508020801.10702-2-cathy.zhang@intel.com> <3887b08ac0e55e27a24d2f66afcfff1961ed9b13.camel@redhat.com> In-Reply-To: From: Shakeel Butt Date: Tue, 9 May 2023 10:58:01 -0700 Message-ID: Subject: Re: [PATCH net-next 1/2] net: Keep sk->sk_forward_alloc as a proper size To: "Zhang, Cathy" , Linux MM , Cgroups Cc: Eric Dumazet , Paolo Abeni , "davem@davemloft.net" , "kuba@kernel.org" , "Brandeburg, Jesse" , "Srinivas, Suresh" , "Chen, Tim C" , "You, Lizhen" , "eric.dumazet@gmail.com" , "netdev@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: fahe8ytxs3pqdxofp8i8yjz7m6j65hix X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: 37BF6160015 X-HE-Tag: 1683655093-494137 X-HE-Meta: U2FsdGVkX1/yzXZFAIWsfTs7xEJ4OklcsYvOwx00uqYwnWYicSrAS0y2FzNVUxJ9THfkS+wbo1kWWso0DrnhpMHbBky8TiDgqn+uFbyf67JtjO1duuopwk+sh6dTaRA5/rEhoYoPGndRs1haUV3OyUnvkZOnst4j+kcmQqbdSoqz6sdmgySbADhtaf0nSLaYQHpwsFuVkqay/KAaeKds4TDW8glpxAWZPm71WLYq8qaBh2Ot5rDa+4bjxPVYOhgGlLxShPZBh4qRYP8avvhpHR1CMdiAvIsmyR8aJBS0wyOua4BEikBaW1zVmS31WmDOxU6e+SfW/C5aHusMH1p3drKWbYmFkq+d5AvuDfEXkuIwjvwVxHIx6I+rkVsW+lh27GXtdFxG1TV/siNplo17JHoCemkMwiqS5VlQthPxpuIMSqoQnU9nLAEn7o1ZvwHWrUfv5vM1vtOV4CnKckSlWcIZ7H3J3ohQw7pdM8JB1sXun7CjmP579AHLBaUinHA/ouYFHhW0dWXjb6dT2tavLuQ8BpNc4g3bEzk6dcbeXhHZTljUj+N3fZj+BP71Nf5Noz0w7AgJzmpkXSyEq1QCkvIPlWoss9fgWDP9e2nbAvfugC/ceeQA92ThgNxQOG+GYMpc6XymSUC2Hl02DSxlfmanj7aDiQL0tyu7sRR/26HKd8/esRg9+xialFS+uwIC+9lGPM09B5oiEVMxU2nPap9ZxK52uPJ5Ycwz4Q7p4tMvgB95zUbnkoDgCTkblOfhL1oMVtX4KMLO98J34QiuiqiCFY7JZxR4mpzeCMevEyYG7VqkkEzNBsmCAiEnb3sG9H3DXSY2oW35evU5KO46Y5zBwE1Fy2sDF8pkDuesQV2Lj2o5JL9MJ82uweXrXUND+hmOvEL9QQmhAO6Tf6hF/3FferkJLu9m5CYbUp7Mcs62CiCgR2EHCL0RbVcsY9QNXyHepts52fM3qrwFw3o L1orTJkf Lz5Dlm7L1hH4xj09DNCk53wi4TA9f1PmNSxhEnHYUv+rRmEDgmzepq9xU1J3cuK7rK7A78U2X/xfbA8NfyiHBXZOcBgiC8oUBcCreE7rYBRVSl+Jyl9thQwZxLCOcaw1GkLCNs/0kM+1OT3QY/1ZPJi/VCOGeeeRblxZrXrocUIN/MUUOBw6ey2fNjdhRBYCdUiM6i+Awl+0dbZ83sBPHuObKx94K92ut3tYC4acGuEZwiayNqpTXTImFcsslNU4X08oYCxJTFD6y2CvgFUM5CT12y149I7f8Zar7atKknf5aiHSiWzCvHoNbDvge/2xiCA7L+yG+kUReOwxrahBFXjnto3K/R8WJJPStvAAAR/myzYcr0d9Z0U2zGmpe85miU+v+hHSDWyrA2InVZeIhTRUmJA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, May 9, 2023 at 8:07=E2=80=AFAM Zhang, Cathy = wrote: > [...] > > > > Something must be wrong in your setup, because the only small issue tha= t > > was noticed was the memcg one that Shakeel solved last year. > > As mentioned in commit log, the test is to create 8 memcached-memtier pai= rs > on the same host, when server and client of the same pair connect to the = same > CPU socket and share the same CPU set (28 CPUs), the memcg overhead is > obviously high as shown in commit log. If they are set with different CPU= set from > separate CPU socket, the overhead is not so high but still observed. Her= e is the > server/client command in our test: > server: > memcached -p ${port_i} -t ${threads_i} -c 10240 > client: > memtier_benchmark --server=3D${memcached_id} --port=3D${port_i} \ > --protocol=3Dmemcache_text --test-time=3D20 --threads=3D${threads_i} \ > -c 1 --pipeline=3D16 --ratio=3D1:100 --run-count=3D5 > > So, is there anything wrong you see? > What is the memcg hierarchy of this workload? Is each server and client processes running in their own memcg? How many levels of memcgs? Are you setting memory.max and memory.high to some value? Also how are you limiting the processes to CPUs? cpusets?