From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33E3EECAAD4 for ; Fri, 26 Aug 2022 23:04:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 95E39940008; Fri, 26 Aug 2022 19:04:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 90C91940007; Fri, 26 Aug 2022 19:04:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7FD09940008; Fri, 26 Aug 2022 19:04:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 70DF3940007 for ; Fri, 26 Aug 2022 19:04:29 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 4775BA089C for ; Fri, 26 Aug 2022 23:04:29 +0000 (UTC) X-FDA: 79843274658.09.589B454 Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) by imf16.hostedemail.com (Postfix) with ESMTP id 11071180020 for ; Fri, 26 Aug 2022 23:04:28 +0000 (UTC) Received: by mail-pf1-f170.google.com with SMTP id 199so2822198pfz.2 for ; Fri, 26 Aug 2022 16:04:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=YVzdgHOnLRCNMj/Dtne4+E3xVYm73UAJFVxl5UM+dlI=; b=OR3CneSkHlCbKJtEcgpCri2+tewlhv5awjvREMp6AT1onwJcFk7obSWy94WM0oQrpv yCATqf2ZpkIPoo+j6Ds7kJ5gnpYDSczm0KyMMyXxOOo6UaMALxVVtM1PNYNhFI+atjkS +dHnatNk6iEnWkWjMzBIsLR24kZQ0jh2iwnFXHrmGWcWe/+lhPKX1duhOpUivlMPuUXZ edOMppqD/Ur7AN6XS51CbAoQqorPrf1MLHB6ypbPsLAe4I7t+hx22seAzy1OfgFCo8EN EcyLfxfloosq9fYL8FFTKEZnWST3q4frXOvZ3gNSC0P3Tmq/IZ1OmrJHvw9tCR9X3YIs 9SjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=YVzdgHOnLRCNMj/Dtne4+E3xVYm73UAJFVxl5UM+dlI=; b=C7g9PKDXhsK1cWti+Lp/fZYpxKLk2+ervXdRmfJShcBq29HJjwPwXxn6xA7qD77to9 1WPovWhWeIsFXJx1MIvH5jQVHwZA155e+c0hRkWKrJvQKqqPEwfeAZFl7JNMPgSMxo9J SkIk96qtbSDLk0hmuaEIjfs2XQ11jpajuKAP+kOPeEcQKKwUSZDZVgiIer4cDm702oza LT5WZEZ2e6EdMkbh1FH/iCCBZkGsqv6i/+0MDm5ItDgitmgXBMfvWUnhtW6hmE833DHI yurnkLnLO5PZtDXecnbTvi918E7xLREEfTagLxTFKzgbuCFhnmqDGOBBITll9QLWF0cr SbVA== X-Gm-Message-State: ACgBeo092W6kBRwyF4PbXW8pk7e4G52oS2hS0to0kZzXC2aqUhdywRRT Wqm0DkTPa0YOQJjbpoOgdyRdxD9zeXO2w4Moost6HA== X-Google-Smtp-Source: AA6agR5Btn0kkT/W3Cm9G0jt5/A14WqjaQI43EO2Vm1tLNohfq+llHJYBMuDof+O/M6OBJ6FLaaXr5STR5kpKb39RGo= X-Received: by 2002:a05:6a00:1d1a:b0:537:d750:65b5 with SMTP id a26-20020a056a001d1a00b00537d75065b5mr3114362pfx.85.1661555067845; Fri, 26 Aug 2022 16:04:27 -0700 (PDT) MIME-Version: 1.0 References: <20220826224812.550793-1-shakeelb@google.com> In-Reply-To: <20220826224812.550793-1-shakeelb@google.com> From: Shakeel Butt Date: Fri, 26 Aug 2022 16:04:16 -0700 Message-ID: Subject: Re: [PATCH] mm: deduplicate cacheline padding code To: Michal Hocko , Feng Tang Cc: Andrew Morton , Linux MM , LKML Content-Type: text/plain; charset="UTF-8" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1661555069; a=rsa-sha256; cv=none; b=pYXmUH04mg12thyVuJHOts/Ylgw96svnGUfB6Wn0FIRHOnhQ/yqEcOtTjeDjc6CCsONjNc l31uscSNdgdiGJqO6rG+5zi8MzKzaVHbcv0F5AvwKskGBGlAmwQtLTw/dvdszwx/oxsk+S dQaKfu5R8qeFOqIl7lIpbVZ7Z438amU= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=OR3CneSk; spf=pass (imf16.hostedemail.com: domain of shakeelb@google.com designates 209.85.210.170 as permitted sender) smtp.mailfrom=shakeelb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661555069; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YVzdgHOnLRCNMj/Dtne4+E3xVYm73UAJFVxl5UM+dlI=; b=kNCRCnRMsag5z+LOb40oMTZxtU3d/bbAG9JqneViMeOaqpRXKcfkx8iBKqWq0nhC8xv02u 23D4lWw61I1gggnNeAkVdATHFSo703RkJXQANrpMXfx82dM99MvJrh+QUkEkCQEK2Ffo8s h0yIGz984KMraRKEKOa8bjdnhPcWW/A= X-Stat-Signature: kng9nqg6eip9k5t8e7zu8mrmb7toea6y X-Rspamd-Queue-Id: 11071180020 Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=OR3CneSk; spf=pass (imf16.hostedemail.com: domain of shakeelb@google.com designates 209.85.210.170 as permitted sender) smtp.mailfrom=shakeelb@google.com; dmarc=pass (policy=reject) header.from=google.com X-Rspam-User: X-Rspamd-Server: rspam02 X-HE-Tag: 1661555068-983127 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Aug 26, 2022 at 3:48 PM Shakeel Butt wrote: > [...] > /* Write-intensive fields used from the page allocator */ > - ZONE_PADDING(_pad1_) > + CACHELINE_PADDING(_pad1_) This needs a semicolon with the common definition. (I had it in the definition but checkpatch made me remove it just before sending). Sending a v2.