From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D276BC4332F for ; Mon, 5 Dec 2022 16:06:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ED7088E0002; Mon, 5 Dec 2022 11:06:33 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E87338E0001; Mon, 5 Dec 2022 11:06:33 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D27908E0002; Mon, 5 Dec 2022 11:06:33 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id C27AD8E0001 for ; Mon, 5 Dec 2022 11:06:33 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 77630140C2C for ; Mon, 5 Dec 2022 16:06:33 +0000 (UTC) X-FDA: 80208730266.18.9DB4A7E Received: from mail-yb1-f177.google.com (mail-yb1-f177.google.com [209.85.219.177]) by imf11.hostedemail.com (Postfix) with ESMTP id ED9B84001B for ; Mon, 5 Dec 2022 16:06:31 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=hdVT9xjn; spf=pass (imf11.hostedemail.com: domain of shakeelb@google.com designates 209.85.219.177 as permitted sender) smtp.mailfrom=shakeelb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1670256392; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+MY/IUvw30YWp/2etOEFoGheOlDk2Kwhz5Bed/Q9Gfs=; b=vGB0hyID6Vb0xhHzuw2Rlqc2HOQ2HRnwZMrLs12aIzjRwPmTBu+WQ82YRBNi73nZiPzIqx xOiAgq8McZqU5a3q7H2YUbYSeB/6Pmb8PADhE5BerFuGZMrcIPbuH05Mt8sJdzk7t8aONF +NwEaQBgotOoPQCuffY2RYy1hnyxL48= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=hdVT9xjn; spf=pass (imf11.hostedemail.com: domain of shakeelb@google.com designates 209.85.219.177 as permitted sender) smtp.mailfrom=shakeelb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1670256392; a=rsa-sha256; cv=none; b=P4dwl6ixJq5sK7OLq6JJIrZq4XIWOR5E7TzDzUzhrbcGT/RpokhQ6Yq6wV5V1t55oTw1YE LdfNou4QxrCGaHkwFxxOcWG7zuJdtt2C59aMCNNxVvm/GkzgxL0I9T37xC9yiNaTrIceIW RWZUNUtYKjjoFGLWA6ay+AMYa9Bczac= Received: by mail-yb1-f177.google.com with SMTP id n184so14822513yba.6 for ; Mon, 05 Dec 2022 08:06:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=+MY/IUvw30YWp/2etOEFoGheOlDk2Kwhz5Bed/Q9Gfs=; b=hdVT9xjnT/mUWGOgc89ArMhDGZMtR5WPYdwB2jbz+xqcUj/JiKdmyrDrkLgBNcztAs RvwQpwT5YfjJSku+hrnr1F1XR/20PHVZd1WuoySUCsUVMGgU8pEwmZn8sBjFR9JsCLM+ eDUpHYoTTQWbM9YA7BjKU1Q1Dfj2qnFxabwK9Uhs4zA6Bma/WG8pEUr8e45+Ljtx0pVu lbXuR5N/VjOsRCY+wN4Kf9nSqkYXEqK6DAaN7Tzf5aiHwtqOGiP5wbkhswlVOK7tisYa 66lczlLnk6iwUaTIzRYRZ8fhRWp1gvsn7RL2g83kff9nHO0Q0vqXGrYadz5rOkPTSEAu bShw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=+MY/IUvw30YWp/2etOEFoGheOlDk2Kwhz5Bed/Q9Gfs=; b=5BnvRtt7bcyRYZ3bFj4iNBuIjo7gB9W4Y3yVMmudjtmqGIu9UNBwRSZLIAHtcd1GjQ oY4i21eIQsx3UB/F4nCwEJX1BaW5FUCwPPmr//wq28DJjOpi8rXyz35zZFQDdLpj9r4v ebVjDkPDbX3iX3o0MPYhVl1xwGgwyfOw/hGmXf6x4BGBF+4vUUYMZobnc0rIEyuRvFif TK/odVPJ+LZ0QSIp2Ll86q70GeEj0kIJFryUdigoIo1iGhCfLqA6eJm6NbDKltvR1CwE 16TJgiEm52RgrfruaRtGHMnlsDiD0r1hmmzKxBItd58QBDTJcgMs5o2iknMb8d7zsflV u2bg== X-Gm-Message-State: ANoB5pk7XBvM+i6M/KZFUTQ0sOqX28MwN+GTLfV2D4YBl2m80vCbxWrk 8kCdov+yZcJZQIZ7kaC6KD0n/6g5tS6hTkCoTU44Lg== X-Google-Smtp-Source: AA0mqf7GDOWb8ExTp+r+qkNXfkUAFaF3UWSsBLzoTXMRwcEkSq6J3AsnxRRMzYxuVGchQDw3U7+fxlUjKUHybd+CuDg= X-Received: by 2002:a25:ca4b:0:b0:6fc:c36a:1cf8 with SMTP id a72-20020a25ca4b000000b006fcc36a1cf8mr14981358ybg.363.1670256390841; Mon, 05 Dec 2022 08:06:30 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Shakeel Butt Date: Mon, 5 Dec 2022 08:06:19 -0800 Message-ID: Subject: Re: [Regression] mqueue performance degradation after "The new cgroup slab memory controller" patchset. To: "Luther, Sven" Cc: "linux-kernel@vger.kernel.org" , "regressions@lists.linux.dev" , Roman Gushchin , Andrew Morton , Christoph Lameter , Johannes Weiner , Michal Hocko , "linux-mm@kvack.org" , Vlastimil Babka , "kernel-team@fb.com" , "Eric W. Biederman" , Muchun Song , Waiman Long , Alexey Gladkov , "Bonn, Jonas" Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: ED9B84001B X-Rspam-User: X-Stat-Signature: 61g87xstp39to3hmi758ku6s7jzz3jm8 X-Spamd-Result: default: False [3.10 / 9.00]; SORBS_IRL_BL(3.00)[209.85.219.177:from]; RCVD_NO_TLS_LAST(0.10)[]; MIME_GOOD(-0.10)[text/plain]; BAD_REP_POLICIES(0.10)[]; BAYES_HAM(-0.00)[27.12%]; ARC_NA(0.00)[]; TO_DN_SOME(0.00)[]; RCPT_COUNT_TWELVE(0.00)[16]; FROM_EQ_ENVFROM(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; MIME_TRACE(0.00)[0:+]; DMARC_POLICY_ALLOW(0.00)[google.com,reject]; DKIM_TRACE(0.00)[google.com:+]; TO_MATCH_ENVRCPT_SOME(0.00)[]; R_SPF_ALLOW(0.00)[+ip4:209.85.128.0/17]; FROM_HAS_DN(0.00)[]; R_DKIM_ALLOW(0.00)[google.com:s=20210112]; ARC_SIGNED(0.00)[hostedemail.com:s=arc-20220608:i=1]; PREVIOUSLY_DELIVERED(0.00)[linux-mm@kvack.org]; TO_DN_EQ_ADDR_SOME(0.00)[] X-HE-Tag: 1670256391-480394 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Sven, On Mon, Dec 5, 2022 at 6:56 AM Luther, Sven wrote: > > #regzbot ^introduced 10befea91b61c4e2c2d1df06a2e978d182fcf792 > > We are making heavy use of mqueues, and noticed a degradation of performance between 4.18 & 5.10 linux kernels. > > After a gross per-version tracing, we did kernel bisection between 5.8 and 5.9 > and traced the issue to a 10 patches (of which 9 where skipped as they didn't boot) between: > > > commit 10befea91b61c4e2c2d1df06a2e978d182fcf792 (HEAD, refs/bisect/bad) > Author: Roman Gushchin > Date: Thu Aug 6 23:21:27 2020 -0700 > > mm: memcg/slab: use a single set of kmem_caches for all allocations > > and: > > commit 286e04b8ed7a04279ae277f0f024430246ea5eec (refs/bisect/good-286e04b8ed7a04279ae277f0f024430246ea5eec) > Author: Roman Gushchin > Date: Thu Aug 6 23:20:52 2020 -0700 > > mm: memcg/slab: allocate obj_cgroups for non-root slab pages > > All of them are part of the "The new cgroup slab memory controller" patchset: > > https://lore.kernel.org/all/20200623174037.3951353-18-guro@fb.com/T/ > > from Roman Gushchin, which moves the accounting for page level to the object level. > > Measurements where done using the a test programmtest, which measures mix/average/max time mqueue_send/mqueue_rcv, > and average for getppid, both measured over 100 000 runs. Results are shown in the following table > > +----------+--------------------------+-------------------------+----------------+ > | kernel | mqueue_rcv (ns) | mqueue_send (ns) | getppid | > | version | min avg max variation | min avg max variation | (ns) variation | > +----------+--------------------------+-------------------------+----------------+ > | 4.18.45 | 351 382 17533 base | 383 410 13178 base | 149 base | > | 5.8-good | 380 392 7156 -2,55% | 376 384 6225 6,77% | 169 -11,83% | > | 5.8-bad | 524 530 5310 -27,92% | 512 519 8775 -21,00% | 169 -11,83% | > | 5.10 | 520 533 4078 -28,33% | 518 534 8108 -23,22% | 167 -10,78% | > | 5.15 | 431 444 8440 -13,96% | 425 437 6170 -6,18% | 171 -12,87% | > | 6.03 | 474 614 3881 -37,79% | 482 693 931 -40,84% | 171 -12,87% | > +----------+--------------------------+-------------------------+----------------- > Is the last kernel 6.0.3? Also we know there is performance impact of per-object kmem accounting. Can you try the latest i.e. 6.1-rc8? There are a couple of memcg charging optimization patches merged in this window.