From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35C92EE49A4 for ; Sun, 20 Aug 2023 05:15:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1D8928E0002; Sun, 20 Aug 2023 01:15:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 188B98E0001; Sun, 20 Aug 2023 01:15:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0A0BD8E0002; Sun, 20 Aug 2023 01:15:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id EFCBA8E0001 for ; Sun, 20 Aug 2023 01:15:26 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id BC6ECA040E for ; Sun, 20 Aug 2023 05:15:26 +0000 (UTC) X-FDA: 81143319852.09.EDFF811 Received: from mail-qt1-f179.google.com (mail-qt1-f179.google.com [209.85.160.179]) by imf26.hostedemail.com (Postfix) with ESMTP id 0B973140007 for ; Sun, 20 Aug 2023 05:15:24 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=nrQiyjOj; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf26.hostedemail.com: domain of shakeelb@google.com designates 209.85.160.179 as permitted sender) smtp.mailfrom=shakeelb@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692508525; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=QHzkhq/2CNg7lFMLeaog/UrvW1UqZ1CtPUmwbLqtOso=; b=vXVL45zuDmwHzQ+8NUN2ev6ZJbPhqHLECF7GDJUM0EtocgbLrP0YxQjAkfrXw/3CzM/tb5 VQp7z+DpcQzUfaVH+PzkgPe59FXBLKucdP1nOpmHrRBKWAavS7nvEyd4gSCouUZHa1hv0Y igceYxh6Y107MGhsTMBWxRyyvcX9d2k= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=nrQiyjOj; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf26.hostedemail.com: domain of shakeelb@google.com designates 209.85.160.179 as permitted sender) smtp.mailfrom=shakeelb@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692508525; a=rsa-sha256; cv=none; b=NkKH4fATcdv1gico7PJTUxghkymdfLThniX9fEdTWNDSh1YoffsVXvxTDqHx7cleQ15SQN 6uIL0Wz1NsFw8f9o61nv42ud4pdtM9DiPl7J9G695dxpE5MEBQB+tqbpW/NlFrQ417hWiQ Zx/8boJLOF4cUJoUCrPFIKOQBe24vZA= Received: by mail-qt1-f179.google.com with SMTP id d75a77b69052e-4036bd4fff1so225941cf.0 for ; Sat, 19 Aug 2023 22:15:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1692508524; x=1693113324; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=QHzkhq/2CNg7lFMLeaog/UrvW1UqZ1CtPUmwbLqtOso=; b=nrQiyjOjJgcaUd2bk6SQdWj5LUoQRiQaNvV3OXquVrONrch9Wsbd6GIbPFmmNEDNyB 29owdNMnZkMOs9CZbup2nYnf6BB+WZq+G0JsrFFj4u+ZZY142ePVUn2zyprs6B+dZxnZ K81VlDP+tLe+QLce0rYfnTKWFi6pmJq61kqfwBs0We34X0KJJdMSBeJA2zPHPReDhI13 2Provo2k/OOGfiUny7nal9athlK4IcTcBWLf3C0BOx7s6erKTG+PVzRpIZTZPJlqLppA x+oyDUjXk43LQTeqPoRWboN4p6Bi/3/2tv5ZQPt8lwGOpRvUDK7JvThsVsCHwEcOuvrP EG1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692508524; x=1693113324; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QHzkhq/2CNg7lFMLeaog/UrvW1UqZ1CtPUmwbLqtOso=; b=Ga3eOcvNOXZUtUPZBQeJ3UH47Mw7YkuSmzhC2saJKhO0tf7asL8tK0CnS6YJsStpXy /9tIRYWREmfliE6WAjeAUcTRYkNeF00QbYRNIipOtpTeT5glWJa/zmrU9GihOtP5Q1Ud +Cq7h/o17gUucDR8RW8T7qlkfaNyfpP7GJZyS94wxVmesuLKC5JXsyRRoNmMDs5OIyx1 Niyt2Wu0QXwgU7wmFOiU3LUvKpxXGBVVJBmlEeAE5Yd6gi8GfWSz9DjYA2A53sshf0jl 20Eze5AiJSfHA7HKhfVYfia+sgMnOZWpeAOZirCOOccc7LafFnNemw0ACwv2piTzy22z VuyA== X-Gm-Message-State: AOJu0YylSPCDkOWz6j5kZ+d0ygJzBrWOK/5dJOwEjrJR/J6ToTkH4BVi n83kPTB45Pn29i5uNDkG9aESMFgxvgaRrmT55AcdwA== X-Google-Smtp-Source: AGHT+IEyrJJN3bqcxrncMer3K59w5lfuTjhtm8IRRVSw00c59ETlftXN80uaZzSCoeXAbSChVJPhFhBqeOvM8vvWJTk= X-Received: by 2002:a05:622a:1316:b0:403:aa88:cf7e with SMTP id v22-20020a05622a131600b00403aa88cf7emr359610qtk.29.1692508524018; Sat, 19 Aug 2023 22:15:24 -0700 (PDT) MIME-Version: 1.0 References: <20230819081302.1217098-1-lujialin4@huawei.com> In-Reply-To: <20230819081302.1217098-1-lujialin4@huawei.com> From: Shakeel Butt Date: Sat, 19 Aug 2023 22:15:12 -0700 Message-ID: Subject: Re: [PATCH] memcg: Removed duplication detection for mem_cgroup_uncharge_swap To: Lu Jialin Cc: Johannes Weiner , Andrew Morton , Michal Hocko , Roman Gushchin , Muchun Song , cgroups@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Stat-Signature: rnp8hqi5771szmhcnzoiyxaf97d6jt79 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 0B973140007 X-HE-Tag: 1692508524-435348 X-HE-Meta: U2FsdGVkX19fvpzteqn7aatgIBt4w+unqNsdfDBhKDtnfbq8ltFLfECbbSTeTPmvVLvMLL/tdnh8hxZsFY0lho4KOrIw9KPdTGhc+XtuEmKq0ZGIptlm39H5eIxO+2xn2P8YQrdI68o+eqs2bGcWEiHIdxZrKD2RVvU7ZJV7y+2SuTj3RZQJ/+RcX5SGLM8mbEXVnG8xCFrgkNwGQF7qLUKBmkG4Q2ateGwBLpP+ONBGXwGl9S0BMJ1DY/U9TgkSxm/G9REfwQc8yjYnhqvv7bhHfSxITiAgI57UOhVNVOOWfEpvBW7n1Nd2tnLTgdZaB+HRVrbXfkjoIRkosWPKFZeh/D0yngz3fha8320pGb+sAEKzHZKjAu7lpiHPjAtqO8WOVAlzU14xU0YFyomYuyrdUEHnuOLhrg9Smx6b7oZ33IiO3Y8BSOLa4D/8Uc66llgx4heXsegETUabehPVIybTTIpn8urW9d7wPZB8ljjTOF6C/Xx3qdmK1wApOfiEAEiwMlw8JEY2rxTHOrsqzwGbtiMxBCXA2f4+WwCvB9wMIyi5mN3YAmPSVGxX/fbZ/uIeCk/kW0R8curYmH17yWW+y+AcKWXc/EfJ/d86m7GfXt5olXW1Q8ZV5M+DUbce4xAdUSMtNMMYuDS+xxjHp+MyZFL/HBddVlXQQJ9ibHzGR8qWPJGWk7nDI5w4M+YDA+CQfJRc9DxND+dbsVrJzOKa6DkWRGHzhqWSpByq9K7sLcDmTQ6U1rPBiCY4IdlgScAEuqlE3yiIfu82wpfA7ranz4CYRPVC5p4o7IFKZgWedTTjd7/mh8VkukLrwTNK7u9gw6bA4pTXAIx5yAl4s9L+u4/QNoYuWjZo15D5EsEFHVtJ5+qnZWranwU2OF17EQ/0Neo/6Vgt/QSvqfez4lC1dz92A2oBIizyo1SNn0PJRYUXhuAc7hyaH4sozTAdIcpnCfPgW77s9vlWxKy KsivO94h AyYl+AQ5KKT7GehIbH4Ri8m2DnLBzjuKd+b///oKixNI3diC7qNCM3c/qNTs6suzYHD198jk8sITQ+Wmoby38qT4nKq8HG+JeRJTvULL/vbsnfwbvJGCQKClZlWxC12iZIfcx8Xs6Q6C8hl+ukW418wspwd8pRiPikdOi6Dug6/C++rohPbbI5Nmgf2/tHsED8HgC2DoPyUN1mhOfSrU7+eTQLuw3CNNSP8fDttl+jK7S0LUu89iZYvN7h1BzGs4X6Q8UqE5pXnfvAcH/Ma+Y2zddI3K6a4bRUsSvtA6Ay0Ia/nH1zBC2IhrTvKLL1HStCAYO X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Aug 19, 2023 at 1:14=E2=80=AFAM Lu Jialin wr= ote: > > __mem_cgroup_uncharge_swap is only called in mem_cgroup_uncharge_swap, > if mem cgroup is disabled, __mem_cgroup_uncharge_swap cannot be called. > Therefore, there is no need to judge whether mem_cgroup is disabled or > not. > > Signed-off-by: Lu Jialin Acked-by: Shakeel Butt