From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6C48C433B4 for ; Wed, 5 May 2021 16:09:29 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 64011611EE for ; Wed, 5 May 2021 16:09:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 64011611EE Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 1D60E6B0074; Wed, 5 May 2021 12:09:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 167DC6B007B; Wed, 5 May 2021 12:09:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DC1386B0075; Wed, 5 May 2021 12:09:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0118.hostedemail.com [216.40.44.118]) by kanga.kvack.org (Postfix) with ESMTP id BD4C26B0074 for ; Wed, 5 May 2021 12:09:27 -0400 (EDT) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 7EDB68249980 for ; Wed, 5 May 2021 16:09:27 +0000 (UTC) X-FDA: 78107662374.01.C2F039B Received: from mail-lf1-f46.google.com (mail-lf1-f46.google.com [209.85.167.46]) by imf03.hostedemail.com (Postfix) with ESMTP id 1F52AC0007C4 for ; Wed, 5 May 2021 16:09:20 +0000 (UTC) Received: by mail-lf1-f46.google.com with SMTP id x20so3347743lfu.6 for ; Wed, 05 May 2021 09:09:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=KKsuEFeD+gJYSLJ7ekg4hfVqsnbJkGKmSnFbVOc/YJ0=; b=pGurct48b4cD8PojrnEnwDogn490UJ9vqixvhsKhgQxNctHN1tmUuM3UD9+ybdnCIY UxaEbOhE28qlVJbcYa48VZQspRkpa6R+BdyW29LwM/CJLY+97Y+uD6Cp5fdO4dnPj2rX A0mfjYE/DSuuRi1bqPpZG1hrFxCO7tuqYHZDpNQeXKfe+E+ImMxuIh9hdW3twa5HeDV6 G2NJHXEeRLfd4fcv1JDhs3H8kWGJrtpuq9tLRg6pUf6vAquDmBcDLuBANRZ1u8FO36ON PDLNDLz8lbu0hary8tnz00mf3UhHAdg/2teGSWUTWOyMpHy/jr1tEsiXr/46vVNPzP75 9Xag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=KKsuEFeD+gJYSLJ7ekg4hfVqsnbJkGKmSnFbVOc/YJ0=; b=oCBJ7nao6Dy4UeGX9JcsYpjyqhwI2Oe8c4YUnTXNY7hPyRAJNXoD82RJjHzXphJ/h0 0f8C3m1IRU77J8BTBn4jud8fGMRjGoNUBU2Agt1JGRrMB8BLJ9CI3xjR833K9hswTcmr fuGYpbCaBtXScNtFzl/f/3Q5TW9o0qX5Sb/Om0vM6a8HARf5JovDPezN25ZZSGI2AAz1 ipaz1kGhjDr0ne7eIUtx3MgU1GU5HxsZceXL7aYBFlp3vOapxfq/LsHUxEQ9BR3c5j2+ B03TRfL7cjk7cL00pnCL7AFgxeQS3ZPszf2S8bBfwIC/bERVKd9UK+ob67f37U5St4sJ loaw== X-Gm-Message-State: AOAM530irmbxKbROhKEHicxVYp5JFgu17+akvP4exRUi9QFp1AoDXMcO dCkZb0aKJd/MKnTHb8A15fSjrm7VGKQYtx6Woqpr+g== X-Google-Smtp-Source: ABdhPJxwJ64DO2bcAnK++U2Uq7VZ5qveX0vCIByuvshyxCHklvLxOYW/x/1x+Z2L38EpLEypgc6eYhFyefEOpbx9m1A= X-Received: by 2002:a05:6512:92e:: with SMTP id f14mr20767256lft.347.1620230965352; Wed, 05 May 2021 09:09:25 -0700 (PDT) MIME-Version: 1.0 References: <20210505154613.17214-1-longman@redhat.com> <20210505154613.17214-2-longman@redhat.com> In-Reply-To: <20210505154613.17214-2-longman@redhat.com> From: Shakeel Butt Date: Wed, 5 May 2021 09:09:14 -0700 Message-ID: Subject: Re: [PATCH v3 1/2] mm: memcg/slab: Properly set up gfp flags for objcg pointer array To: Waiman Long Cc: Johannes Weiner , Michal Hocko , Vladimir Davydov , Andrew Morton , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Vlastimil Babka , Roman Gushchin , LKML , Cgroups , Linux MM Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=google.com header.s=20161025 header.b=pGurct48; spf=pass (imf03.hostedemail.com: domain of shakeelb@google.com designates 209.85.167.46 as permitted sender) smtp.mailfrom=shakeelb@google.com; dmarc=pass (policy=reject) header.from=google.com X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 1F52AC0007C4 X-Stat-Signature: 9i6bsgtgzr5j4gupcjcs8x9sbz4rk1z7 Received-SPF: none (google.com>: No applicable sender policy available) receiver=imf03; identity=mailfrom; envelope-from=""; helo=mail-lf1-f46.google.com; client-ip=209.85.167.46 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1620230960-549750 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, May 5, 2021 at 8:47 AM Waiman Long wrote: > > Since the merging of the new slab memory controller in v5.9, the page > structure may store a pointer to obj_cgroup pointer array for slab pages. > Currently, only the __GFP_ACCOUNT bit is masked off. However, the array > is not readily reclaimable and doesn't need to come from the DMA buffer. > So those GFP bits should be masked off as well. > > Do the flag bit clearing at memcg_alloc_page_obj_cgroups() to make sure > that it is consistently applied no matter where it is called. > > Fixes: 286e04b8ed7a ("mm: memcg/slab: allocate obj_cgroups for non-root slab pages") > Signed-off-by: Waiman Long Reviewed-by: Shakeel Butt