From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79D70C4363A for ; Thu, 29 Oct 2020 16:01:55 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E02BD2076D for ; Thu, 29 Oct 2020 16:01:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="eeVMWmyL" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E02BD2076D Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id DFD1C6B0062; Thu, 29 Oct 2020 12:01:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DAD0B6B006C; Thu, 29 Oct 2020 12:01:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CEA6C6B006E; Thu, 29 Oct 2020 12:01:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0057.hostedemail.com [216.40.44.57]) by kanga.kvack.org (Postfix) with ESMTP id A3DAB6B0062 for ; Thu, 29 Oct 2020 12:01:53 -0400 (EDT) Received: from smtpin04.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 32F97181AEF10 for ; Thu, 29 Oct 2020 16:01:53 +0000 (UTC) X-FDA: 77425428906.04.brass47_390340a2728e Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin04.hostedemail.com (Postfix) with ESMTP id 3A29B800BE9F for ; Thu, 29 Oct 2020 16:01:51 +0000 (UTC) X-HE-Tag: brass47_390340a2728e X-Filterd-Recvd-Size: 4058 Received: from mail-lf1-f67.google.com (mail-lf1-f67.google.com [209.85.167.67]) by imf48.hostedemail.com (Postfix) with ESMTP for ; Thu, 29 Oct 2020 16:01:50 +0000 (UTC) Received: by mail-lf1-f67.google.com with SMTP id j30so3984903lfp.4 for ; Thu, 29 Oct 2020 09:01:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=p81Xb4QB6WZnyTYb/aPQJGGs3MtSmkCjVSQFBTfTe00=; b=eeVMWmyLkGAhC1rQFKkLvBOCkWQ6Smot20Si3H+Lg87YKkUxflwYxLcfGFqVLc5KLf SwfZDbAGSj4utMXHZmxzJ7TGpzf/Jd7X5Inmxc4MCtwfLFLZytqccPGQm1mHvSm7j5Lp dMfYdPJhpw9CWTTVqZsaV7ks5rzt5ea8aULFpgqf8ikV/61BMq3p8Szx3rYFDUXOUAnZ mAnrQOY1y6sAb0KwsoD3XeL7AmBHXhk4w543PNyD0NFf6HqcD0asVoBZ1/Q11E6qJedJ 7abxq5IUrm3H3tQgcVV7hVxwNp+ND66/eKEZkhmXVM7KiHEur3c3SDi/bzfspTKvt+9q iOGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=p81Xb4QB6WZnyTYb/aPQJGGs3MtSmkCjVSQFBTfTe00=; b=euRPKQJ3HfvFB2GH1Y2fu0B/7AsPIQGbntnkh5BxnEjwmmURLqAfFse1XBu3a6PHbx RrZsiaXQ7KUA4JvGoFR0T0T4/RIOCmiGqauUWKNhvqvxVUbvjKR9tM69xroglAp21cTL rcnSZR0OlzlfOD7vyhjdUDdrHnLwVjP55qLg081J5N4ALSNyO1OhB7CXJgwZDglp7V0l oSxveTZXTALUkuuQVl4dXzv5krYG3hWkEdDquEyPSb7QgJYc+vpzKhPQNO+OQu+H3wpo 3bhH7t1SaEU9/OkKSdsLUJTOMKSgmhdECRZK8ya4ArDegG+yeQhn2h3l9q2Qi5AHceGW bq1w== X-Gm-Message-State: AOAM5331Wf7/Hx3GPDaZlyetAxSR5UITTcqDvW64XRSDODTcTDmUOpVo vHg1htqg6bg16lPXfxct8U1PVLgu4ZBRseboDi6Iqg== X-Google-Smtp-Source: ABdhPJx+zC1arRhZCm7aznCIifmlA/6cXtGd3vyaxduqhW4AIttT0kz+HB9ULUcSqFW5zic1sM3xgNSvr5x8UXg3rjA= X-Received: by 2002:a19:7ed8:: with SMTP id z207mr1786143lfc.54.1603987308798; Thu, 29 Oct 2020 09:01:48 -0700 (PDT) MIME-Version: 1.0 References: <20201028035013.99711-1-songmuchun@bytedance.com> <20201028035013.99711-4-songmuchun@bytedance.com> <20201029090806.GD17500@dhcp22.suse.cz> In-Reply-To: <20201029090806.GD17500@dhcp22.suse.cz> From: Shakeel Butt Date: Thu, 29 Oct 2020 09:01:37 -0700 Message-ID: Subject: Re: [PATCH v2] mm: memcontrol: Simplify the mem_cgroup_page_lruvec To: Michal Hocko Cc: Muchun Song , Johannes Weiner , Vladimir Davydov , Andrew Morton , Roman Gushchin , Joonsoo Kim , Yafang Shao , Chris Down , Christian Brauner , "Peter Zijlstra (Intel)" , Ingo Molnar , Kees Cook , Thomas Gleixner , esyr@redhat.com, Suren Baghdasaryan , areber@redhat.com, Marco Elver , LKML , Cgroups , Linux MM Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Oct 29, 2020 at 2:08 AM Michal Hocko wrote: > > On Wed 28-10-20 11:50:13, Muchun Song wrote: > [...] > > -struct lruvec *mem_cgroup_page_lruvec(struct page *page, struct pglist_data *pgdat) > > +static struct lruvec * > > +__mem_cgroup_node_lruvec(struct mem_cgroup *memcg, struct pglist_data *pgdat, > > + int nid) > > I thought I have made it clear that this is not a good approach. Please > do not repost new version without that being addressed. If there are any > questions then feel free to ask for details. You can get nid from pgdat (pgdat->node_id) and also pgdat from nid (NODE_DATA(nid)), so, __mem_cgroup_node_lruvec() only need one of them as parameter.