From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7CA4EEB64DD for ; Sat, 12 Aug 2023 02:34:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DD65D6B0074; Fri, 11 Aug 2023 22:34:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D86396B0078; Fri, 11 Aug 2023 22:34:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C4E456B007B; Fri, 11 Aug 2023 22:34:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id B55136B0074 for ; Fri, 11 Aug 2023 22:34:08 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 786C71A062C for ; Sat, 12 Aug 2023 02:34:08 +0000 (UTC) X-FDA: 81113882976.01.E84AD21 Received: from mail-qt1-f179.google.com (mail-qt1-f179.google.com [209.85.160.179]) by imf25.hostedemail.com (Postfix) with ESMTP id C8108A000B for ; Sat, 12 Aug 2023 02:34:06 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=UdPOJ9r4; spf=pass (imf25.hostedemail.com: domain of shakeelb@google.com designates 209.85.160.179 as permitted sender) smtp.mailfrom=shakeelb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691807646; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bTLD/QdYHVpt+4scbNbRrg+8KO9/38zELxI1928BfJc=; b=o1Ucd6kX7bKtpKIwG/piKec4nXYF2/L8snsrREtJ2OAveVx7GPi5wZbi/OdU/VhPQNiMYh aFp64hddAvMOyxCTh5UQS7WNYjoUtqAwjKpphw86BLo68ol4LUFvKGw6W6W6MdfxQUdx+Z v4axEWswkQOKH2hyYzjn9kVQvQDiZQg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691807646; a=rsa-sha256; cv=none; b=4PX38Uu5kcbBXXNg24FQZpqYmRaLDKqfklvsqzQfad2BXqkSdUmisgUldeGY0+5p3NAmUo 7e+aVq1HU93iIYjyjjLDOOc12WCivjRqLb5aaZDKI62OmRINc5iTaBngWiDjM5jCheqUKK 1Qop2KUByzKelEYHYiC5O5dG8AHfD5o= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=UdPOJ9r4; spf=pass (imf25.hostedemail.com: domain of shakeelb@google.com designates 209.85.160.179 as permitted sender) smtp.mailfrom=shakeelb@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-qt1-f179.google.com with SMTP id d75a77b69052e-40c72caec5cso87441cf.0 for ; Fri, 11 Aug 2023 19:34:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1691807646; x=1692412446; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=bTLD/QdYHVpt+4scbNbRrg+8KO9/38zELxI1928BfJc=; b=UdPOJ9r4HII7NNEiN5YCqMDeu6BvUbS2vwkDURY9Vi5e0eAEJ7VRD1haOIydI+Ib+7 ta1fdKZPPI1LTFwuiLyNY15TXJfATouhe8oZDdjIU1ZJs5/a6HUe1jv6A9NBzwO8Kez+ 2dU9q0qA6XuEdoQybkOjDZWLqRqBB1YV1JxL8ygLQ1tn17frZDK7VFkRcf+YmkbWHaJY HWs9tbWC3xenui2rP6kX0MFlB60LyMS5NfLN2AFTisRDNP9qM6Snpohl0mnKK57hQh1r HH1mpbjF0mqUoiZO3XlpiVHLkH1vlUIf9Galfiph8Pyhsz1aR38R7jOOLjp7gUKGAIu8 oVSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691807646; x=1692412446; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bTLD/QdYHVpt+4scbNbRrg+8KO9/38zELxI1928BfJc=; b=RZGF+e/KinWMfbNTejGGI+X4+06/Chs3qmv/lPrK2edguNLFcd0ubt60/9dQPf9mL4 lhgWNxrl79mqTgV5erUmnf8XNVLLcxgFPD2hIoB/aTBVSuJbnYuCajTDZcemBXfAbTij sT8sO8RT8hRBqw1tprUuLn+UfNIxrx/XzE3Li46dFHL1MkKW1tPn+JcKUNQQybhDH4bC 80JGSJmWXMaFfiD70ESNltf/4hpV3YTwX0sw2G2LZytS0Pu/wDADzZ2DF67MnHfWZd3c 6osIILdHt1IaJMsCh1MYCxcwDLcoNYklig/tHyDFXupzx6pPXVyFHEEDGC2c6SX7ZTS/ rMMQ== X-Gm-Message-State: AOJu0YxbeZJVIfGDZrXx0AM3Bneb6hR23qinNu+0r/AkAVgZOvXLKSao 0OAkeEPXX0q8wGKDNMOclj0EykKF0yNVfAJj2onekA== X-Google-Smtp-Source: AGHT+IFzvKTREcAhH2+jX2sXMEF76gbO+jOHLFbMQ+tmhgXwxqHHARCI21qZWA2f+rP5y3xkgzylMECxeqsLZDtI3FY= X-Received: by 2002:ac8:58c2:0:b0:403:a43d:bd7d with SMTP id u2-20020ac858c2000000b00403a43dbd7dmr408231qta.4.1691807645900; Fri, 11 Aug 2023 19:34:05 -0700 (PDT) MIME-Version: 1.0 References: <20230706062045.xwmwns7cm4fxd7iu@google.com> In-Reply-To: From: Shakeel Butt Date: Fri, 11 Aug 2023 19:33:54 -0700 Message-ID: Subject: Re: Expensive memory.stat + cpu.stat reads To: Ivan Babrou Cc: Waiman Long , cgroups@vger.kernel.org, Linux MM , kernel-team , Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , Andrew Morton , linux-kernel Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: o6oip83am3sy5opptgqwjkaptxwwsi5a X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: C8108A000B X-Rspam-User: X-HE-Tag: 1691807646-254798 X-HE-Meta: U2FsdGVkX18ib3M66w51HLEcY3vRIrbWUCfvidnLk37uIacW2XiID9Crpuoosd7hlVj80vhSctL95UKTO0A/uNo9raUKO/5xHiF6zyot8Ezv3rJJdkszP1vd3Pzwcspj94TrbXIuJxb38z3oNaAP5dX7IoFbCdkdQcaBqqCDMTQ3yXfss/vZx7nIk4dIrAkqNmtAHISy2lJ3SKClkXg8/5LrikVHOfUObpxcr4zVngndsVuteJ90N7xYpE8UjGSbnUR5l7S4QwOmygEkkcV610M8B8fGQgytKV+us2C0keH2hp9POh4dyp927DRMA+SV4r83v1GFuYwta/MaC9z59Vvj+1slZEmAOmhqO1LVIgCwITpTU2enxcKx9DquS+NISQPBdr8Twv9wPq5v8ycOHFs/j0H3++76WGnZRlCKwbuki5jwA3VvMEeujQo6geJfDx5DvySrLBwG3Rvb5VGYnj/xGBmBfVIgsBd6g0xVbNe27VWBKZ6CXDEzH9CvO+Hx9mUb9h/yw24uRMmG7V83XWDIWL8K0dDXkyWzuvPPLYXg+eDUGbREJMyCDjF6TUb5tsBx8cn/59Jtp2uemIJcxIeAy5+5q8LOsRhxwrk8f/5ix6Dq6i5oTwyBc+/BltUkoYkp/oSWR9dNxtSLrRrxJG3L4MmHBaxaVr4Ov/LCO42LrLzIG/0dz+NWvj7pk2pP0NmH9dUta1KqT0vVSv7kaIb791FqUcEWO0SY0zA+86h/jWrRa5eJ5JkDdQKBFHMREgFxotwsXMAz7oJMdUCaCkbMbnzj88BF+aeVq6Ot7nNPjRLIpVa4toU2TKvbFV7ZUMWKkPfIWMmyEe5bFA4UMAWu6uZ4j9AnaqcDONxAeCe2i7XGnxL41KwFrMWUlRi+94eyPhio3cQYUy8pGwKHqRELB61K2h4lXgtbRVqhS3oESW7QiVxjll4zG3k8e0HwBSdkMb/AARxjBqUc8tQ ix0YraJg yBW3x1gpKoU+OMTzzSB14tXmDieMimlGWqdm8/ewYeMCt+r+RVW6boZZHJVt3q6cXznXxhf8geU2l7k9Ho+Z/kGWUqHQwwUAWOSike7B9guQRvroyVZf4od1j/9AjkrwEhw+gA3PUkHuw75cXLvQkCKpfTicyBxAtKw/cz8+YtNLnJ8kxCiYbUu/j7tTCW/gV4kJ9VkLt2YBHlgBR7MyZWOnR4LGPxMFuNyJXuqJdvrkIE/2u/U9WUOxc6VkTqZLgS9wdzfKtNhjfEDYpCjMBRB/UiQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000176, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Ivan, (sorry for late response as I was away) On Fri, Aug 11, 2023 at 3:35=E2=80=AFPM Ivan Babrou w= rote: [...] > > > I spent some time looking into this and I think I landed on a fix: > > > > > > * https://github.com/bobrik/linux/commit/50b627811d54 > > > > > > I'm not 100% sure if it's the right fix for the issue, but it reduces > > > the runtime significantly. In your patch, can you try to replace mem_cgroup_flush_stats() with mem_cgroup_flush_stats_ratelimited() instead of cgroup_rstat_flush(). I wanted to see if you observe any stale stats issues.