From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F33AC25B0E for ; Wed, 17 Aug 2022 02:05:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 85F3B6B0073; Tue, 16 Aug 2022 22:05:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 80E8B6B0074; Tue, 16 Aug 2022 22:05:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6FD648D0001; Tue, 16 Aug 2022 22:05:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 617AF6B0073 for ; Tue, 16 Aug 2022 22:05:32 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 3148D1A052E for ; Wed, 17 Aug 2022 02:05:32 +0000 (UTC) X-FDA: 79807442904.27.56ED2DB Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) by imf14.hostedemail.com (Postfix) with ESMTP id C4AD5100077 for ; Wed, 17 Aug 2022 02:05:31 +0000 (UTC) Received: by mail-pf1-f179.google.com with SMTP id y141so10901034pfb.7 for ; Tue, 16 Aug 2022 19:05:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=WA+jfFTow3ngSQMp6SitIm7gT1uGuNt3l+SXB6a0Mv0=; b=qiJV7zS6FtlxBFNHHOkR8rlWIt+MbyJaSUZ7NpnTAZEKk3nHle4ttU2ZB4kgF22Tkp S1dh0KV3aWiLTKjDLvp5WF4/n0wi7ubOMxjq3Jua8IxmsMwkY+MitL+3+BdnFXiyM6Z9 Vj0T8hQE/4mpvokMpNmQdkh7SXA9IajLZo+MwUAmTuIcVI4nVJ8pUpEAjS6jnjtKDzg2 KfpsFh/V5P1mzOUHQI1ya/3FWfExr2vTue9RXcqP853PYMeaZBfWhIJRrZFivOEYTm1X 51iS/vf6KroL/sTdqrHBgH4syYwukIfaJeH0Pju9b2qL7My1FFECbC+OzdyGnK9xCcJd ZDew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=WA+jfFTow3ngSQMp6SitIm7gT1uGuNt3l+SXB6a0Mv0=; b=ZIRC7erT5krrO52atZ7Ftfmt4McUbk4ZtWbScPmIMKG7JEWFCOfBKKFqb+x/YKveUj lW+fBKehjtroZVQSfYI88Fs0c4DnQCWdN0SjYcye59qdnY/6jiJ/kfMlwjKvRkRMYjRU Dft7whmJaa2A2jfdTDgKvCQg8pFESttno8fhlL9zOI6pvHogVbo9BuCJ9agHY34qQWQp JSyU3jATAoEutae0X1OtRanPcmWtKiCcW1g2Jtriduq+7rjxrNw6OaI7kq/gbTqJTuBp mbxMWlKkXoJnACLAmw3+L33VQkeJS3Xz6DctlTNOuq9kaViH5dU10KTOLRPZ+fBUN96D HXlw== X-Gm-Message-State: ACgBeo2mBbiRT18QwJxHLmBR5PORM97/iHhzqXRrR/OQlLkeB6HV223B lboFqqcbmNcO5fUNZrI1rTTmxrj33YqC2l0ZkOe7JA== X-Google-Smtp-Source: AA6agR56SZJVAe0VONCRXNBcbWnXoQC8KCMiqHyj8VVu1s+GNGs6+PkgKQ+syZgne8UIErFvB+6OwwRit1zFZgqBtow= X-Received: by 2002:a63:5f8e:0:b0:429:c286:4ef7 with SMTP id t136-20020a635f8e000000b00429c2864ef7mr1984263pgb.166.1660701930442; Tue, 16 Aug 2022 19:05:30 -0700 (PDT) MIME-Version: 1.0 References: <20220816185801.651091-1-shy828301@gmail.com> In-Reply-To: From: Shakeel Butt Date: Tue, 16 Aug 2022 19:05:19 -0700 Message-ID: Subject: Re: [PATCH] mm: memcg: export workingset refault stats for cgroup v1 To: Yang Shi Cc: Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , Andrew Morton , Cgroups , Linux MM , LKML , Yosry Ahmed Content-Type: text/plain; charset="UTF-8" ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=qiJV7zS6; spf=pass (imf14.hostedemail.com: domain of shakeelb@google.com designates 209.85.210.179 as permitted sender) smtp.mailfrom=shakeelb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1660701931; a=rsa-sha256; cv=none; b=FChwxI17mXsjkdtva3UrwjtuEQFP9QSwWGgCNcaSZWKYa1v064LcpP/tvj2I4coO5Mg/Lh f6C07zys3GW5I1Ug9jkT2TuEU++E/WssmWSZL9+u03Mr7nk4pf95twcDA6q6lnpl9acpho oZ4GP4dnbmMzEElpCgRii9+CfE/nvjQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1660701931; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WA+jfFTow3ngSQMp6SitIm7gT1uGuNt3l+SXB6a0Mv0=; b=j54VY7o8W9mfV9xsae7WxNtRgTpT5SaO0suOTmKDcnTLL3ghNQnST86sYdn/3ikbrO9ztq jLom8OLafIGyvsKKFsvSM0oPRcYKbEClaynx6E4PQNx0OisqksUkfiuxh1hcCSnZin9+ej iR0GAqIsr8odcb4xsF/O/jb1rDM4Hx4= Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=qiJV7zS6; spf=pass (imf14.hostedemail.com: domain of shakeelb@google.com designates 209.85.210.179 as permitted sender) smtp.mailfrom=shakeelb@google.com; dmarc=pass (policy=reject) header.from=google.com X-Stat-Signature: tpdsx5zqn1mqknbrra1amakfn4h4s8jb X-Rspamd-Server: rspam09 X-Rspam-User: X-Rspamd-Queue-Id: C4AD5100077 X-HE-Tag: 1660701931-591935 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Aug 16, 2022 at 7:01 PM Yang Shi wrote: > > On Tue, Aug 16, 2022 at 3:06 PM Shakeel Butt wrote: > > > > On Tue, Aug 16, 2022 at 11:58 AM Yang Shi wrote: > > > > > > Workingset refault stats are important and usefule metrics to measure > > > how well reclaimer and swapping work and how healthy the services are, > > > but they are just available for cgroup v2. There are still plenty users > > > with cgroup v1, export the stats for cgroup v1. > > > > > > Signed-off-by: Yang Shi > > > --- > > > I do understand the development of cgroup v1 is actually stalled and > > > the community is reluctant to accept new features for v1. However > > > the workingset refault stats are really quite useful and exporting > > > two new stats, which have been supported by v2, seems ok IMHO. So > > > hopefully this patch could be considered. Thanks. > > > > > > > Is just workingset refault good enough for your use-case? What about > > the other workingset stats? I don't have a strong opinion against > > adding these to v1 and I think these specific stats should be fine. > > The workingset refault is good enough for our usercase, but I don't > mind adding all the workingset_* stats if nobody has objection. For now let's just start with what your use-case needs. If in future there is a need we can add other workingset_* stats as well. > > > (There is subtlety in exposing objcg based stats (i.e. reparenting) in > > v1 due to non-hierarchical stats in v1. I remember Yosry and Muchun > > were looking into that.) > > The workingset_* stats should have nothing to do with obj based stats IIUC. Yeah, that was just FYI for anyone in future who wants to export such stat in v1.