From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88812C433EF for ; Tue, 19 Oct 2021 15:56:40 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 33EAF61154 for ; Tue, 19 Oct 2021 15:56:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 33EAF61154 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id BDAC5900004; Tue, 19 Oct 2021 11:56:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B8A9D6B00A2; Tue, 19 Oct 2021 11:56:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A7904900004; Tue, 19 Oct 2021 11:56:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0064.hostedemail.com [216.40.44.64]) by kanga.kvack.org (Postfix) with ESMTP id 9A3146B00A0 for ; Tue, 19 Oct 2021 11:56:39 -0400 (EDT) Received: from smtpin27.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 5877018029583 for ; Tue, 19 Oct 2021 15:56:39 +0000 (UTC) X-FDA: 78713639718.27.58FE912 Received: from mail-lf1-f47.google.com (mail-lf1-f47.google.com [209.85.167.47]) by imf19.hostedemail.com (Postfix) with ESMTP id 81483B000093 for ; Tue, 19 Oct 2021 15:56:36 +0000 (UTC) Received: by mail-lf1-f47.google.com with SMTP id x27so8485360lfa.9 for ; Tue, 19 Oct 2021 08:56:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=l6UyNWiQ7BoMTL4xhxCJx0qmxiRi5S2D6EPQ7sUWYlk=; b=l1QIf2HBZF5dgneEUJ+69UXIQWgsG1hl9tG/ALRoDN8uvKZfXJBoU7rsMJXh1lZNKI YfWcky8Vb3G7jm+T9EvQyUTFJRJDfeVk9V1z9uPGotOg3dNqVH5Sms9muEkC+aB640o/ +zO0gBrkElrNwfCX9Wm8SRmCUtd02uzXxst0MLpyhq1tPMmR3eq9Lt5pDtrAONArYcfw /+wKdCDEbw/h6gSy1jPKXHGRZW+ymnDaZ8hUuVR6ng5sgX0mldtc1Nrs7yeAFJFJ+9NA 6gpjJHnjAhj4qbVgNykcltsT2tasi1PyEyi307aIIyJsLAc06mFL3/Arxk8dIt8P7+bL xtZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=l6UyNWiQ7BoMTL4xhxCJx0qmxiRi5S2D6EPQ7sUWYlk=; b=FRUft3HlFcZe7woD1r1Eb9qSD6hxcXPwcksgX9+HDox4f0jDYrJeAqXG9B986ZVwn1 8Uwx/aOXVWrOz7SsiOI1EPQbZkOFDNy7Eho4AgPbH+g+L2TAjPn+qOAHj1BN7FzY1LKR vD5yGxoLrhE9QLODFbY3riTUW3rQo2YiO84AbcfEX0brUTfTWVu7PCFDv+dBjQixqJJp opIcenxzhWdlvuHBkNiI+WpddlVke9vvpgmoqj69M8Nyra4YNrxIJV0nTaq6kfCRvUsi +j0MZjSmxTcfr1b6J09JmyIFM11c8HjJAjjf3XKy5twzZa1fQRgEpi/7D4u4BwPSkjTz OXMQ== X-Gm-Message-State: AOAM533u5YtyfaMyv64NSl7PUvze0ODkvJTubEA0yr4RRe/Kl0ttKcyt 2u8yxyaEWWj0+6kc48Ez2l2nPoR4WqzrnpRUqU0Ndio0iRuf8Q== X-Google-Smtp-Source: ABdhPJwfXzNPMi50Z1j3h3lnLBVGHBeN9L+8DzOS23moli6FWtmF+LjZ7ijUdDpuzUZz5grrIJm7TkxrD+b1Q8WhkcQ= X-Received: by 2002:ac2:5e3c:: with SMTP id o28mr6663490lfg.184.1634658997345; Tue, 19 Oct 2021 08:56:37 -0700 (PDT) MIME-Version: 1.0 References: <20211018123710.1540996-1-chenwandun@huawei.com> <20211018123710.1540996-2-chenwandun@huawei.com> In-Reply-To: <20211018123710.1540996-2-chenwandun@huawei.com> From: Shakeel Butt Date: Tue, 19 Oct 2021 08:56:26 -0700 Message-ID: Subject: Re: [PATCH v2 1/2] mm/vmalloc: fix numa spreading for large hash tables To: Chen Wandun Cc: Andrew Morton , Nicholas Piggin , Linux MM , LKML , Eric Dumazet , Kefeng Wang , guohanjun@huawei.com, "Uladzislau Rezki (Sony)" Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 81483B000093 X-Stat-Signature: dnwtkcebgsuqpc8nnmbgjfw17opzn6ie Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=l1QIf2HB; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf19.hostedemail.com: domain of shakeelb@google.com designates 209.85.167.47 as permitted sender) smtp.mailfrom=shakeelb@google.com X-Rspamd-Server: rspam02 X-HE-Tag: 1634658996-800513 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Oct 18, 2021 at 5:23 AM Chen Wandun wrote: > [...] > > /* High-order pages or fallback path if "bulk" fails. */ > - while (nr_allocated < nr_pages) { > - struct page *page; > - int i; > > - page = alloc_pages_node(nid, gfp, order); > + page = NULL; No need for the above NULL assignment. After removing this, you can add: Reviewed-by: Shakeel Butt > + while (nr_allocated < nr_pages) { > + if (nid == NUMA_NO_NODE) > + page = alloc_pages(gfp, order); > + else > + page = alloc_pages_node(nid, gfp, order); > if (unlikely(!page)) > break; > > -- > 2.25.1 >