From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A08A4C433F5 for ; Thu, 5 May 2022 16:12:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0E16B6B0074; Thu, 5 May 2022 12:12:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 091D76B0075; Thu, 5 May 2022 12:12:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E733F6B0078; Thu, 5 May 2022 12:12:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id D47906B0074 for ; Thu, 5 May 2022 12:12:39 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id A754E2842 for ; Thu, 5 May 2022 16:12:39 +0000 (UTC) X-FDA: 79432182438.17.CDB8143 Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) by imf19.hostedemail.com (Postfix) with ESMTP id B1C581A0093 for ; Thu, 5 May 2022 16:12:32 +0000 (UTC) Received: by mail-pf1-f173.google.com with SMTP id bo5so4013202pfb.4 for ; Thu, 05 May 2022 09:12:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=JOg3JkIywRLzrPPGawgi8+ppo6ekCB8fiVEKfUdHYi8=; b=bQoc6U3SxwP0PLDXxVdqqhePzPc76Rf9CAYeT6a95TuwCPscQdatdnavfs9+sEDFuA p3rZyeAuQqJiMBN6peF93vd05yCGPXNj4V78HmPSInyZV2H91C+CpOJYjHq5n9ogs4Wq 1QVsNX3yw+iEWNAClXf5MVN3ViDAULifqYmqmyZJpC4K3jC0w7+UvEQ4hfYrYVyPC642 7Nwru5zmvGzc97KPaDQQ3DX+5WICrsIp/3jHcKn/sOem690fn62qi74MMmhCn5Mrz0Sf pocEv78vyZ7zQzsi0xJ5L5GbPAFPRTIHB6zPsGPTDuNDJY83edQsULVTvzQRv1FyJ0xa ZjSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=JOg3JkIywRLzrPPGawgi8+ppo6ekCB8fiVEKfUdHYi8=; b=lrFSmuwRjf5edCwvMhwDZ9vUPTG8nULLHvLs+Cvua7njctnKcNPTeFATaqtC7dDfdI kS4CKaBe2FuSJ8aQLu5QgTKBToMQJIKsgmVKZ8cscoYOQyt+VA4dM/LXlzQ4khprDQkw yfyfAwcUSlwfvstfI8HJSWKgNQuP7rhtgUbdCrbrehkht80ZTqPtMDmZVoOiD+CSKC+I TlFS2hvujkQcvLfwmyamn0QlUeFF1/2K38Vj6OkFlN8vgg+0tSwtmjAYWqUYfK3JknxE 1j890gxk8ol5Ys5g3IiOBI36hbgIpfhTkM/9jCNDdoWPhM0obmgxNHL0hMb8mUNeKdoM bwJA== X-Gm-Message-State: AOAM530Fs03R6U+SV/XyheVlZMXLUaKpV34GH6HojGsl70onv52ec+FM cJ54VUmnCMCAMjBIIDTc7FxXkUfkYuTwS9uThQQ26g== X-Google-Smtp-Source: ABdhPJwt8R0qqFEdfPp4xjRQYlx7+/QzN23NSOyJAtP1ucd4x7SKkS02w0EVQ9tWN674m9awAGDz5ZtA7fxuoG+LdZs= X-Received: by 2002:a05:6a00:2382:b0:50d:fa40:1077 with SMTP id f2-20020a056a00238200b0050dfa401077mr17326483pfc.8.1651767157870; Thu, 05 May 2022 09:12:37 -0700 (PDT) MIME-Version: 1.0 References: <20220505121329.GA32827@us192.sjc.aristanetworks.com> In-Reply-To: <20220505121329.GA32827@us192.sjc.aristanetworks.com> From: Shakeel Butt Date: Thu, 5 May 2022 09:12:26 -0700 Message-ID: Subject: Re: [PATCH] mm/memcontrol: Export memcg->watermark via sysfs for v2 memcg To: Ganesan Rajagopal Cc: Johannes Weiner , Michal Hocko , Roman Gushchin , Cgroups , Linux MM Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: B1C581A0093 X-Stat-Signature: s8oaycebfhyg1pk4xfryhp7eq95wc1mq Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=bQoc6U3S; spf=pass (imf19.hostedemail.com: domain of shakeelb@google.com designates 209.85.210.173 as permitted sender) smtp.mailfrom=shakeelb@google.com; dmarc=pass (policy=reject) header.from=google.com X-HE-Tag: 1651767152-303006 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000026, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, May 5, 2022 at 5:13 AM Ganesan Rajagopal wrote: > > v1 memcg exports memcg->watermark as "memory.mem_usage_in_bytes" in *max_usage_in_bytes > sysfs. This is missing for v2 memcg though "memory.current" is exported. > There is no other easy way of getting this information in Linux. > getrsuage() returns ru_maxrss but that's the max RSS of a single process > instead of the aggregated max RSS of all the processes. Hence, expose > memcg->watermark as "memory.watermark" for v2 memcg. > > Signed-off-by: Ganesan Rajagopal Can you please explain the use-case for which you need this metric? Also note that this is not really an aggregated RSS of all the processes in the cgroup. So, do you want max RSS or max charge and for what use-case?