From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BEAFEC46466 for ; Mon, 5 Oct 2020 15:13:17 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 33392208B6 for ; Mon, 5 Oct 2020 15:13:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="uN9au7v6" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 33392208B6 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 716306B0081; Mon, 5 Oct 2020 11:13:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6C7E16B0082; Mon, 5 Oct 2020 11:13:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 604736B0083; Mon, 5 Oct 2020 11:13:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0021.hostedemail.com [216.40.44.21]) by kanga.kvack.org (Postfix) with ESMTP id 3409D6B0081 for ; Mon, 5 Oct 2020 11:13:16 -0400 (EDT) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id C29F8824999B for ; Mon, 5 Oct 2020 15:13:15 +0000 (UTC) X-FDA: 77338215150.26.lamp02_4a11986271bf Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin26.hostedemail.com (Postfix) with ESMTP id 831C41804B667 for ; Mon, 5 Oct 2020 15:13:15 +0000 (UTC) X-HE-Tag: lamp02_4a11986271bf X-Filterd-Recvd-Size: 3517 Received: from mail-lj1-f193.google.com (mail-lj1-f193.google.com [209.85.208.193]) by imf11.hostedemail.com (Postfix) with ESMTP for ; Mon, 5 Oct 2020 15:13:15 +0000 (UTC) Received: by mail-lj1-f193.google.com with SMTP id v23so7745908ljd.1 for ; Mon, 05 Oct 2020 08:13:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=N5mMMKQazRXBuiw69rKSWjFNeXQ7ni4k4qAPZ1XO+3g=; b=uN9au7v6jFrynuxczUPp8JWygJ05kzcFUOGGGsLej2Q64usOPUEklYV3Jq84s9Y611 9ZQKrUABTdCwf/LNOgdp9G/BIzFOdf/raQ3EvGqDKJErsPYNrl9Rgj7LhctJl0rEQcMP j64/BDeokIqiVOC8Uf5+Y2ERFkD3ysja9tolYDYmWKfGayONDYjIdKsL7nhDP4i6Nixi vc55bAEGE+qMHqSN0O/UceRRIVBaXhMdPIufdTejG64EOu0/Myjvj8z8I9mC3ZS9Skao iFg5B7owCs1q29kMNrEAnM5ks90Dcej7sLB+dQN2/4SjAC8nb8H2kyyLMCk/W9D0ZzmX TAgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=N5mMMKQazRXBuiw69rKSWjFNeXQ7ni4k4qAPZ1XO+3g=; b=gHTkR0NA5uNGWpVQo8O/33BN2AiPdr4Kq+eFZTTdKfw0ALRFgkijaPACQwPZmV98tc 9NzepbLCGfXa9/d6Ji4ppAb5//cHh9R9L8pAjIU6/bGJ0JKnRKBJjAVPvypfON//OUoR Lma/a4i1rPVjj09uspDjvEEPIQAsktYQdYwsFJuf8NLoQq8TkzsZx6kL+7RlYOmcApla bCCu97l6ByFqgcOwGRLEuA/NtljckdKTKWBF0u0ms5WMnydBNu+2wIY98Yn5f9Tfhj3Y Msb8OrSm3FQJywOZzG7X2XrC0tBMg5CXSd+RhZN8w9qwxjxoP5IaFDtgg7Apqolu/bZU eAiQ== X-Gm-Message-State: AOAM530Dl5/zKeMtKA8JhPECVw/HGBtbbZAhAAWtlKUipYW/XJ+cDLb2 mPgwd5Tyt8ehnjOrDsUozgFnXlPjAA8go16YpWcUXA== X-Google-Smtp-Source: ABdhPJz6UYDVrlJ24vF9L5XVPqqmZT8So5ESBwUbAMJpb4LgG9A4EK9Po+XZyfaEwNRowqb9Wz8QmL89wMUq8s5I8ho= X-Received: by 2002:a2e:241a:: with SMTP id k26mr68125ljk.58.1601910793555; Mon, 05 Oct 2020 08:13:13 -0700 (PDT) MIME-Version: 1.0 References: <20201002172559.4000748-1-guro@fb.com> <20201002172559.4000748-3-guro@fb.com> In-Reply-To: <20201002172559.4000748-3-guro@fb.com> From: Shakeel Butt Date: Mon, 5 Oct 2020 08:13:02 -0700 Message-ID: Subject: Re: [PATCH v5 2/4] mm: memcontrol/slab: use helpers to access slab page's memcg_data To: Roman Gushchin Cc: Andrew Morton , Johannes Weiner , Michal Hocko , LKML , Linux MM , Kernel Team Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.013754, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Oct 2, 2020 at 10:26 AM Roman Gushchin wrote: > > To gather all direct accesses to struct page's memcg_data field > in one place, let's introduce 3 new helpers to use in the slab > accounting code: > struct obj_cgroup **page_objcgs(struct page *page); > struct obj_cgroup **page_objcgs_check(struct page *page); > bool set_page_objcgs(struct page *page, struct obj_cgroup **objcgs); > > They are similar to the corresponding API for generic pages, except > that the setter can return false, indicating that the value has been > already set from a different thread. > > Signed-off-by: Roman Gushchin > Acked-by: Johannes Weiner Reviewed-by: Shakeel Butt