From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D97D4C25B0E for ; Tue, 16 Aug 2022 22:06:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D82698D0002; Tue, 16 Aug 2022 18:06:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D31598D0001; Tue, 16 Aug 2022 18:06:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BF9C48D0002; Tue, 16 Aug 2022 18:06:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id ADD3A8D0001 for ; Tue, 16 Aug 2022 18:06:28 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 72740412CA for ; Tue, 16 Aug 2022 22:06:28 +0000 (UTC) X-FDA: 79806840456.24.AC0F5FF Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) by imf09.hostedemail.com (Postfix) with ESMTP id 1AF6C1401D4 for ; Tue, 16 Aug 2022 22:06:27 +0000 (UTC) Received: by mail-pf1-f176.google.com with SMTP id y141so10502694pfb.7 for ; Tue, 16 Aug 2022 15:06:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=xsBdI6TSxfWyoZQzEtdTKDjNFKRklp/Qj7KShglt0Qk=; b=hMnUic3qQq0HLIZNOhUZeDw6iBDDbHjQMKshXUA6XQtPWFUXR1pRy1CGLBGDulkZTt jJQMScRHIjExRTDpled6nwJp0I7Fz+e9Cp37Pxni6yVbKuv8ot4lSAvhj60c88kYBi3b U3xvmOupwH00xFmN6UgwXm4GJKN3w7/DaQfrPfaf5N7li637MndH2bJxJALWqB2hy3kT 0e8Uu8fXDQyUpj1ko0EBgsd5vjRjPCggF65QC83j9OqH+grhl58WqiAj35XPfpRNpw1u W+rA0vk2SVf8i3NlcOInp6GkfvXLQ3NquCSMzgPZpK8kJU9mFcDloCEkivNoEhDAYDqI idXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=xsBdI6TSxfWyoZQzEtdTKDjNFKRklp/Qj7KShglt0Qk=; b=tp8NybJZfJA9KvzeUHiU1I0sETtTFBMREp9GPyDn7mRe5JeOqL47RBTC8vgTifJAVW NuaaF3JUYgkI/H4ru/VMyyoc8X9+aKGt+/KV2osc5TGkgUZHa4yvpk5Tl0PxMm7cc5xx kX2lKURI3N17pWhkOQgKyc3oKHPz726A5JwuMvgbJYWM5TnxXshtE1XuTwa5YdlcWuOq A64HwhxtPMJCJfIkLZUVAqS5Kj/xUCfiV1F3sKc5NVeuOkq4t80LjzX2tpi+X9wJkQ5M 8rgi32qKQdueGZKB/R//6x7ZQ+EYICn8tadfxUaGed2bKpiG4jyd8Bj5DTG/FUTXT4Px hcYw== X-Gm-Message-State: ACgBeo1wa5Q4cXKNGsUBO4vT7gDc88EMRfTCXkyk5kRRTDIyH8aZXJjw ttTXu6qeeuSFeb0LlN6PRiOhGWDFhxrFwS2YWH7tiQ== X-Google-Smtp-Source: AA6agR66Eb2drsgo0xC0IsiAl2PXcMRX7zfibAHC48aSSjgpYKXqJIogSAcpz1yWsdrnwY/vgyl9I5HjpChP7FKsVkY= X-Received: by 2002:a65:494b:0:b0:428:d68c:35bf with SMTP id q11-20020a65494b000000b00428d68c35bfmr10005680pgs.509.1660687586695; Tue, 16 Aug 2022 15:06:26 -0700 (PDT) MIME-Version: 1.0 References: <20220816185801.651091-1-shy828301@gmail.com> In-Reply-To: <20220816185801.651091-1-shy828301@gmail.com> From: Shakeel Butt Date: Tue, 16 Aug 2022 15:06:15 -0700 Message-ID: Subject: Re: [PATCH] mm: memcg: export workingset refault stats for cgroup v1 To: Yang Shi Cc: Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , Andrew Morton , Cgroups , Linux MM , LKML , Yosry Ahmed Content-Type: text/plain; charset="UTF-8" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1660687588; a=rsa-sha256; cv=none; b=Bqjht9G9AOXvrWbrhY5yUotODAxa38hBxr/xowgOYMyIKkMvbuyhqV682jZO1KbMtaDzuL d3Tc5eJVacXLzQGOwYr31xdVJUHJszZ6hOciIhFobx6aa94s5VzCwVqiwzaq+1DTMk3dz4 DtcRjnCvmQdXPpS10pOwTa8mVwMrCP4= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=hMnUic3q; spf=pass (imf09.hostedemail.com: domain of shakeelb@google.com designates 209.85.210.176 as permitted sender) smtp.mailfrom=shakeelb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1660687588; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xsBdI6TSxfWyoZQzEtdTKDjNFKRklp/Qj7KShglt0Qk=; b=e080zGWgtEr971dBP410oWwpRanskfBgJIDFanNAq+Kwj5v6cF9ssJy+DerDIo2lYZ3fjb N5Uw8UyJn3aE0mwbKdZz6OrFIx7oQsYnQq2vLLtfEFrv3WZBSL6Aj1oc15rbZt8YCE+nWf lE8r6KyFpETy+dz0069uwx6UIX4L6cc= X-Stat-Signature: cxoha5ee5tu7eby4taaqep16rubemxwn X-Rspamd-Queue-Id: 1AF6C1401D4 Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=hMnUic3q; spf=pass (imf09.hostedemail.com: domain of shakeelb@google.com designates 209.85.210.176 as permitted sender) smtp.mailfrom=shakeelb@google.com; dmarc=pass (policy=reject) header.from=google.com X-Rspam-User: X-Rspamd-Server: rspam03 X-HE-Tag: 1660687587-692966 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000004, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Aug 16, 2022 at 11:58 AM Yang Shi wrote: > > Workingset refault stats are important and usefule metrics to measure > how well reclaimer and swapping work and how healthy the services are, > but they are just available for cgroup v2. There are still plenty users > with cgroup v1, export the stats for cgroup v1. > > Signed-off-by: Yang Shi > --- > I do understand the development of cgroup v1 is actually stalled and > the community is reluctant to accept new features for v1. However > the workingset refault stats are really quite useful and exporting > two new stats, which have been supported by v2, seems ok IMHO. So > hopefully this patch could be considered. Thanks. > Is just workingset refault good enough for your use-case? What about the other workingset stats? I don't have a strong opinion against adding these to v1 and I think these specific stats should be fine. (There is subtlety in exposing objcg based stats (i.e. reparenting) in v1 due to non-hierarchical stats in v1. I remember Yosry and Muchun were looking into that.)