From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6010EC7EE22 for ; Thu, 11 May 2023 17:10:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B371D6B0072; Thu, 11 May 2023 13:10:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AE7AB6B0074; Thu, 11 May 2023 13:10:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 987DA6B0075; Thu, 11 May 2023 13:10:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 851C36B0072 for ; Thu, 11 May 2023 13:10:42 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 57A2580D42 for ; Thu, 11 May 2023 17:10:42 +0000 (UTC) X-FDA: 80778613524.19.F3F64B5 Received: from mail-qt1-f170.google.com (mail-qt1-f170.google.com [209.85.160.170]) by imf29.hostedemail.com (Postfix) with ESMTP id 642EA12000A for ; Thu, 11 May 2023 17:10:40 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=nMaXyqyp; spf=pass (imf29.hostedemail.com: domain of shakeelb@google.com designates 209.85.160.170 as permitted sender) smtp.mailfrom=shakeelb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1683825040; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DKdPt1RaUkWe8+eoJAPYnUVWfgFKro3FnMuByj1EFEU=; b=rb4PdapDY1AOp8nwUrjqHMSGTWXM4BDadm/qyfjuiqhtTlYUzEPrUgh6YEQkCF7rebyqx1 Mrrx1cUJT9vEyMgsEV9vdbfqvEhyTpjVL2gSKAAjfWEipBS75MjYqZQI/brOsqWehOm/fv MX5UL5DV//YC5aWPSpoFyZoeAHV8Jeo= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=nMaXyqyp; spf=pass (imf29.hostedemail.com: domain of shakeelb@google.com designates 209.85.160.170 as permitted sender) smtp.mailfrom=shakeelb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1683825040; a=rsa-sha256; cv=none; b=ZT6hL2vN5u3k31mAimXd6DabqfTGf3lBcEG7B409Qi60Aurj2rKMrjtlYPuDGkYPhMVmHx MbCF8EcOLzbKKg+/3cpH1E5CsjHBfBdvXQdQWZt1ZFzjo1nOsmQAyzyL7Y2j3tVsMKIOXJ OaS7dYX9GLC2tR55TYCgYeSl7bLU16Y= Received: by mail-qt1-f170.google.com with SMTP id d75a77b69052e-3f38a9918d1so793101cf.1 for ; Thu, 11 May 2023 10:10:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1683825039; x=1686417039; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=DKdPt1RaUkWe8+eoJAPYnUVWfgFKro3FnMuByj1EFEU=; b=nMaXyqypHxPLcxqTJyoCXYG5PeO32ubse8ArHPkY7RDeIj41LN5gMmyL7Ac6dVzFZ7 ZYsaygJet/Hh0cPTxWS+w/TorbpHNOudoOCWWvZYZnP7YjntjqS2vG64aKUfM9l7X+FF szXnzl+jFkr+JYMupJ3DNTQHVvGEygGe/nzzvC3TnnfYnfbGVzKYI+ZYmr6YtCTY7dv/ xP2Nkwrzf9OcT4F1SVRzG9y5DNHc+Ym1rdaz3WmyeOF+N68nDo8FWm5t2BEEgjwBEkqw BfyFN6ArnSBxwav+9BJ9XVHl2wCN5uN9vTchbBWjiZdITpYpyhiYpvWcAnK75GYRAy6A t6sQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683825039; x=1686417039; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DKdPt1RaUkWe8+eoJAPYnUVWfgFKro3FnMuByj1EFEU=; b=XbaL6xYWV4icBrlgLzuVkT88XrRHE3mjd7toT7788ebtGI9uXCyHtAqTweoXQ6dVOZ 3s3LiIndo0VB8MvmoxoLoGKvp6oehAeDVVxTD5F2I3Yw8TqLXVhP201gyawFr7SQtSvq 2bi+XC6CTCdWuXMPZicF31VpillrwlGw+h9zvVYo68mjdUpsuGc9LPUaDUIE+nGi4jwK KrpSPgQAu6oH+qboltWI3FNhF/LHOlhrzTFyHPBqgnYBqzMi1fphGsPjJm7ZYDmU0hln bRPEP8N4zPN9SOCqmoqYuhCG8Q/GJo3hBwUpEHumNvr/pxr9Z8cd+lxr/xImjgiaski0 KjbQ== X-Gm-Message-State: AC+VfDy2pMB+rbBiRkrRo59mAgEDiYmKc+VrFdbYN3q4pmHX9ZM9yyab s3RVqUhCgigMUF7SrWuht9mdtW5Yeo/6/FNMp7hBMA== X-Google-Smtp-Source: ACHHUZ72Zw3GmxCRU2ZaY86LgkadjB4mn+Ucm1AlZWq3wRc03x5tQHjXd5p53hpYmdX5ou16duANvsOJUXYCZ5d/6Is= X-Received: by 2002:a05:622a:19a0:b0:3ef:31a5:13c with SMTP id u32-20020a05622a19a000b003ef31a5013cmr76533qtc.3.1683825039339; Thu, 11 May 2023 10:10:39 -0700 (PDT) MIME-Version: 1.0 References: <20230508020801.10702-1-cathy.zhang@intel.com> <20230508020801.10702-2-cathy.zhang@intel.com> <3887b08ac0e55e27a24d2f66afcfff1961ed9b13.camel@redhat.com> In-Reply-To: From: Shakeel Butt Date: Thu, 11 May 2023 10:10:28 -0700 Message-ID: Subject: Re: [PATCH net-next 1/2] net: Keep sk->sk_forward_alloc as a proper size To: Eric Dumazet Cc: "Zhang, Cathy" , Linux MM , Cgroups , Paolo Abeni , "davem@davemloft.net" , "kuba@kernel.org" , "Brandeburg, Jesse" , "Srinivas, Suresh" , "Chen, Tim C" , "You, Lizhen" , "eric.dumazet@gmail.com" , "netdev@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: t4nggepg91cb7fs9iucxobixzwitnb84 X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 642EA12000A X-Rspam-User: X-HE-Tag: 1683825040-375598 X-HE-Meta: U2FsdGVkX1/UwnOTk2e2a76U9eyP06zz6jhoZ4lqAqLfmRE9+rQTzMnyCgZ1zOrtJ1ShhR5gLzpyTDy7TxnpSP440D0ZTCf3apRL0VSLOIQpJoNEeanHDMV2qh1DZ/Zkbwc4NR1ss2oA+fNMggqjavVf3Zo1sEyXkfqDcnreCsvUCYKKLDb0hLBmtkAum3x95cw+h7AOQSgG6wT8QaQ2N/T8aQ7XU8Z3l/s2eNk+i819VIecXTX5tNY6vtKdNwiXR/8x7JnQapaPt/bO3pkiNJdzhRRBHiFLUOZWFvllN/1osUtMI48C1sgOYlDzXszRIsFz9+LjTuueWH8WxosSVi/5wXGwhVrAQNEPN8rztMLUlafP1z0nzWbrDx5wRbDll32y+NqgLOeSUXhmjvPtnxb+5JyZzu7LA9izLcxwwJx85VDLcQiVAeSJgjWXYtDB2MAjtOAB2mJBEJ86v5/PfgRwRAZu6K/Ypzbi+dg1YhXSnOOFTBfSNB/rmSY/w+RvxVHHQVQ81UiKkqwrsiABybhWHAjEaPp0TiyLYLmTblNJOwYP077nikFr7SVL3O3me+zXogqCPls1Q3+EDy41YZL1RtDWp0Z7/BI2zse3M9JB5g8wI0c8shRzofnIiHR1JTDqFopeor0qfw0W6fjQPMCE9kS601aAh8Eecx3CLqSGo/lF4ranCt20swfBAZVTGbUsATroWPv1BVRRxmk5a3/BkN91c0PkcPgraqut+mAhh4X8P8+shgeORWjrIGVKrMBdsNKntmGcofeRI0wF2ZMGe+9N4AcVdqZ5za+vkcVm5BeWtvvUJWhWVO3CFqdwBRCqPzQxUnxO75YCdZ7RmieReREtavNjF9rzmcz/d0qFJ7XJueN7woXFreClSEi+NcYbmdIEZKcY9e3RJJFxbG1ggcbtWpATMHWU4DQD6qv/jJvsefGW7+uZcZJfjMT88FuouXG8ACwPauC3uXK 8+VnRxUJ R5Z4HUnRdVCMHkG7onzSMBzjFKza8G2q/Ds16jikUp5IiMjHtjwqVc+j0/GESNwak1Qxb0q0VZyJ+0XZqC4KXeY/F6smpX9PAqu4fZ9vk/Kr3+8rXOSejtCJiRhDgVHhuk6o34RaBynWSlHHlTDcI6iZwEqwIko9grkkq5XWG/IXij1ezb3QOGxNBih7XS3L60UpKTQMLnXALMIZ1XYLumhns7ypD5QQ6w2J2NyM1jf21X/y9qpCvxfaBhV5d/KKkmnf0zqB5jocZ4gN3TQlx/viUX0r+wV+HqZXzPmRRjNnr2xgmWq/7+kW634zrSibykSJJ9ck7GvFgl8Yx06iClVHJGDxrHXZtzraGwhX8/PsC7Gx6DDDR9mOv87fuzi20xvt27/qQzuVWH65eu1hNFQeEaQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, May 11, 2023 at 9:35=E2=80=AFAM Eric Dumazet = wrote: > [...] > > The suspect part is really: > > > 8.98% mc-worker [kernel.vmlinux] [k] page_counter= _cancel > > | > > --8.97%--page_counter_cancel > > | > > --8.97%--page_counter_uncharge > > drain_stock > > __refill_stock > > refill_stock > > | > > --8.91%--try_charge_memcg > > mem_cgroup_charge_skmem > > | > > --8.91%--__sk_mem_raise_a= llocated > > __sk_mem_schedu= le > > Shakeel, networking has a per-cpu cache, of +/- 1MB. > > Even with asymmetric alloc/free, this would mean that a 100Gbit NIC > would require something like 25,000 > operations on the shared cache line per second. > > Hardly an issue I think. > > memcg does not seem to have an equivalent strategy ? memcg has +256KiB per-cpu cache (note the absence of '-'). However it seems like Cathy already tested with 4MiB (1024 page batch) which is comparable to networking per-cpu cache (i.e. 2MiB window) and still see the issue. Additionally this is a single machine test (no NIC), so, I am kind of contemplating between (1) this is not real world workload and thus ignore or (2) implement asymmetric charge/uncharge strategy for memcg.