From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DDB69C4332F for ; Tue, 20 Dec 2022 19:55:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3F3598E0003; Tue, 20 Dec 2022 14:55:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3A3648E0001; Tue, 20 Dec 2022 14:55:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 26AD68E0003; Tue, 20 Dec 2022 14:55:48 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 148D38E0001 for ; Tue, 20 Dec 2022 14:55:48 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id DB16F160225 for ; Tue, 20 Dec 2022 19:55:47 +0000 (UTC) X-FDA: 80263739934.07.332BF19 Received: from mail-yb1-f179.google.com (mail-yb1-f179.google.com [209.85.219.179]) by imf22.hostedemail.com (Postfix) with ESMTP id 5CE98C000F for ; Tue, 20 Dec 2022 19:55:46 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=KSZwcjFT; spf=pass (imf22.hostedemail.com: domain of shakeelb@google.com designates 209.85.219.179 as permitted sender) smtp.mailfrom=shakeelb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1671566146; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=T6Ibv8lELNGtBRxXq2xqbZ6XNIWdISjKd5l36khEMAE=; b=Nn6r5qB7SsY7n/unzAosAj6KnjK4t0m/Z+hq4ncwPtU3IzMuRQ0c7i4bIaZ+wkmwx2pWsW FnAXG0/NmhO5g8ybV3nWpt+HnfGN6c1isusatj2E0WYR9MaDgPnEfHWDpWD7txByPv2o2Y wnKk+JjKvbPkGgyycPtPboBRb4p0UNI= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=KSZwcjFT; spf=pass (imf22.hostedemail.com: domain of shakeelb@google.com designates 209.85.219.179 as permitted sender) smtp.mailfrom=shakeelb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1671566146; a=rsa-sha256; cv=none; b=aUkvPIYJGVmw4yU/E6zSz2ZKhMaPV8qdEVKc1xEcSy3dqcOHjmmWdetwHpHph3pqZ9MZ5K uH+bkUaVZUaSXdlQKMZxNRhkmdI2cRmpOb1z96wIVAW46CBeM8rE1fkX3L9pQoV28UfCN6 b0M0WximXSa783lYwoiic5wfm/NItHU= Received: by mail-yb1-f179.google.com with SMTP id 186so14154830ybe.8 for ; Tue, 20 Dec 2022 11:55:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=T6Ibv8lELNGtBRxXq2xqbZ6XNIWdISjKd5l36khEMAE=; b=KSZwcjFTFFO55WSmVmRgONnRwskWoYawCL4xr2GcTp5EfCyO5dWsx7AbSD6Ir/ybby C7hVXroJGbjMZ6JZecHbZizIkqMntO9LCfTQjh70KYV62x3n7GT3pigY+IdDXJ6+hW0U mEwxE2cJuzhZ473p3CRLSLMKt5y1k+WqODiXLaurmLprlQIu83KIRui/7aB62vVSerFG oJ6BbA0p2cayN9RAavaPE83CL3JFmwg8mr83/EY4R4NMFXcDSamu5fqDMXFsJi4+yNTL KYFBpfYMu9bW5ttoTGe9B6d7fqichfkqe1iiFZLjZZbtB+BAkuBEyxDREF+RcnvyviBH sPNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=T6Ibv8lELNGtBRxXq2xqbZ6XNIWdISjKd5l36khEMAE=; b=EYW6GMs4WS/0mQvF9+CtjDsetCwbxk1FOZBSlKwHLm7PPOdUE+4ya7lw9aMwGWIzWk LWC7/UkARZpjsSnsCNO3BRHbr8ldFduqAorFYNVPJntfNxy9YnRYI9uiUAcsvJ4hvRQ0 cdSGaKljF0/1wlBQgiqymgdxiIFnaWHv+HvIlXjcZaRFAgXItuiY3J0zpGb7B2YAseQB gJlKmjsAFyx4Uihy9UUhs4N4y40Rtq+AG/C1jmXvEj8z3cDE3ZYE8/9v2z7apV8lLXRc ht/icoBd3ERVZOZv1eOUWzY8ch7pn0vBUkpwINLWxWIiNJoDYzJYQujGVFfSEHFM3TQb w46g== X-Gm-Message-State: ANoB5pnSUeM7Qc4SvbzxbqdKWw8ep9QjrWMWCMpTBuTLxP52Wwqg4WMC fkzE7DxV6hUOPvPNjI0FXismNN/lDklnUb7rYCjvVtSeG5PqdA== X-Google-Smtp-Source: AA0mqf7NCtlgUgNd0Hd1SP3QL7km2fBfAOvVUDERTH4v4MYwU6+4xOVJ3IJ4IDEzTj4uQn7xjEc4O/4GfJxHa4RW258= X-Received: by 2002:a25:5047:0:b0:70b:e651:d1e6 with SMTP id e68-20020a255047000000b0070be651d1e6mr6047265ybb.363.1671566145422; Tue, 20 Dec 2022 11:55:45 -0800 (PST) MIME-Version: 1.0 References: <20221220182745.1903540-1-roman.gushchin@linux.dev> <20221220182745.1903540-2-roman.gushchin@linux.dev> In-Reply-To: <20221220182745.1903540-2-roman.gushchin@linux.dev> From: Shakeel Butt Date: Tue, 20 Dec 2022 11:55:34 -0800 Message-ID: Subject: Re: [PATCH RFC 1/2] mm: kmem: optimize get_obj_cgroup_from_current() To: Roman Gushchin Cc: linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, Johannes Weiner , Michal Hocko , Muchun Song , Andrew Morton Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: 1j88izp1hz37w5id7sq9zci4xsbxrgbb X-Rspam-User: X-Rspamd-Queue-Id: 5CE98C000F X-Rspamd-Server: rspam06 X-HE-Tag: 1671566146-858353 X-HE-Meta: U2FsdGVkX19JKA4mOa06hYIFN6xEloCCkHGFji8zfXM5X1NGx/jW6A+rmt/BvOgqBxZCBzCigBE/OQFT5TZXNfBVkz7mFXwThm0Ygj+xQuBhVQKbdFxqJFvOhrCw2Mtol5dlNNKFCX25zUZSFXyVo7stGwK9OmFQtRDmBNIZSrfJMcfM6CdcwPlOoTy0Wg9xh76MSnVfhwVrhsmuga+DwV4Ye194XJFdQi8cH0lUlVsaEZJTCjA2nH/tGGe4dM/tXts5ouuK5UGJktJ2VwIR8usppoZawNY9023nOEXPmQxzZYrB6QZgTnddgg6Wmv49vXXU4SKmtKKujUdhd0b3dNmizTgJe8lMD1okzhQISJJb9EG7CyDZ4UgPTs55+MK9q24ZK0J8Rwq3ClxKM8+6lO3yCGIyG2If8ehJnrg5Nv9XBQd5e1ACpXt+hXSWFH0p6kr/wtu6Ve76HwcoB3c55b9nWUX/YGkhNK9thh8cb/7f5ddLo8+oyeiyWG0REp8mh3KdE/mpPU0spqLWf0DpBYnb3I6ZyL8DhM5GwgonJxcMQff1M3BsRx5kI2yLsL18UZOnFD17cbrkbHTXGA3eEt0TYBtPRSVrHiaWqhCKEvkQlhli/Fr5OSdbRfhHoPO2EPgI5Hsjf7ZB3ezT8NdC/kXZVmA17V2OdXUNYHEcAnaQmy2Jzw69RKuGPeZlCuXIwUHKEGPWxBh83NsStTrANAMZI4blMDaNEYtMiDDT5FrZ5q+wzh2M4sHDy3YQdboY3uIJuFWmJKbv5UYLnvh/2AMZ3NaQCusynLagBsv5JAhiymWgZhW2gFB/6IdS3Hzp3XAqLnFyagRrfgv2e2NNzHGcWrYLC/3jk7ZK+1XmpuNGPl0HS9DvxYiNd/qEDOEuuzMASBhU1ENnOId/NhVEPdQ1YT/WbEP8fvadDbZr/HIz2b3qflqWnoHtLSGI6borQpp6sYLJkMbuT1U1dE0 rRETWLG4 aIdHFjSex+fzH5MhZk24w5aSFAgtytNYNJ68lihZnw928+JZdya9B0WTXlA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Dec 20, 2022 at 10:28 AM Roman Gushchin wrote: > > Manually inline memcg_kmem_bypass() and active_memcg() to speed up > get_obj_cgroup_from_current() by avoiding duplicate in_task() checks > and active_memcg() readings. > > Also add a likely() macro to __get_obj_cgroup_from_memcg(): > obj_cgroup_tryget() should succeed at almost all times except > a very unlikely race with the memcg deletion path. > > Signed-off-by: Roman Gushchin Can you please add your performance experiment setup and result of this patch in the commit description of this patch as well? Acked-by: Shakeel Butt