From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.2 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15067C2D0E4 for ; Tue, 17 Nov 2020 17:17:04 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8A3F324655 for ; Tue, 17 Nov 2020 17:17:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="ZlAxl3QD" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8A3F324655 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B513F6B0074; Tue, 17 Nov 2020 12:17:02 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A652C6B0075; Tue, 17 Nov 2020 12:17:02 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 86BE66B0078; Tue, 17 Nov 2020 12:17:02 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0029.hostedemail.com [216.40.44.29]) by kanga.kvack.org (Postfix) with ESMTP id 46B346B0074 for ; Tue, 17 Nov 2020 12:17:02 -0500 (EST) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id A53A73626 for ; Tue, 17 Nov 2020 17:17:01 +0000 (UTC) X-FDA: 77494565442.17.silk83_0904f9d27333 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin17.hostedemail.com (Postfix) with ESMTP id 88DBC180D0180 for ; Tue, 17 Nov 2020 17:17:01 +0000 (UTC) X-HE-Tag: silk83_0904f9d27333 X-Filterd-Recvd-Size: 3301 Received: from mail-lf1-f66.google.com (mail-lf1-f66.google.com [209.85.167.66]) by imf44.hostedemail.com (Postfix) with ESMTP for ; Tue, 17 Nov 2020 17:17:01 +0000 (UTC) Received: by mail-lf1-f66.google.com with SMTP id l11so19091721lfg.0 for ; Tue, 17 Nov 2020 09:17:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=HbXTqX8J4PNdelvJC4wHhXHHnug3DEmJJtNJ9Q3CjN8=; b=ZlAxl3QD0Xa5p3JWtOf5QE0KHmZLFmGRQGLhbQLuLtJ8Oi0cUc+DIvI6G6L0gBUaD4 0DmGd8Zfrj6WKdu80A9T0yOKJlXc1SDZxfs177XMqfdFDp6OA4JwaWy+Kuru5FQaNUE3 sZQ0i5Ip2gKp5lDE0VBiTSp0Sn9Cp8GmWvG7uIV+KWpu7vIyERScAzNPZHkK9QljfWWu xM3AFr5VcMMp5CSLJaB75eI/zbsXQkmGzExREmOUFslWDMK/lUCo4vi/x13jo0SiOyBS RyFiihPVhI2NL4+aX/THKDerRaFF/sBunp2L/1BgvQmJf40U9iPFVo1YfVB0ylGrKsOI YFIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=HbXTqX8J4PNdelvJC4wHhXHHnug3DEmJJtNJ9Q3CjN8=; b=YU0psbPn91rmvmtYlfd3zu5Zi0w5lxc4xKaW+EjE7V7hS+dyoVO6GZO4/myz2cVx5C D2P52LqDB9w3vV7qLaT55Vsce+9BOEaXv7t9jZpv4TgBqCPAQCjZ6OnVfI4TIMq2qqda osSlnwnwpwqQNVEBYOme5c0M8/ba7gOIitANE/9mkVaGjIl7N+kpqWLLHihDUu52ydPG pVZipWgtz86kWq2cFlTKIBFXLR3W2ZFVI3AA23ETcFwJbdbReB9B7JSKfoH9hU22ZwL+ lE08cRuW/OQVqeypZLPUdfdqecppGLxi2UyA4/zUk1sQyZyiwfpp7Crtw1xsAiJ6aoA1 yrUw== X-Gm-Message-State: AOAM530Ac+XmVnrumSn7h7EJFFE82/JCngUD2BwxN8mDCDhM0DfY/OOJ 6lmiWTI1AsIlaqx8h+3QxnqFYVSJZiMFtH1rhE36hg== X-Google-Smtp-Source: ABdhPJwVhpHrOXeGdSRSaP8iESNSjM3x3QcHIw7D8pa+PWkuVXlktckRJGWeJI7X18+aeytBGdNUP31yey8rVETh/Mg= X-Received: by 2002:a19:cc42:: with SMTP id c63mr1938796lfg.521.1605633419249; Tue, 17 Nov 2020 09:16:59 -0800 (PST) MIME-Version: 1.0 References: <20201110195753.530157-1-guro@fb.com> In-Reply-To: <20201110195753.530157-1-guro@fb.com> From: Shakeel Butt Date: Tue, 17 Nov 2020 09:16:48 -0800 Message-ID: Subject: Re: [PATCH 1/2] mm: slub: call account_slab_page() after slab page initialization To: Roman Gushchin Cc: Andrew Morton , Linux MM , Johannes Weiner , Michal Hocko , Christoph Lameter , LKML , Kernel Team Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Nov 10, 2020 at 11:58 AM Roman Gushchin wrote: > > It's convenient to have page->objects initialized before calling > into account_slab_page(). In particular, this information can be > used to pre-alloc the obj_cgroup vector. > > Let's call account_slab_page() a bit later, after the initialization > of page->objects. > > This commit doesn't bring any functional change, but is required for > further optimizations. > > Signed-off-by: Roman Gushchin Reviewed-by: Shakeel Butt