From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6CB20C388F9 for ; Fri, 23 Oct 2020 00:00:12 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id CFE9A24650 for ; Fri, 23 Oct 2020 00:00:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="guRkvILP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CFE9A24650 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 381F66B005D; Thu, 22 Oct 2020 20:00:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 331CC6B0062; Thu, 22 Oct 2020 20:00:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 26FED6B0068; Thu, 22 Oct 2020 20:00:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0038.hostedemail.com [216.40.44.38]) by kanga.kvack.org (Postfix) with ESMTP id EDEBB6B005D for ; Thu, 22 Oct 2020 20:00:10 -0400 (EDT) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 88E32181AEF00 for ; Fri, 23 Oct 2020 00:00:10 +0000 (UTC) X-FDA: 77401232580.17.owner12_3b0b6f827255 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin17.hostedemail.com (Postfix) with ESMTP id 6F374180D0181 for ; Fri, 23 Oct 2020 00:00:10 +0000 (UTC) X-HE-Tag: owner12_3b0b6f827255 X-Filterd-Recvd-Size: 3664 Received: from mail-lf1-f65.google.com (mail-lf1-f65.google.com [209.85.167.65]) by imf07.hostedemail.com (Postfix) with ESMTP for ; Fri, 23 Oct 2020 00:00:09 +0000 (UTC) Received: by mail-lf1-f65.google.com with SMTP id a7so4397478lfk.9 for ; Thu, 22 Oct 2020 17:00:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=iDXB6MzIAjPa6Z+bYdtdThdhAzUe/hH836F46Z6tXhw=; b=guRkvILP5wkBF+Y8oh3Zj7febDKb+DRU+Ww1jYwe0hatSbkoSvbf2KK84bXYRPYpEc UcIAxUjcnJZrINp5BGV6sKtKGNlAG6k3n3FkO8x4H/85YVV7SR/705oDXmT5x3d0yhVZ mG6PuVtvKHPX8zk3WDn7PAnWbJx9bjuy7E08MCpKuK2f7ke3p5BXY9C2tUa6TY/xPrMM 8qsv+MYRUGERFLfHpupKVI1x3jOXVV9VUezVFFIPeMf+nK0oIbHJevGLpn5M5RnUCXqI FgiXurXdocx0CUIqiFWILkvklKd3RHDh47dcC4y37Yo+GN5Ns+yckbpjeJjxnoSZ8MRo pzpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=iDXB6MzIAjPa6Z+bYdtdThdhAzUe/hH836F46Z6tXhw=; b=Yw38YmW7Mtz7KlUZfhY64r7tdyNKG2//M66nIujdPvGQh8dbfG6Y/3aaLszjfYfv2D i4KgU12kIdQwz5x9w7xnvs4Sz4ZW3I3V25urEcnqnTPoMtD0cAP1CeFPhilIiEjKLgOV sOqwl1U+sGHp01OwsqkNtceTOpvw7WWw+706AgMiQYqcmMtPoJhOzYLFkUlS6Ivn6Z0X WPIzBGYCFvgvjIib+7nOa8/V1pxYF4HRMTMzd4UwsVJxohWJF5+FR+OHwG3JhwIg6jHD J25CVCjSlO/65KsC22Kb81G2ufmp29lyDb+aBvEmmgPtb72nKia47+/Avv14vRT8k6ym ROdQ== X-Gm-Message-State: AOAM5319rZU45nt6dxDXYc+1zd6QaQPDZk87JaV4oe+hcv6F+NHayVfQ PcH9GIhw3h6abNiu8m6dGg45mWjBw5YUXNquacvq2vPcX2k= X-Google-Smtp-Source: ABdhPJzuULwrnVGAGtEgdR0cHZymQzvgHmTA54WaDGuHfGCXTVu1rVTxbqmOoQxfxggqrA9eJa1zXMFPgmAY7VgAR18= X-Received: by 2002:a19:7ed8:: with SMTP id z207mr577866lfc.54.1603411208087; Thu, 22 Oct 2020 17:00:08 -0700 (PDT) MIME-Version: 1.0 References: <87sga6vizp.fsf@suse.de> <20201022122858.8638-1-rpalethorpe@suse.com> <20201022172508.GF300658@carbon.dhcp.thefacebook.com> In-Reply-To: <20201022172508.GF300658@carbon.dhcp.thefacebook.com> From: Shakeel Butt Date: Thu, 22 Oct 2020 16:59:56 -0700 Message-ID: Subject: Re: [PATCH v4] mm: memcg/slab: Stop reparented obj_cgroups from charging root To: Roman Gushchin Cc: Richard Palethorpe , Linux MM , LKML , LTP List , Johannes Weiner , Andrew Morton , Christoph Lameter , Michal Hocko , Tejun Heo , Vlastimil Babka Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Oct 22, 2020 at 10:25 AM Roman Gushchin wrote: > [snip] > > > > Since bf4f059954dc ("mm: memcg/slab: obj_cgroup API") is in 5.9, I > > think we can take this patch for 5.9 and 5.10 but keep Roman's cleanup > > for 5.11. > > > > What does everyone think? > > I think we should use the link to the root approach both for stable backports > and for 5.11+, to keep them in sync. The cleanup (always charging the root cgroup) > is not directly related to this problem, and we can keep it for 5.11+ only. > > Thanks! Roman, can you send the signed-off patch for the root linking for use_hierarchy=0?