From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8AE6C77B73 for ; Thu, 20 Apr 2023 18:55:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 09932900003; Thu, 20 Apr 2023 14:55:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 04966900002; Thu, 20 Apr 2023 14:55:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E5344900003; Thu, 20 Apr 2023 14:55:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id D3995900002 for ; Thu, 20 Apr 2023 14:55:54 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id A2D9E1C64B3 for ; Thu, 20 Apr 2023 18:55:54 +0000 (UTC) X-FDA: 80702673828.09.2B6B5EA Received: from mail-qt1-f182.google.com (mail-qt1-f182.google.com [209.85.160.182]) by imf17.hostedemail.com (Postfix) with ESMTP id D0F5240013 for ; Thu, 20 Apr 2023 18:55:52 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=oa5zJsQr; spf=pass (imf17.hostedemail.com: domain of shakeelb@google.com designates 209.85.160.182 as permitted sender) smtp.mailfrom=shakeelb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1682016952; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hbCxu47aXqOZFjOgElAuAaCkhQzE3b3RJfWYjmehSCc=; b=62aviq3bZUF6Q7T447XWB1U9M/R4bbv5gpG2tzF8RSeBROjYSToFhx/GzLpLt/isGMzuuT b8SPP1d9wM9ACBwYWtZA+YbPkNpbmN3yDE6kBNsqm3jVJ93Tw3rnpCd0uUxk/rioHFWNps TNCnPPd/Ci0DXQbY5ysZHzIY/sGQARw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1682016952; a=rsa-sha256; cv=none; b=6sx378GuyLDVJTJdW0SvSnQ7Gh4UAX3nnj522ytwxwbCqYGDjeus5w/+xXZrynxoWprKTW mzo/OB6ROpRgqfV1I86zq9RFEvYTBVbjmVH00G1LEaH7DR53tfiK4fifStye2XVRIvlQes sSvi3kjA1Z3RxDZmhUnWiM4rJM/k1Io= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=oa5zJsQr; spf=pass (imf17.hostedemail.com: domain of shakeelb@google.com designates 209.85.160.182 as permitted sender) smtp.mailfrom=shakeelb@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-qt1-f182.google.com with SMTP id d75a77b69052e-3e0965f70ecso895961cf.0 for ; Thu, 20 Apr 2023 11:55:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1682016952; x=1684608952; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=hbCxu47aXqOZFjOgElAuAaCkhQzE3b3RJfWYjmehSCc=; b=oa5zJsQrq+PRcAacYKvPmJFEiT892k3KGbGwJQk5suWva6mPaVh1qqAA8IzY+Jj/hD VFBYO4okZJxeVSzysh4ToRnXR/6o5DYUVATkBJfNde9WKEOtWJJ8yy7sY1xXBfZGEY3q xOZ0jkjwyMWdnarfIh0L8R4nUzdGSyWIKSazjknGk1r11LI/2RO684ecfw7UrQTVXs/M GzaTUPkrFcjqNquKq6y2UAqISLWfsxVd028RdcSxBegIpsM6e0JAtRgxUzO7FY9aKxf+ Lt1hLlXFBFqgRdkJ2/8j3ivRECJ5MYEvxha3Z2O262UcpC3xjQwUKeyV2yCazEbahUJf 4cIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682016952; x=1684608952; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hbCxu47aXqOZFjOgElAuAaCkhQzE3b3RJfWYjmehSCc=; b=AvMtrt8UM8FrKHUukBEtK1kzDjLjVhXvMIBo0gbOe8eXaxNpHGC5IS5wMv0WO5f7kV mQ4seJT3Z48CAbVa3iPU9Hg7iXw41GSCVsaLgCyWNXv6YMn7nXFNBhwc2e/WysIgXOE9 zSY2C4aUxkvqpmXfXnH9B9irUjeou9qZL+9ur76YTTSVuZ9nhOGWR9yIPhSpPFYytlN6 xcFlNQJPIVWdWBARgqbCC6FcO6ap3CuAv+vXAlQ639dtOeDT1yvG99TBzjCf4u0rzhVX RphFEZke6RVjiNGaD24khaDn5RIiAcBbiVy5/WhyEwawcalusmCIGeQffrAkLsekyGED hcJA== X-Gm-Message-State: AAQBX9cdVowDMmjAVRF6MxKmfD859oO2QY3Xk+YCQ49piXPt9DDAeSUR 5TqBbrQzgmdFGrPSmua+3lI49dGqK9lZtlg4/T+3Yg== X-Google-Smtp-Source: AKy350YQ85co+lRTcuWRO1Vltk6Lkvqveeyi1jPBPoTaqbL7736XRkZW9Hessn4M1C1JBov0tCRU8RrPiXoZoB3KNYs= X-Received: by 2002:ac8:5b10:0:b0:3ef:343b:fe7e with SMTP id m16-20020ac85b10000000b003ef343bfe7emr60397qtw.2.1682016952049; Thu, 20 Apr 2023 11:55:52 -0700 (PDT) MIME-Version: 1.0 References: <20230403220337.443510-1-yosryahmed@google.com> <20230403220337.443510-3-yosryahmed@google.com> In-Reply-To: <20230403220337.443510-3-yosryahmed@google.com> From: Shakeel Butt Date: Thu, 20 Apr 2023 11:55:40 -0700 Message-ID: Subject: Re: [PATCH mm-unstable RFC 2/5] memcg: flush stats non-atomically in mem_cgroup_wb_stats() To: Yosry Ahmed Cc: Alexander Viro , Christian Brauner , Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , Andrew Morton , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Queue-Id: D0F5240013 X-Rspamd-Server: rspam09 X-Stat-Signature: 6awqyi3ipgbftj1u6wf4y17te67h7sep X-HE-Tag: 1682016952-923475 X-HE-Meta: U2FsdGVkX19mBFgwMAeABtGjd3TfmbJ25Cd7LNNBmSzO8t0ngTFWdRJToK46oiy/k7Q9w4lqf7wKoHS0iwD832d53cQzFzgGReZiIzV/9CKs923myxT9a/v5lrxlpRISNF4z8tLH30wDmaBs03lx459BpryLQFqgcfswDSFAp33mbg8BIGnVSyn46YaV9xjL0KgwvI+QbZXIllqzQRjQPPldYJBFQyIywX0c26v1BBFVn+TKxxwCQzFT1fuGpxTyX6bz67npGBBkVwa2u7ocwUzr4V6Hexy+eQSBA7LMuXxJKDxyQoSMKW2cRyGYh0P6jGvg+7T4YyK3dOLwK9AQW8c5f4hL3i8GZGvXo7wR09bSZ4YaTqgxFLMZSOLUfedroBkGENhBTuzTy3CxStCYO8TFapRK8MVaviN7grFw9+VD2sqOyHg5L+9hShTfq5NaNGOH9M4aevWeHgf8hs3YLw9GnbqLtm+uvnzDw9dd29yK5N+v9GqYJaSNTfac8LrYcglOnzIrxlvFGIqtgHdlrCqCeFnHigjzYZgWv35BKs69SGG2R52tP5uOzQdKNxkJRt8eny2y6+ZFvF5MzfiUwl8AXCNjes+HB8g3Xx6FRJ42w1O95EVN4bCGmV7V6F0wMkDmLSm+g4niYd2AZz/Q15/SxcCoNd/aiZ8cYzXii+7gwsSxKiuf0bg139y/+XolkPNlpB9u7YZ/3wLRr9cvFVNnzsG5KlmPfvG3vM2aJT1sBf2rfJVqoVFaigdY7FluD9GdnzOPOkrLaOxt/QVqU8ZLCkR0ZYBU3Tocnd+U8pxgZl4Zh0yY+u0o/FlGxaqOkzbDPfFkQ+46BJd0uJkhZspvdjktSe9+u0beMAu1vZ46uMkOVvIyStOdjqLLfvKbGeuyCuuG9qz6B+zFm7eK/N5s4HKyV+gpkAF8lFbRy29P48iZawgGJzU4n5B1dYfpA3pdfSOG2b0cNqIwx0q 4b2w7q0P 6o86131+xl11SfRFX6z+LTfdGIKM0kT6r6cvQImeb5MvspmKy831Iu4mW4mI6SnTcO33i3Tdgy1eZx1TXNBpui2CGV4vRHEZf+QKK2HbobrvvXixhhZwbInZqlemTSHMst85XnHzE4+CYcyK1CQNbQB1caIIX+68CDeEhN+t247ay/EPHJPeek5ypc8WxOBEe3TYJE4muEDFqUffyPaJIOdeXeM/atC4YjIOH6jiMYN0x7ZKFxylQvkPwVYarKkrcsG8fVgC2J6cylu3ok9ZKay1DTVrfFIfxQ0wdLjsevq5rtJc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Apr 3, 2023 at 3:03=E2=80=AFPM Yosry Ahmed = wrote: > > The previous patch moved the wb_over_bg_thresh()->mem_cgroup_wb_stats() > code path in wb_writeback() outside the lock section. We no longer need > to flush the stats atomically. Flush the stats non-atomically. > > Signed-off-by: Yosry Ahmed Acked-by: Shakeel Butt