From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.2 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA3B5C433B4 for ; Mon, 12 Apr 2021 15:51:06 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 764C361287 for ; Mon, 12 Apr 2021 15:51:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 764C361287 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C76318D0002; Mon, 12 Apr 2021 11:51:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C25DB6B0070; Mon, 12 Apr 2021 11:51:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A9FD18D0002; Mon, 12 Apr 2021 11:51:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0200.hostedemail.com [216.40.44.200]) by kanga.kvack.org (Postfix) with ESMTP id 865CC6B006E for ; Mon, 12 Apr 2021 11:51:05 -0400 (EDT) Received: from smtpin32.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 4A5FA62D9 for ; Mon, 12 Apr 2021 15:51:05 +0000 (UTC) X-FDA: 78024153690.32.378AC41 Received: from mail-lf1-f49.google.com (mail-lf1-f49.google.com [209.85.167.49]) by imf09.hostedemail.com (Postfix) with ESMTP id 17FBC6000117 for ; Mon, 12 Apr 2021 15:51:01 +0000 (UTC) Received: by mail-lf1-f49.google.com with SMTP id j18so22207889lfg.5 for ; Mon, 12 Apr 2021 08:51:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=jXdDtDVkOliHR0wKt8o4xOp+hVyUebs5k6d6U80wmt4=; b=caAQ4Xqg3sQpXpGaPNU3gKD7/UtnjwdhKAtTaqk6OAPLz6XqnT2JJIRntD7Xo7/K9F 9Uze7K7jgVp9YNlmci2T07wzH6iQWrk+KTChEXZtVUcgMPlTqiGfCtQyExMN3RCaBNlU r3gk9p6TrZEHgs+aBrSlqaWZjux7xtU1Ml1dFps1vFQeJDdkRHM2uZKddjni+P37e0A7 Dd4j8BViFagxn40TtOl79/kk9ps0I/pPMz8qJ8qkA0WKCny7QuwcCqKUFGQJAY0cEaVT 1kIY2G4ii+zqIlQgDlq513nOi6v7A0qNOa0mRYFLP5FsDXuMXFkV+1jLK8SEo/JBXW7X itog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=jXdDtDVkOliHR0wKt8o4xOp+hVyUebs5k6d6U80wmt4=; b=euyySpUcy4LypQBpgae8MfF79AfJVbPo8BWwdqFT+3lSwd5zTXpeHI2eXu9ckSGlPF AKNIUxx/hkB36m6Kl4mFkJUgCtx764Jf3sboVfmnErxQvDVhL+UsTbeBHgHmYshcLKj4 SAm9izq6d2Fv6KP+ZFJMVV90glMwWMYxEO/URPiX9QOXNsZ+cv1whLwmZCcEGeKC/uDf nbahvRPF6gtXLXwHjqpeEwfJWelrQ3rt+rX07pugosy5bQHgWwxnER6YcqM85vdxc2f8 Rxv5z8hfzq3tyaF4cEy7MJsi0y6bApUpnhgc/Yqo/Nl/7NHGsg73l0xurGnK+4oquih0 5lFQ== X-Gm-Message-State: AOAM5308oQWPhLDnYIA5dFe8gBow39w4PX+ObmwWji6uCDcWt7c/v5gc gat3lHsfaCDtZmvz7akNAxlwXTt/UJ4aRC40gLsH9Q== X-Google-Smtp-Source: ABdhPJy/6xYW52zIk5X9L64R1+sYa7h1XRl+uzYrZVCer2D1jTMm+sFt+n0v5v9OKyJBaCPZPiLkgW53BuZLiIEZybU= X-Received: by 2002:a05:6512:34c7:: with SMTP id w7mr18952307lfr.83.1618242663210; Mon, 12 Apr 2021 08:51:03 -0700 (PDT) MIME-Version: 1.0 References: <20210409231842.8840-1-longman@redhat.com> <20210409231842.8840-3-longman@redhat.com> In-Reply-To: <20210409231842.8840-3-longman@redhat.com> From: Shakeel Butt Date: Mon, 12 Apr 2021 08:50:51 -0700 Message-ID: Subject: Re: [PATCH 2/5] mm/memcg: Introduce obj_cgroup_uncharge_mod_state() To: Waiman Long Cc: Johannes Weiner , Michal Hocko , Vladimir Davydov , Andrew Morton , Tejun Heo , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Vlastimil Babka , Roman Gushchin , LKML , Cgroups , Linux MM , Muchun Song , Alex Shi , Chris Down , Yafang Shao , Alexander Duyck , Wei Yang , Masayoshi Mizuma Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: ccgjseqakur5azet41tgrkmisot4zmc4 X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 17FBC6000117 Received-SPF: none (google.com>: No applicable sender policy available) receiver=imf09; identity=mailfrom; envelope-from=""; helo=mail-lf1-f49.google.com; client-ip=209.85.167.49 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1618242661-821442 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Apr 9, 2021 at 4:19 PM Waiman Long wrote: > > In memcg_slab_free_hook()/pcpu_memcg_free_hook(), obj_cgroup_uncharge() > is followed by mod_objcg_state()/mod_memcg_state(). Each of these > function call goes through a separate irq_save/irq_restore cycle. That > is inefficient. Introduce a new function obj_cgroup_uncharge_mod_state() > that combines them with a single irq_save/irq_restore cycle. > > Signed-off-by: Waiman Long Reviewed-by: Shakeel Butt