From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.2 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C997AC2D0E4 for ; Tue, 17 Nov 2020 20:02:17 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 218B62465E for ; Tue, 17 Nov 2020 20:02:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="U5ZlwbFb" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 218B62465E Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 1586D6B0036; Tue, 17 Nov 2020 15:02:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0E1A96B005C; Tue, 17 Nov 2020 15:02:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EEA966B0068; Tue, 17 Nov 2020 15:02:15 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0082.hostedemail.com [216.40.44.82]) by kanga.kvack.org (Postfix) with ESMTP id BCD416B0036 for ; Tue, 17 Nov 2020 15:02:15 -0500 (EST) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 6254F1EF1 for ; Tue, 17 Nov 2020 20:02:15 +0000 (UTC) X-FDA: 77494981830.07.beast10_4b0ff8427334 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin07.hostedemail.com (Postfix) with ESMTP id 493261803F9A9 for ; Tue, 17 Nov 2020 20:02:15 +0000 (UTC) X-HE-Tag: beast10_4b0ff8427334 X-Filterd-Recvd-Size: 4804 Received: from mail-lj1-f195.google.com (mail-lj1-f195.google.com [209.85.208.195]) by imf04.hostedemail.com (Postfix) with ESMTP for ; Tue, 17 Nov 2020 20:02:14 +0000 (UTC) Received: by mail-lj1-f195.google.com with SMTP id l10so25718173lji.4 for ; Tue, 17 Nov 2020 12:02:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=GSCHMMM0D0q85Saw3BGZ1mrSdRqytsRtsFlwlLFUG1Q=; b=U5ZlwbFbW6wzZ9SjWFK+Je9NtJURJfuA+CBtm8mpTtA3OAFV31Gt7/PVFooFI3hJSJ FPe5GnyQ9vo+K8E4DGvg2CmIfBjU80aj+PwOMi9JxkBrfyCFhmQwE8yG25tVzzpwHM/G +SLjkMHpsWn0eetojTcyUPdUG+YBEUlN6bkAREdia0RwgRe5Az5vSyoEcUpsdqwdqQS2 wQsiqbs+NFvyybKCLcEoNJlXX+Q79meG+WhN0TKvoL+R5ZHI5kwQtcSrRMvmI503HpW4 iQFfKDV7kGEefpCno1fqlRK8X77oqYAJVuKjI7LR9wx0wgLXu6vuCzgHwKA6G32zuy1F Z/Mg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=GSCHMMM0D0q85Saw3BGZ1mrSdRqytsRtsFlwlLFUG1Q=; b=ShcNOpkl4w5MCL+BT/0eOWZeaE3Q8vTCGyvTkoUxDu4R5TBFA0PObXVMgEHqTIForQ e3fPptpuGCqGplp4wb0KLcYHhjldxvSOTMTGkqUn7q66Lb4HCdh2orrsjtlHwyi041Mx jiKu6vwz9enkhpYYV+/awv7lk8JmBmWoan/VWgFUJKLg2a78h+i/wct3hS5h2CP5LAHI A5cx7CGJ0ufKltAS0Rl7+Ztz0sXAw9JjLy3Nco+TYWSqoqoEwdi9k9tZNqEIOE2AJlju kteXlQppunxXqHMoTL/BkHgTwZ4C1eZS/TCDKOzFRcOw+KxQuBIF3o+qSZomAaAQICHO CWTw== X-Gm-Message-State: AOAM5307krKXSMtT5b+ODm4aHrBf7zujGOL0yhDjluNLqbFKCWyMJqJv NlQRo+P+lajoMmx/cxCXMcBCjZKyuk3/0gRimUzXJw== X-Google-Smtp-Source: ABdhPJzrteo1SoLGHTARp2PUs3U3i4VQkUG29Mj40M+A73s5OoqlPLDhJ7M0v+3kzosqo9RIkW4zU8tz5/C7FbMtdpI= X-Received: by 2002:a05:651c:204c:: with SMTP id t12mr2581977ljo.347.1605643332643; Tue, 17 Nov 2020 12:02:12 -0800 (PST) MIME-Version: 1.0 References: <20201117162932.13649-1-rppt@kernel.org> <20201117162932.13649-7-rppt@kernel.org> <20201117193358.GB109785@carbon.dhcp.thefacebook.com> In-Reply-To: <20201117193358.GB109785@carbon.dhcp.thefacebook.com> From: Shakeel Butt Date: Tue, 17 Nov 2020 12:02:01 -0800 Message-ID: Subject: Re: [PATCH v9 6/9] secretmem: add memcg accounting To: Roman Gushchin Cc: Mike Rapoport , Andrew Morton , Alexander Viro , Andy Lutomirski , Arnd Bergmann , Borislav Petkov , Catalin Marinas , Christopher Lameter , Dan Williams , Dave Hansen , David Hildenbrand , Elena Reshetova , "H. Peter Anvin" , Ingo Molnar , James Bottomley , "Kirill A. Shutemov" , Matthew Wilcox , Mark Rutland , Mike Rapoport , Michael Kerrisk , Palmer Dabbelt , Paul Walmsley , Peter Zijlstra , Rick Edgecombe , Shuah Khan , Thomas Gleixner , Tycho Andersen , Will Deacon , linux-api@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-fsdevel , Linux MM , LKML , linux-kselftest@vger.kernel.org, linux-nvdimm@lists.01.org, linux-riscv@lists.infradead.org, x86@kernel.org Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Nov 17, 2020 at 11:49 AM Roman Gushchin wrote: > > On Tue, Nov 17, 2020 at 06:29:29PM +0200, Mike Rapoport wrote: > > From: Mike Rapoport > > > > Account memory consumed by secretmem to memcg. The accounting is updated > > when the memory is actually allocated and freed. > > > > Signed-off-by: Mike Rapoport [snip] > > > > +static int secretmem_account_pages(struct page *page, gfp_t gfp, int order) > > +{ > > + int err; > > + > > + err = memcg_kmem_charge_page(page, gfp, order); I haven't looked at the whole series but it seems like these pages will be mapped into the userspace, so this patch has dependency on Roman's "mm: allow mapping accounted kernel pages to userspace" patch series.