From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E609CC433F5 for ; Mon, 29 Nov 2021 17:19:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 30E3E6B0071; Mon, 29 Nov 2021 12:19:28 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2BED16B0072; Mon, 29 Nov 2021 12:19:28 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1864F6B0073; Mon, 29 Nov 2021 12:19:28 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0131.hostedemail.com [216.40.44.131]) by kanga.kvack.org (Postfix) with ESMTP id 094756B0071 for ; Mon, 29 Nov 2021 12:19:28 -0500 (EST) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id BFE268770B for ; Mon, 29 Nov 2021 17:19:17 +0000 (UTC) X-FDA: 78862628754.15.679C1FD Received: from mail-lj1-f175.google.com (mail-lj1-f175.google.com [209.85.208.175]) by imf15.hostedemail.com (Postfix) with ESMTP id 9B64BD00009F for ; Mon, 29 Nov 2021 17:19:10 +0000 (UTC) Received: by mail-lj1-f175.google.com with SMTP id j18so22636925ljc.12 for ; Mon, 29 Nov 2021 09:19:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ULamTUST6L2A21kAICas7AlHR1YPJikHumKTUMz0JF4=; b=KpLlvkXPiqlh90dRrkMiw6RVVebFtOcim8stxS8GSc3BRe262oEefo4fCtn/n5dSyF AzCk9A3mr0ghtqEYFUnZ6LpyGMxRrIR56LcUAjfj6Y5coGW4WKof/0nURa9/WhzOna// 6KMeiBS7y93+57LjMtRLJWLV9Z8QG1Ulf86Zv/Qv5hr9iwB53s+NI9orCNCEtzv43Ma9 rMZ8vvSZclmxXvo24LkFGlyI+FP5aK1DmEBGo7Wad3dzcYpWOO2QItBnMc2TtZvu7Xl3 0dTtueijGHDAZWxLMaiuH5yXWBUn8CtZA3XEXtehRJPKfRP416Cf3jJVwV0guRHObDNu 9D9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ULamTUST6L2A21kAICas7AlHR1YPJikHumKTUMz0JF4=; b=CZDuF3hWLQdx3LWv99eVc/ZfgS7XMURM5tSWri7ostmKjDHdmjyjFUBCMdEVIBQtfi Y69tgs1i2YdgM9aDK6E+EKovbqs4bm6VqURFiLx5r+GL4ycqY85q14QLuq6o0LITYryD EaLYe2nDZ+zPzEEKR6dpOKsu1jMr5gDEx2rDmYAIn2+4833qyAbZls9gkX/anbxmLc55 tLWx4tjNZ6uygqHIj0tMXXll+ZJF5kRdvXPhF072Ul1aCQ9epXC5q9rn7NUltRP84Xpe 8wR2VoAor8iVwdxOutMgj2rMtZ0g7nVOtNEpDnpB6ZS3qiwD21kDZQ+Ymni4dKWkxT6Y KesQ== X-Gm-Message-State: AOAM5318Lgu2S4G6iT5vp/VeyJttdVTwiWEGpHnvKajjGAMk3U1Er54R iKWUyZ7X/3kXevWQAuyDmcEZ/5lKuWcHzD6W2Q/12g== X-Google-Smtp-Source: ABdhPJxqmbkfmnB5Qpdh6ObutiDkIv82YSiBCEC1//M8iI+OVzSf9Hz/3dHh9Q8OCShqO1Tq1mj/iIiNtEawrdh1T2M= X-Received: by 2002:a2e:bc1b:: with SMTP id b27mr50913795ljf.91.1638206355462; Mon, 29 Nov 2021 09:19:15 -0800 (PST) MIME-Version: 1.0 References: <20211129161140.306488-1-longman@redhat.com> In-Reply-To: <20211129161140.306488-1-longman@redhat.com> From: Shakeel Butt Date: Mon, 29 Nov 2021 09:19:04 -0800 Message-ID: Subject: Re: [PATCH] mm/memcg: Relocate mod_objcg_mlstate(), get_obj_stock() and put_obj_stock() To: Waiman Long Cc: Johannes Weiner , Michal Hocko , Vladimir Davydov , Andrew Morton , linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org, Roman Gushchin , kernel test robot Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: yuwgdgc3ty8ej5ttcis1q5x6r1n83z46 X-Rspamd-Queue-Id: 9B64BD00009F X-Rspamd-Server: rspam07 Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=KpLlvkXP; spf=pass (imf15.hostedemail.com: domain of shakeelb@google.com designates 209.85.208.175 as permitted sender) smtp.mailfrom=shakeelb@google.com; dmarc=pass (policy=reject) header.from=google.com X-HE-Tag: 1638206350-535883 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Nov 29, 2021 at 8:12 AM Waiman Long wrote: > > All the calls to mod_objcg_mlstate(), get_obj_stock() and put_obj_stock() > are done by functions defined within the same "#ifdef CONFIG_MEMCG_KMEM" > compilation block. When CONFIG_MEMCG_KMEM isn't defined, the following > compilation warnings will be issued [1] and [2]. > > mm/memcontrol.c:785:20: warning: unused function 'mod_objcg_mlstate' > mm/memcontrol.c:2113:33: warning: unused function 'get_obj_stock' > > Fix these warning by moving those functions to under the same > CONFIG_MEMCG_KMEM compilation block. There is no functional change. > > [1] https://lore.kernel.org/lkml/202111272014.WOYNLUV6-lkp@intel.com/ > [2] https://lore.kernel.org/lkml/202111280551.LXsWYt1T-lkp@intel.com/ > > Fixes: 559271146efc ("mm/memcg: optimize user context object stock access") > Fixes: 68ac5b3c8db2 ("mm/memcg: cache vmstat data in percpu memcg_stock_pcp") > Reported-by: kernel test robot > Signed-off-by: Waiman Long Reviewed-by: Shakeel Butt