From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2A7BC4338F for ; Thu, 19 Aug 2021 20:27:10 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3F9A36108B for ; Thu, 19 Aug 2021 20:27:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 3F9A36108B Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id B69798D0001; Thu, 19 Aug 2021 16:27:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B19AF6B0071; Thu, 19 Aug 2021 16:27:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A082A8D0001; Thu, 19 Aug 2021 16:27:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0247.hostedemail.com [216.40.44.247]) by kanga.kvack.org (Postfix) with ESMTP id 897106B006C for ; Thu, 19 Aug 2021 16:27:09 -0400 (EDT) Received: from smtpin39.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 3776A2AEE6 for ; Thu, 19 Aug 2021 20:27:09 +0000 (UTC) X-FDA: 78492964578.39.E8B00EF Received: from mail-lj1-f179.google.com (mail-lj1-f179.google.com [209.85.208.179]) by imf12.hostedemail.com (Postfix) with ESMTP id EE7EB10000A5 for ; Thu, 19 Aug 2021 20:27:08 +0000 (UTC) Received: by mail-lj1-f179.google.com with SMTP id y6so13560987lje.2 for ; Thu, 19 Aug 2021 13:27:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=/83TwebHHmJL69BFYr+1IWSB3TySC/r6MxW9uBWi/+g=; b=GQgrFd++dvqTy4n5ah1wmwLwveJavsfRGF/U0Ay5sHyCYL1tB9CedHiNL2eAlmd9TM YJ63LGPPToxzqCDQ07+z65M5TC1Wm/Ki3CYnhRCk9K/n/2fnJQPOFh+gCyYg8ufVOn/l 6uHMY+7AZsU5JxYbXbeetp/lTvDYSp0eJhx+ahZ7jmKAqLnaKqYFxmeqF0UW+Xf+Dz5j sWDaZ/zt455CjeftzazWfFULzFzpBZ0gjHhw0+uuqXLtDyjAMDOasmBO/Vrp9zbVVGxC wF8sfEbkojmtlfU7T0rzQq92xjoXFBCppMAHDhZxxcPtRujQ9gVTP6az/rXUdY5XzNiW 2B1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/83TwebHHmJL69BFYr+1IWSB3TySC/r6MxW9uBWi/+g=; b=TglnKZnmQOn6+mzI7M8KqybQP8RPO2a6J+KVapJOIyX8bFK+b80CLebU2a24xC2Mwf WkZsiJADr6gE9CJs/J3PKyfu/il2D3JU1TEEjp8w4wSIjFK7nwz5QZkOcGw0g5EZi1f+ QB85+c2BE4IohxK/NKMKdYwo32Zy97B2i76nH0dynInFMEnKJCkdAEuusm6iNGagHPAN AbDrAsIPVA8FwbNwXYgXtSYURYZZefshXKOc/2egaA+iJm5jgpO8Wkxd5WIA4zs4DP6Q hTtFPb7cic4GPCfGl5tlLFpWCKC1n0tdZtuPK3+1+dtSfRZEQWVVxmeMqL+g9xrypNhD jLwA== X-Gm-Message-State: AOAM531DU+n5d5rIfnNv10VePGUSAslwIt8CLIvNB3LayYeICYeDQjdb 81B8CqPekU1wfs1T05He4Y0O/JNRFgFlgKlhbGZBQw== X-Google-Smtp-Source: ABdhPJyJe/iQ+7dE7nyV5tFW1yLwKEiBMozZ6YdY/f+OAsNOk7C3HNdIM8l4WWObanUcbS/GC2B7N0lC8aLUVnO1YhM= X-Received: by 2002:a2e:7103:: with SMTP id m3mr13430013ljc.122.1629404826894; Thu, 19 Aug 2021 13:27:06 -0700 (PDT) MIME-Version: 1.0 References: <20210819163056.GA9764@haolee.github.io> In-Reply-To: <20210819163056.GA9764@haolee.github.io> From: Shakeel Butt Date: Thu, 19 Aug 2021 13:26:55 -0700 Message-ID: Subject: Re: [PATCH] mm: vmscan: consistent update to pgdeactivate and pgactivate To: Hao Lee Cc: Andrew Morton , Johannes Weiner , Linux MM , LKML Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: EE7EB10000A5 X-Stat-Signature: 91pngo9mo88113x533xwftiudmkekrwq Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=google.com header.s=20161025 header.b=GQgrFd++; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf12.hostedemail.com: domain of shakeelb@google.com designates 209.85.208.179 as permitted sender) smtp.mailfrom=shakeelb@google.com X-HE-Tag: 1629404828-734874 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Aug 19, 2021 at 9:31 AM Hao Lee wrote: > > After the commit 912c05720f00 ("mm: vmscan: consistent update to > pgrefill"), pgrefill is consistent with pgscan and pgsteal. Only under > global reclaim, are they updated at system level. Apart from that, > pgdeactivate is often used together with pgrefill to measure the > deactivation efficiency and pgactivate is used together with > pgscan to measure the reclaim efficiency. It's also necessary to > make pgdeactivate and pgactivate consistent with this rule. > > Signed-off-by: Hao Lee pgactivate and pgdeactivate are also updated in code paths other than memory reclaim like mark_page_accessed() or madvise(COLD). Wouldn't that impact your analysis of these metrics as well?