From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3F3BC00A98 for ; Fri, 20 Oct 2023 17:23:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 38DC38D01CE; Fri, 20 Oct 2023 13:23:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 33C4A8D0003; Fri, 20 Oct 2023 13:23:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1B66E8D01CE; Fri, 20 Oct 2023 13:23:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 058B58D0003 for ; Fri, 20 Oct 2023 13:23:32 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id D9C02160200 for ; Fri, 20 Oct 2023 17:23:31 +0000 (UTC) X-FDA: 81366511422.11.A467778 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) by imf16.hostedemail.com (Postfix) with ESMTP id 1FDA8180022 for ; Fri, 20 Oct 2023 17:23:29 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=XHJlA43H; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf16.hostedemail.com: domain of shakeelb@google.com designates 209.85.214.170 as permitted sender) smtp.mailfrom=shakeelb@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1697822610; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bZExr3HakSu/t70XqjHC6rrKDB2IMk8Lwf9XEJ5+nuo=; b=rh9zuXOzhpFbN/pTRmg4V2Axes5wmKV+wF5I00H19/8AtX79Smlg+zFuYofPSabL01katU tHtWrI8A5cumSJ13T2+Q5wE7mW8Tp775VoheHANc4vzGcnH5ydYLOehOlKzYfscjSv6KdA T+WuTQLtj4SsbRmaPxGT8WaKUOonrN8= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=XHJlA43H; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf16.hostedemail.com: domain of shakeelb@google.com designates 209.85.214.170 as permitted sender) smtp.mailfrom=shakeelb@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1697822610; a=rsa-sha256; cv=none; b=jJBrL4YDUj2JE+wCFW4MZztFkq1bwfkDv4M2QmERYKvr02othLrRhEguYJnLtypHGIvd/h cRiMdJC+kU0bTnYsBTsIWpjgmnNqyNIWl0Xz1yzKhSdsukoYXw+VxZkIO37+8pO30+TXB6 f57ZT9KmfGtMVLwoxlXPb5EMsJXGhXI= Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-1c9c145bb5bso7605ad.1 for ; Fri, 20 Oct 2023 10:23:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1697822609; x=1698427409; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=bZExr3HakSu/t70XqjHC6rrKDB2IMk8Lwf9XEJ5+nuo=; b=XHJlA43HMk5bYpUTTcoQ2E7IFSEa1pKRFN/0YBxb8+JME5WDrNMmFzpBkraic/Clat C7AnmkWRB12ZfVxJat7h5nRw2x92trzkKqI/h9xbKS4IX4Smo+30bKC1aD6OefozukiM CdNTiu6Ki3x4BR1H/m8q4wRsiaQ+kqXXRO3qlbx5ZG2ip5s0lvNVjSpUTT37jfgIrG8R 5NDd5dHrkE9K+whhndSSYanf9kjbRrEOPrQERnGSxe+td5FI1+AUsAr5CWW2K3RS/Lo0 JgqqoTL8rObZyAxgwdaLcVd35OfyiLuS56WvQU80qy6XBRkaWsrTybfaxkqOY9XUDfDd J6KQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697822609; x=1698427409; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bZExr3HakSu/t70XqjHC6rrKDB2IMk8Lwf9XEJ5+nuo=; b=GEC5XSqUzJYP497NJLdR+fq/XX/agboCiDxQwguyQgcWT/vULzYHOAhEtFhVlniTj6 ciDQVunlqtiD+vJt4MOxHfc5kI3zBLJWOowTtfBN9zbtkRm2/eZU9zNHYBmljfozZgZx SZWdG+Puq7iKEOzHQkcR+cb0Kywa37amWI6Os2bQRgl5PawrlVXJL3w0Z3FKT+UxT7bB RgXLfFcaBWN28frKr2layQXTFhVcpqZLNZDCc91wHSnogkNbtpfpxulQwsq+oJ/1/0u1 tDvDBtniWK7omQbS/eQWEtNizalKchFd1JXyB6sGillaKc9cBMy0oRfLIC5oHcXMAW15 nh1Q== X-Gm-Message-State: AOJu0Yx7B2ZDCyM+FEqC8hmpPQJU5nQC4BQV9D1eZAKoXUEB5qM3yoBX /lGJroNEwWZqFFiG6rqHRDOJVI/iHHmmhGqI986AUw== X-Google-Smtp-Source: AGHT+IE6qIeeuEX5YH+y/z1n375Wnwum8Fvy1MQ/6ot9JPGuTfvhnYMSZC0YoAk+ckCivwMMP+8siHwBMoL3xRQ8aZ0= X-Received: by 2002:a17:902:e949:b0:1c1:efe5:ccf8 with SMTP id b9-20020a170902e94900b001c1efe5ccf8mr256373pll.17.1697822608688; Fri, 20 Oct 2023 10:23:28 -0700 (PDT) MIME-Version: 1.0 References: <20231010032117.1577496-4-yosryahmed@google.com> <202310202303.c68e7639-oliver.sang@intel.com> In-Reply-To: <202310202303.c68e7639-oliver.sang@intel.com> From: Shakeel Butt Date: Fri, 20 Oct 2023 10:23:16 -0700 Message-ID: Subject: Re: [PATCH v2 3/5] mm: memcg: make stats flushing threshold per-memcg To: kernel test robot Cc: Yosry Ahmed , oe-lkp@lists.linux.dev, lkp@intel.com, cgroups@vger.kernel.org, linux-mm@kvack.org, ying.huang@intel.com, feng.tang@intel.com, fengwei.yin@intel.com, Andrew Morton , Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , Ivan Babrou , Tejun Heo , =?UTF-8?Q?Michal_Koutn=C3=BD?= , Waiman Long , kernel-team@cloudflare.com, Wei Xu , Greg Thelen , linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 1FDA8180022 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: trdnjm4maxezqzeffkx96z8gww81d487 X-HE-Tag: 1697822609-418375 X-HE-Meta: U2FsdGVkX1+xD3f/EWdTVyfAQKDU5Crx2J3RdO8uKKiywTz+Hi6S0gHk5ZmUu6lzSjQFNravXIAfZLwJD3/xK+KP/eh5adlgrNiSbX+LRojrq0FIc+o8Zr2ZDAVDq/IIlj4NZkLO+mzPnG4DKFo7tGyg5EEC2LKlFrdkz5bysVpA3dUwPXIb0f+yIHb39NldDhSb0y3411SFfN41uRB+P7z3nMPAuZfh5a2eobiSep5+8uqk/shZnWWImux9SGrtzrAiihWOPh1NGNuSEI1ZXF2wQT+iKONTSY7GZxnnNBSdUYfZHmwxWACkRBbdmSH+Ab1z8Hbo3ksDUYMesLvX5Yp9XDJQdNhft9GZG7OWO8MLNGJYkRx5JYzmQpMkmnDrvocay/JvddiJk1w8spetnJAeIl7Un8lLiS2r+eAwGXrukbSGD4KK4CDqBzz6RAz0lvC2bIJcSTqVBxK/bCx/S6I0/ruW7F2YrdEFG9Q6XJm5RQ6CAP82HQ1N7D8tWMiY/r2dV5nEuh3VSpY8Hww1kf2h1P3GwosTbQunmdz84peexYF0ViaycuQQS20yNdluspydyAm7T59Zo41q/lE/Q2taDR+2q+b9fkmCWBH/dPE19PRoAdnvUXx75oQi/hyjRcM8Ke4FhXG5zLz2WjENIwooqERPJh5L+HNDxXvPRRy+fBo6+LaUWVd9B/+DFcksaaMkRF9qUgv9Ocqo+KRoc+vSwma1b+7W0mdN1KQ0OH7enUZfGAW0XO26p2G1WLNJykCcVwgumLPEW68NMGU5QGoRDzwF7iY8Ppp+2HbP2QChUlRakQRRGlQA8LBSxwLoC6EzsnZSHUp/dNkULYyqs+iCqCNkGhT54nxQouyMF33ZokwSh3Al79WN57O5luud/tSVCZWX1m1kjPLBxQMJyYtVcS/gMURVksKsa2Y3e7PaFcdo/750bAbiAlmfb0TKAdlEfgmuuaaNtIUn0ds uN8Cj5vQ MoLEyLrHmGqTIhNr7weJzXsWL0DVj7yM/e9XEyylRYa7Mkg+LG0YaCEBofPTh2rxzcUkc/LKWrvX8yAcjmzs5IPvSIRnty4lUkWjpmkktlriRJkH53jfTKPLp1t8CEHAlWjklm+04w0jOqgThgGqztqeLLl2KPDpWSrD6aBCs43p2qT3OSDk5nGJIlrRuVgXux2wU1T8G8EfhANZ+QjRA2jHzRbYUCGxmzFcXtOfMlVnbxzVNyQ/t4tM2sL/bwCgwIfdUaJcm/W1j44pON0DMexuVFzWWin7dQvp1klZgjKAv9hrIvmc1HryLzCrF0oNOdFHpCg2mydRr/jYewrCVrLB2xcLo+3bNE0Xc X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Oct 20, 2023 at 9:18=E2=80=AFAM kernel test robot wrote: > > > > Hello, > > kernel test robot noticed a -25.8% regression of will-it-scale.per_thread= _ops on: > > > commit: 51d74c18a9c61e7ee33bc90b522dd7f6e5b80bb5 ("[PATCH v2 3/5] mm: mem= cg: make stats flushing threshold per-memcg") > url: https://github.com/intel-lab-lkp/linux/commits/Yosry-Ahmed/mm-memcg-= change-flush_next_time-to-flush_last_time/20231010-112257 > base: https://git.kernel.org/cgit/linux/kernel/git/akpm/mm.git mm-everyth= ing > patch link: https://lore.kernel.org/all/20231010032117.1577496-4-yosryahm= ed@google.com/ > patch subject: [PATCH v2 3/5] mm: memcg: make stats flushing threshold pe= r-memcg > > testcase: will-it-scale > test machine: 104 threads 2 sockets (Skylake) with 192G memory > parameters: > > nr_task: 100% > mode: thread > test: fallocate1 > cpufreq_governor: performance > > > In addition to that, the commit also has significant impact on the follow= ing tests: > > +------------------+-----------------------------------------------------= ----------+ > | testcase: change | will-it-scale: will-it-scale.per_thread_ops -30.0% r= egression | > | test machine | 104 threads 2 sockets (Skylake) with 192G memory = | > | test parameters | cpufreq_governor=3Dperformance = | > | | mode=3Dthread = | > | | nr_task=3D50% = | > | | test=3Dfallocate1 = | > +------------------+-----------------------------------------------------= ----------+ > Yosry, I don't think 25% to 30% regression can be ignored. Unless there is a quick fix, IMO this series should be skipped for the upcoming kernel open window.