From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C69CC4332F for ; Wed, 11 May 2022 02:47:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 53D916B0073; Tue, 10 May 2022 22:47:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4EDF46B0075; Tue, 10 May 2022 22:47:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 390436B0078; Tue, 10 May 2022 22:47:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 2569E6B0073 for ; Tue, 10 May 2022 22:47:43 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id D763221EE8 for ; Wed, 11 May 2022 02:47:42 +0000 (UTC) X-FDA: 79451926764.08.608F2FB Received: from mail-pg1-f178.google.com (mail-pg1-f178.google.com [209.85.215.178]) by imf16.hostedemail.com (Postfix) with ESMTP id C697B180002 for ; Wed, 11 May 2022 02:47:33 +0000 (UTC) Received: by mail-pg1-f178.google.com with SMTP id x12so588287pgj.7 for ; Tue, 10 May 2022 19:47:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=FU8nuOBOYophOA1hloaA7o9A3ff/ju/iZFOpgx4Wpp8=; b=HsHjcfA4jYrmtymqyGxlfvrOgbtR0AATiQX915JjYpQBDC9guuXBZ5fkE7SC4SChYF eCRgDqQ+NSw6GnyPOXDJn7/wGNIrob6UupYsYC7qxbfIPelGPkuyTnkNTicbaiCNGJN8 VO68ksXNyI6nSLJVESX7gKrwXPnwL1LDVRHBf6pvjX5Rw+a6JS3n/4vilUd7Peitm2On t0uyCGg6+E8MQCu0a6qO6ggWmi5zMvHk318FnjGyYZx4owtdDiFMHB2xz/E4aaxZsK92 CKoj6+GqXS7oBiDvZV550aDCccXaq8KLRXwW2rzA1RwQoQ8TGAaLR5rEbn3V5TPH6/bP TdrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=FU8nuOBOYophOA1hloaA7o9A3ff/ju/iZFOpgx4Wpp8=; b=7ef7rbZCoMTZauPxpAQ/72ISpkxYZIlIudUhmVgnNasvOQhFeIh9qIttN6M4KuKXbV 31XRROP6VnPb11Z9YWD/62pRhpbnH5pDaKf9KbdGx5FlksDfARmc3WsxUrBBEoaGiTlw UBdfRxRYYF3cw0TSHNlpI0H5AjauSe/i4gMWousJsttutw++nHt9V8WrGoaIFByC0v/L 3LSBawLAVBAGeV20WnYVScrATPEwTSEg1etpwPflsEny99gVSxa99m0GTHZNfntnX8Eh nnb4oae/mFtDzFb3U3IAe1f3p27tQYufpQ1auG7JgdC5ZLLIkkA3AFSoobTwQJPuJR9+ clXw== X-Gm-Message-State: AOAM533gFODS3r6QM9iltBZo4na8fgtLXUUQD4etUaaqRXQEueZ4L+45 ww+P6mtozLwq2OVTW2cTYMzXTCIhgTL9FJCg0oUFJg== X-Google-Smtp-Source: ABdhPJynco7KWu1tlLJFmHL3UbqOQ8ISOoU6Gvv0V/MUo2w+djtES+oiEgPw8O+7US6KMAW6NeoNZLivXil/V8Hw2i4= X-Received: by 2002:a05:6a00:1c53:b0:50d:5860:5b58 with SMTP id s19-20020a056a001c5300b0050d58605b58mr23066386pfw.85.1652237261347; Tue, 10 May 2022 19:47:41 -0700 (PDT) MIME-Version: 1.0 References: <20220505033814.103256-1-xu.xin16@zte.com.cn> <6275d3e7.1c69fb81.1d62.4504@mx.google.com> <6278fa75.1c69fb81.9c598.f794@mx.google.com> <6279c354.1c69fb81.7f6c1.15e0@mx.google.com> <627b1d39.1c69fb81.fe952.6426@mx.google.com> In-Reply-To: <627b1d39.1c69fb81.fe952.6426@mx.google.com> From: Shakeel Butt Date: Tue, 10 May 2022 19:47:29 -0700 Message-ID: Subject: Re: [PATCH] mm/memcg: support control THP behaviour in cgroup To: CGEL Cc: Yang Shi , Michal Hocko , Andrew Morton , Johannes Weiner , Matthew Wilcox , Roman Gushchin , Miaohe Lin , William Kucharski , Peter Xu , Hugh Dickins , Vlastimil Babka , Muchun Song , Suren Baghdasaryan , Linux Kernel Mailing List , Linux MM , Cgroups , Yang Yang Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: C697B180002 Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=HsHjcfA4; spf=pass (imf16.hostedemail.com: domain of shakeelb@google.com designates 209.85.215.178 as permitted sender) smtp.mailfrom=shakeelb@google.com; dmarc=pass (policy=reject) header.from=google.com X-Rspam-User: X-Stat-Signature: 7at78aey9yf1khdyi67g9kpza7tj7q84 X-HE-Tag: 1652237253-4453 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, May 10, 2022 at 7:19 PM CGEL wrote: > [...] > > > > > > > > All controls in cgroup v2 should be hierarchical. This is really > > > > required for a proper delegation semantic. > > > > > > > > > > Could we align to the semantic of /sys/fs/cgroup/memory.swappiness? > > > Some distributions like Ubuntu is still using cgroup v1. > > > > Other than enable flag, how would you handle the defrag flag > > hierarchically? It is much more complicated. > > Refer to memory.swappiness for cgroup, this new interface better be independent. Let me give my 0.02. I buy the use-case of Admin restricting THPs to low priority jobs but I don't think memory controller is the right place to enforce that policy. Michal gave one way (prctl()) to enforce that policy. Have you explored the BPF way to enforce this policy?