From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2427C4167B for ; Mon, 4 Dec 2023 23:33:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EB90D6B007D; Mon, 4 Dec 2023 18:33:26 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E69536B007E; Mon, 4 Dec 2023 18:33:26 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D31A26B0080; Mon, 4 Dec 2023 18:33:26 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id C06CF6B007D for ; Mon, 4 Dec 2023 18:33:26 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 97E301A041F for ; Mon, 4 Dec 2023 23:33:26 +0000 (UTC) X-FDA: 81530739612.26.F532B26 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) by imf12.hostedemail.com (Postfix) with ESMTP id C8D6840011 for ; Mon, 4 Dec 2023 23:33:24 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="lL9q2/2r"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf12.hostedemail.com: domain of shakeelb@google.com designates 209.85.214.175 as permitted sender) smtp.mailfrom=shakeelb@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701732804; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qZqna/86LEiJZ8sfNn0MkJuP6GYG4BaAXnD4RQG2ee4=; b=pqmBi/hq3BGKyTiAlMXJz7+0Bd93I9hROmfffbhgS7xoB4vWWhRF2J/RamQEzcY2ajZkf9 /uObO03G26qDtIzH2m4+jkzR45mFWThjEf9/hEpyw5/hKKIWhumrvQ3cRG/S8ze0M9ApOg cy0BXBg8mQ2VXGEms5HVKg85XC3qFKc= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="lL9q2/2r"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf12.hostedemail.com: domain of shakeelb@google.com designates 209.85.214.175 as permitted sender) smtp.mailfrom=shakeelb@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701732804; a=rsa-sha256; cv=none; b=nyAWSj/iaTRZzetFAUbCVlL2mS9hR8IAoDCSxCJnAxHTd7NCEoG6l8RilQ9QE31JtVduyh 6ZihFmqLqFrKOPYQJFuwGRYLtHb1/tjz5QHgRxcPRbcMBWo8PJD/KkMFq5o8RicvjZ5nUv 9mbAeu07x+cR8b3sn0tDfEeHABfv5sI= Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-1d0477a0062so64545ad.0 for ; Mon, 04 Dec 2023 15:33:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1701732804; x=1702337604; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=qZqna/86LEiJZ8sfNn0MkJuP6GYG4BaAXnD4RQG2ee4=; b=lL9q2/2rnhCPXnA6bOz63s+jjkCGVUZMXLPaBM4P/wLK7OJksg/IhdycTqNl0FDZHh +72E2CeG+LtH/5SZ8/7aNrMerd8eWz5RHMiVIDoB288Cg8Y8ebOUFadYCPJyRvbazIeN RxZJPOi1FSWMUn07swnuZ8bH0d2c0dD6WNN4zIkoSH31jyCU3WnwGF5O9+mnl/VDOCv8 NHBVrvMYrrnGdQC59Z3y/k2ggiyKN/nC0eo1Pp+Vw8zFASRrhSEWtLgJS++a/2+z9pTf oSBG79pAMJ8anDIGXLvOjYDG43f+Qffi13yMT/CV79ckYLSOYdK1UiLOMqM80Yjg9Jj0 SNtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701732804; x=1702337604; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qZqna/86LEiJZ8sfNn0MkJuP6GYG4BaAXnD4RQG2ee4=; b=IboESecsmqgskJgYFQlQVHI5FCjaRF7ustqHlC/g0GVSBKwO7V/RK5/ZQJzjtdBLfV TSCaJa4QLLJ7WRyD24iLoOYftj8YlXdf314PTkxRJFM2YmrQKviAxT/JeDihaPkNmq3R AEupo7q5Xssp6vmuYJrRkLtPj2txp2riVWze7IK5FGEyjpyM1NEGny0g3O32T0EILh/i +zkz8MZyGyM29UYE2Cx23lDje8M+rfM+mYwiY2vnGRcBuhHjAuCKbruZ5uthyt6RbJ9b 5wKcnQXGD/vxr91snXYjhjeHQTkCaN4qT0wfYZmPQgf26iYladVqOBsljGIPJNWVCAv0 7s/w== X-Gm-Message-State: AOJu0Yw5UaE2OLL9O9FkkU51t3S2eO0PIKGF0wzjudx1J1JJLRtqD+wr J65UI+dPrUSgcD4DcBohmH5s9bXPdiO35MHwTBddRw== X-Google-Smtp-Source: AGHT+IHhzF5+TZoeR/TGWLm64ZHxmuhpjlna8IvhMz9oC1nBjufnwyjSPPBFmLy862wYr2+inaHJT+2BWXYyh5430eo= X-Received: by 2002:a17:902:ab09:b0:1cf:9a44:1516 with SMTP id ik9-20020a170902ab0900b001cf9a441516mr682461plb.3.1701732803439; Mon, 04 Dec 2023 15:33:23 -0800 (PST) MIME-Version: 1.0 References: <20231204194156.2411672-1-davidf@vimeo.com> In-Reply-To: <20231204194156.2411672-1-davidf@vimeo.com> From: Shakeel Butt Date: Mon, 4 Dec 2023 15:33:11 -0800 Message-ID: Subject: Re: [PATCH] mm, memcg: cg2 memory{.swap,}.peak write handlers To: David Finkel Cc: Muchun Song , core-services@vimeo.com, Jonathan Corbet , Michal Hocko , Roman Gushchin , Shuah Khan , cgroups@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: C8D6840011 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: acudaataraccww8p5uy6wjxyh4k5iyjj X-HE-Tag: 1701732804-541566 X-HE-Meta: U2FsdGVkX1++LM2IgtDMk5N+8e2c5NUs78pdNT3UCC24fZmOnLeneNXsxWXinAdZl7fHdP+L9OHTbBpEIAqbesyQb+qep/OSZiHPEDdx1Ou0095UgkhZjfqE0ua7v4VfHoPvGhaxQdg4/2R4nrvIuV8q60EkQmlJ/aIUO5gDvzhkE6SVQh4pygBql1vPywg5JnV4rsP2OzXmf1woFQ3dM50wgeQijYg5BsjWOJbQwKSzXg+zhd4O3NuxPlUjfST4eDpiZqJLWUAi/IO8f3nqar7fwvlqpJzPhWSCZynf9m2an+Fa2u5q9oKc98scSogtQVscQy8eKCS1D2gebYesn11pjlXbe5wukUHdt17Z5Nrek+06H9N2nNnLbf8y3NmMEpB5oXUbqLnb2huDcxs486OFGhvt5FUWOTDrZ1BBYKcZQ9cuZaiQvL9Xa17nlj2jy+NlKj0aNrXgA3L5HgPeVT27cjEqey7aCjgYKtEPnLSWhBOYu3pzFEPIi8hKd/cPZ9AfWOaCRCehjnBrBVI+hKyUE5mQG56iYu8//fHqfEzQkT9SZW8smmeqDP984NV+wEh0o1jWvzMdtS06ndHIkjtJXKF8TrPYlkCvIAdPwg4KsKtMwtcvDHAo+uRNsKTbsQYJyRv4N6R0cRJxcn8HsH5M249t/HOLn7xmsCOxnRF3OmF1nd+HBuJcxPtYlMflrELYzsJLId2gBTsja6IS19U/F0u/7xOtitmjAP8SBBMhgnsw/IkL2GBl0759eitn2byt+VWtG8ynpcbsORGdCgkAw9UtvMjQ/aOQ+zuc0ZEY3yltPdEKlyPT0PXYGgVAMr4MbMVAwgVTeuJxlgqbtiBcJG/+lA6pmBBzd17O7WfE/Sg6my4VosXd487QQKZdQF2PFzxdNgyoZocvKlLgIAXLBy6DaRFecFszK0YLOEE2z6dlCk+gGflreJOX23YaiU8iJ26epdYfzqBP50w 5R/M1c5/ j1oYlQ5xUpSQfDF0otACgC+DjvTGFQrZY3alPeFdeUD8qyVZ8da8EFR0dn+sEYFD7mYQvZJDoM1GTEwsCyyDzVo24HbHGuWd/tOguNA2QUT4diA59U94/Ch8Kz1uoCfLf4ybjGyzoK2g/ekWmgVjTFgLvB8aFn1/ii/xP/35SWIwiM/ul+XTjXuoD3Y/C6FgeQp69Vjek1Q7khnTDowugM7Zn4Vqspq4vPraiZX7nGOZIw8nV6aFHWiQZPrOL0d/v7aMVpCwmMGy1R6W0NvUw4CtZmg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000048, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Dec 4, 2023 at 11:42=E2=80=AFAM David Finkel wro= te: > > Other mechanisms for querying the peak memory usage of either a process > or v1 memory cgroup allow for resetting the high watermark. Restore > parity with those mechanisms. > > For example: > - Any write to memory.max_usage_in_bytes in a cgroup v1 mount resets > the high watermark. > - writing "5" to the clear_refs pseudo-file in a processes's proc > directory resets the peak RSS. > > This change copies the cgroup v1 behavior so any write to the > memory.peak and memory.swap.peak pseudo-files reset the high watermark > to the current usage. > > This behavior is particularly useful for work scheduling systems that > need to track memory usage of worker processes/cgroups per-work-item. > Since memory can't be squeezed like CPU can (the OOM-killer has > opinions), these systems need to track the peak memory usage to compute > system/container fullness when binpacking workitems. > > Signed-off-by: David Finkel Acked-by: Shakeel Butt